From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6464921707679318016 X-Received: by 10.28.88.197 with SMTP id m188mr306326wmb.4.1505313659524; Wed, 13 Sep 2017 07:40:59 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.31.9 with SMTP id f9ls266059ljf.48.gmail; Wed, 13 Sep 2017 07:40:59 -0700 (PDT) X-Google-Smtp-Source: AOwi7QAgbxHwiUuX0HId7+9KBE0xL9O//WR9aOy1fu6MnUmzrS4J8YXaei9e27ZOK2BiYTisRBK+ X-Received: by 10.25.39.202 with SMTP id n193mr1479775lfn.13.1505313659000; Wed, 13 Sep 2017 07:40:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505313658; cv=none; d=google.com; s=arc-20160816; b=G+HWmLo/l/0g8a7jIe/972NKoGmhzO1mf5BUpeAeWPkDvTjv1Of5XMuThvURVlWsIP yJrRqs2SrYkNrul4AFVJcbrw5H9RR7vvTZJttSE1h/bRC6p+46RUKqqy4ktjGpIYlD2P z+qMH0+Gkg1qMPknkigf61U8D8M2tJBbcAbaUbfRg2Rm4nJlW4givQVTvzp0pzzK1NDl a3lqpr2zv8hc7+adrsn2nW7LsDSeKZXjvepGLW+ajnetB5gTVbHl70jAZanh6cgPfRVK hEw//n61TqkcA4NCLZi+7Gtt+u4WVkW9c+TQ9cLK7xZM28oiObn74V+dn3fRCadnfV7f 6JQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:openpgp:from :references:cc:to:subject:arc-authentication-results; bh=qEPAD07+3DxMKPTNbKe4f5nVTdUrlJKo/woSy02HuAc=; b=zq94GS6lC4v8Anv5KoxWUmIooRqoRANXJxDVRk0EuNQUps6mvvJ4AApO7mOwV9sLt8 BMvqgQW+bzh5O8r8frntRmL54ME/OyLZyds2PKwJ/70sOen44Sva3b+kGFLHCAHkQmEN eRbzp+jN5DZGRJ2Bf2TbdghtB3BlMrISMI5DQHqodIIntU+ajNohmBXJ8K5OzL3WnXl1 gSAmTS0jsy8v/5rSePVxIuOu0Eg5N+HH3/qLPfX9Sz2BJy8gE7vv4BvbqqaxGpN5y108 MikOag05fyUma9Zkh7BtZY5+ubBzAIVdxE5G93msac7s2ahGhTQ4juNl3zStxXskjoXE 6WwA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10]) by gmr-mx.google.com with ESMTPS id k18si102295wmd.1.2017.09.13.07.40.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Sep 2017 07:40:58 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.10; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3xskqZ4x4gz1qv3N; Wed, 13 Sep 2017 16:40:58 +0200 (CEST) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 3xskqZ4cB1z1qqkm; Wed, 13 Sep 2017 16:40:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id tKIXPphkzP7b; Wed, 13 Sep 2017 16:40:57 +0200 (CEST) X-Auth-Info: xKvCdoyeZt0DFJoI/wtXglAs349ikWqHs/QDixrs7zA= Received: from leda.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 13 Sep 2017 16:40:57 +0200 (CEST) Subject: Re: [PATCH v2 3/6] meta/dpkg: pull out actual build command from 'do_build' To: Henning Schild , Alexander Smirnov Cc: isar-users@googlegroups.com References: <20170912155810.9434-1-henning.schild@siemens.com> <20170912155810.9434-4-henning.schild@siemens.com> <20170913154120.1e10131f@md1em3qc> From: Claudius Heine Openpgp: id=6FF2E59F00C6BC2831D864C11173CB199808B153; url=http://pool.sks-keyservers.net/pks/lookup?op=get&search=0x1173CB199808B153 Message-ID: <55f37287-c7b7-7e8a-1319-50906a9e146b@denx.de> Date: Wed, 13 Sep 2017 16:40:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170913154120.1e10131f@md1em3qc> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ssrI3sD85QeL3l0GwSK2eVhfALffGoNQh" X-TUID: ODyOjs7Sc7g/ This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ssrI3sD85QeL3l0GwSK2eVhfALffGoNQh Content-Type: multipart/mixed; boundary="P0FdXRc726eJjQ9pH4OlLgbfqOT9nAvc9"; protected-headers="v1" From: Claudius Heine To: Henning Schild , Alexander Smirnov Cc: isar-users@googlegroups.com Message-ID: <55f37287-c7b7-7e8a-1319-50906a9e146b@denx.de> Subject: Re: [PATCH v2 3/6] meta/dpkg: pull out actual build command from 'do_build' References: <20170912155810.9434-1-henning.schild@siemens.com> <20170912155810.9434-4-henning.schild@siemens.com> <20170913154120.1e10131f@md1em3qc> In-Reply-To: <20170913154120.1e10131f@md1em3qc> --P0FdXRc726eJjQ9pH4OlLgbfqOT9nAvc9 Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: quoted-printable Hi, On 13.09.2017 15:41, Henning Schild wrote: > Am Wed, 13 Sep 2017 15:44:00 +0300 > schrieb Alexander Smirnov : >=20 >> Hi, >> >> On 09/12/2017 06:58 PM, Henning Schild wrote: >>> Issue: >>> The 'do_build' task in dpkg does more than just building, it also >>> prepares the build environment and cleans it up after building. >>> Other classes building debian packages might need the same steps >>> while implementing the actual build step in a different way. >>> >>> Change: >>> Pull the actual building out into a function that gets called from >>> 'do_build' between the pre and post stuff. >>> >>> Impact: >>> This patch does not change the behaviour of Isar. It addresses the >>> issue and prepares for another patch. >>> >>> Signed-off-by: Henning Schild >>> --- >>> meta/classes/dpkg.bbclass | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass >>> index abd4cef..5c3c1f8 100644 >>> --- a/meta/classes/dpkg.bbclass >>> +++ b/meta/classes/dpkg.bbclass >>> @@ -15,10 +15,15 @@ BUILDROOT =3D "${BUILDCHROOT_DIR}/${PP}" >>> do_build[stamp-extra-info] =3D "${DISTRO}-${DISTRO_ARCH}" >>> =20 >>> # Build package from sources using build script >>> +dpkg_runbuild() { >>> + sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} >>> +} =20 >> >> That's one of the weak places in Isar (also there are several others=20 >> with the same issue). If chroot failed - we will have some folders=20 >> mounted. Can we somehow track return value and perform clean-up if >> build failed? >=20 > I found that issue as well. But i decided to ignore it for now, because= > i did not introduce it. >=20 > It would be easy to deal with it. i.e. >=20 > mkdir > touch > mount > do > umount > rm > rmdir >=20 > would become >=20 > ret=3D0 > mkdir > touch > mount > do || ret=3D$? > umount > rm > rmdir > return ret Another solution might be to look into events and write some cleanup code there [1]. Cheers, Claudius [1] https://www.yoctoproject.org/docs/1.6/bitbake-user-manual/bitbake-user-ma= nual.html#events --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --P0FdXRc726eJjQ9pH4OlLgbfqOT9nAvc9-- --ssrI3sD85QeL3l0GwSK2eVhfALffGoNQh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlm5Q3gACgkQEXPLGZgI sVNmGxAAmIzuAN86duw2+a+DydMmwnyZNXBwtWnqwPfG5hFOLyYsvrizk28zs10k O7xsgVfBQP6eX0VA3FTGttiu0CJTPlzTEzGHgp0YNBltTHMEPvr13pQdcPXjQhvD JJYlTrVVY+ZiRfc1Wc00TQoSBfpPWr5fNK/YmY9L1xZbZauYwwDkxV1GFUaedBkT ka/LHp4e6qbydfyn/IOJi6S0mc6KhXYtTy77lXi0oPOrbZHbej/WfdHYQQqOafTn FNnbwvvQ7X4EwK5Z7HlyBCGaUkJNRQrHGfdJGDpT8SPmyE5QwxUOktlXSDkIz3xU oraGwi/60JRLnjstnoe8gvLWCRPzUGgMW1D/Aw63hqlIO7fp9FsUyNySEkhYyIqe eD3dV+LL57AM/bhgLxLR8HshBNWZ98p59hMX3bjUb8hkUjuQC2Ts31hjbomYKTR/ PZRhN3i1l0kWNL7GQ7oPJu8i2Q9lvuBNuFTbkiTPWpj45vCTzuSBt6fBzvTYFkbq opi5uVvJktK0d7Hafh/+B1EKWrLREx/mL1DvTN3JL0bevDucYJFHV7UjJJGX3pyw p5fjTPEGc+Ek7WAvQSfbMvGI1028stJqjc73cpeRBL4ODri02+YQ0LTtl1RQgm2D nuwzoYnMYUYFeGTQqG4Hkq1haJOl+Sp0x1V9pU0E2j33LzIic7g= =+6Fx -----END PGP SIGNATURE----- --ssrI3sD85QeL3l0GwSK2eVhfALffGoNQh--