From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH] linux-custom: Add lock to dependency installation
Date: Thu, 22 Feb 2018 22:25:25 +0100 [thread overview]
Message-ID: <561e3ebb-f877-596c-fde6-0f3bba770958@siemens.com> (raw)
From: Jan Kiszka <jan.kiszka@siemens.com>
The build script of linux-custom requires the same lock protection as
build.sh of the dpkg builder class. Otherwise, we see the infamous build
failures again due to contention on the dpkg database lock.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/recipes-kernel/linux/files/build-kernel.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh b/meta/recipes-kernel/linux/files/build-kernel.sh
index 94897ec..42c8ff6 100644
--- a/meta/recipes-kernel/linux/files/build-kernel.sh
+++ b/meta/recipes-kernel/linux/files/build-kernel.sh
@@ -13,8 +13,10 @@ REPACK_DIR="$1/../repack"
REPACK_LINUX_IMAGE_DIR="${REPACK_DIR}/linux-image"
REPACK_LINUX_HEADERS_DIR="${REPACK_DIR}/linux-headers"
-apt-get install -y -o Debug::pkgProblemResolver=yes --no-install-recommends \
- ${KBUILD_DEPENDS}
+# Lock-protected because apt and dpkg do not wait in case of contention
+flock /dpkg.lock \
+ apt-get install -y -o Debug::pkgProblemResolver=yes \
+ --no-install-recommends ${KBUILD_DEPENDS}
cd $1
make olddefconfig
--
2.13.6
next reply other threads:[~2018-02-22 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 21:25 Jan Kiszka [this message]
2018-03-04 19:50 ` Jan Kiszka
2018-03-05 7:16 ` Alexander Smirnov
2018-03-05 7:20 ` Jan Kiszka
2018-03-05 9:58 ` Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561e3ebb-f877-596c-fde6-0f3bba770958@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox