Re: [PATCH v2 1/2] Revert "Revert "isar-init-build-env: Add /sbin to PATH""

[Jan Kiszka <jan.kiszka@siemens.com>]

On 16.03.22 06:06, Jan Kiszka wrote:
> On 15.03.22 19:40, Anton Mikanovich wrote:
>> Image prepare tools like parted and mkfs.vfat from rpi-sdimg bbclass
>> can't be found in bullseye chroot because /sbin is not exported into
>> PATH by default. Add /sbin manually to fix the issue.
>>
>> This should be reverted after replaced rpi-sdimg.bbclass by WIC.
>>
> 
> Why this ping-pong, why not fixing it directly? Raspios limitations?
> With Debian, it's a no-brainer to use wic for generating Raspi images,
> as done multiple times downstream by now.
> 
> Jan
> 
>> This reverts commit d0bc682ee81da11f4b939165a4d4383af7ed99de.
>>
>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>> ---
>>  isar-init-build-env | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/isar-init-build-env b/isar-init-build-env
>> index 85fb82f..f3d1b6b 100755
>> --- a/isar-init-build-env
>> +++ b/isar-init-build-env
>> @@ -57,4 +57,8 @@ export ISARROOT
>>  }
>>  unset ISARROOT
>>  
>> +# wic executes mkdosfs

And that comment is wrong: wic is not involved, and it would not run
tools from the build environment, only from the buildchroot-target.

Jan

>> +PATH=/sbin:$PATH
>> +export PATH
>> +
>>  [ -z "$BUILDDIR" ] || cd "$BUILDDIR"
> 

-- 
Siemens AG, Technology
Competence Center Embedded Linux