public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: "[ext] claudius.heine.ext@siemens.com"
	<claudius.heine.ext@siemens.com>,
	isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [PATCH v4 1/1] meta: added do_transform_template task as templating system and switch
Date: Sun, 24 Mar 2019 19:28:39 +0100	[thread overview]
Message-ID: <56f05745-cd50-e946-e189-22402b7c4d63@web.de> (raw)
In-Reply-To: <20190214112850.12469-2-claudius.heine.ext@siemens.com>

On 14.02.19 12:28, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> The new introduced variables are TEMPLATE_FILES and TEMPLATE_VARS.
> TEMPLATE_FILES is a list of files that should be processed in the
> `do_transform_template` task and TEMPLATE_VARS is a list of bitbake
> variable names that should be substituted in the template file.
>

Bad news: This patch introduced a regression into the release (sorry, didn't
manage to test earlier). It destroys the reuse of self-built identical packages
for different targets. Namely, jailhouse-images now tries to build the shared
(per arch) kernel multiple times, and that fails miserably because there is a
common folder for all of them. The issue disappears when removing the
do_transform_template task from the chain.

Digging deeper, the reason is that do_transform_template is not shared but run
multiple times (even if nothing has to be done), forcing all succeeding tasks
into private mode as well. I suspect that's because bitbake cannot assess if the
output of the task python function is identical. I guess we need to help bitbake
here. Any idea how? Own stamping logic?

Jan

  reply	other threads:[~2019-03-24 18:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 11:28 [PATCH v4 0/1] Template system claudius.heine.ext
2019-02-14 11:28 ` [PATCH v4 1/1] meta: added do_transform_template task as templating system and switch claudius.heine.ext
2019-03-24 18:28   ` Jan Kiszka [this message]
2019-03-25  7:53     ` Claudius Heine
2019-03-25  8:13       ` Jan Kiszka
2019-03-25  8:21         ` Claudius Heine
2019-03-25  8:44           ` Jan Kiszka
2019-03-25 11:08             ` Jan Kiszka
2019-02-15 14:45 ` [PATCH v4 0/1] Template system Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56f05745-cd50-e946-e189-22402b7c4d63@web.de \
    --to=jan.kiszka@web.de \
    --cc=ch@denx.de \
    --cc=claudius.heine.ext@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox