From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6520199916203016192 X-Received: by 10.25.170.82 with SMTP id t79mr16941lfe.36.1518505396504; Mon, 12 Feb 2018 23:03:16 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.54.2 with SMTP id d2ls1424727lja.10.gmail; Mon, 12 Feb 2018 23:03:15 -0800 (PST) X-Google-Smtp-Source: AH8x226oNrH7v/11sdV7OEA3UmOho9SeLz+NzXrGUPM+AUXUQ2EcABOx+xOV6ibkzrlpDP127fUa X-Received: by 10.46.36.15 with SMTP id k15mr13079ljk.12.1518505395800; Mon, 12 Feb 2018 23:03:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518505395; cv=none; d=google.com; s=arc-20160816; b=xuRci62g/MeP75Ud44xIOMc7aUDLv8DP9SZrJAD0bzgiDPWfKVWSkz3nGv4eEWN8Oj ES68AIG86SxV01aYdZ6QsQJs5NKlQYXLncdQznbLuG3yce1BAw93OCQfdmMAMM9hvB7s fSDQRvUyb6LJIs1t5aIui8sexZ2S0PkqQ6vyKoLcXj1KQW06dVKL8OrmQ0tJofbOlAyi dJWN2reybJM2kc7Ibj956iHfVO8hMzvUoC9o7EPafjWf5owJmRWQErT8n05FrzXXU5L/ i9myKaoFW5qT137QkfNgJbsG9N16OGMLoAMaOAYmDXwhvhx4Vc2/kOcf5kkxY/H5VoDu TC5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=KtDHZSIXc/RRgPwn9S3i9jA0LXbH68DpH3Dw5GWAZ3Y=; b=l5VHlvalR8/5VjUVlXpfn0ruytWIeBYJuKxo7M06Tv6fDGsznTBVZTRpXvxVyIm70l +SLNFaRTUnqQN9JEZQ87C6KVzJboy9JFK2TbEcUxeFX9j/9Ign3xPvexD3grnbcYeUWw yaMQGbYc+quQVrTqTnf4IkYO1jN4c4XPJJTMFKl5OqNpNxpon+Nd6IGSDbp9Yhl/78zG IO0EhxgPpSFeM9jgkbmoCvDiTtvgJLpPQg//N1kSUyE0DfxeKe7zOKEP/3QiJqC2KcL/ bwQj9X4vslLZm2V8tcwa0DdbRovR9XvBgSQMZZmmNxww/lnBrHr1DShWEQYzPGI93wKd WBjw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id w29si694493lfc.5.2018.02.12.23.03.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 23:03:15 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w1D73DPv030722 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2018 08:03:13 +0100 Received: from [167.87.35.57] ([167.87.35.57]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w1D73Coh004705; Tue, 13 Feb 2018 08:03:12 +0100 Subject: Re: [PATCH v4 5/8] Provide class for easy custom kernel builds To: Alexander Smirnov , isar-users References: <10f71292d5c06de6909594c891f2478334106135.1518362719.git.jan.kiszka@siemens.com> From: Jan Kiszka Message-ID: <5771c955-dec7-8347-123d-d4b3f08e751a@siemens.com> Date: Tue, 13 Feb 2018 08:03:12 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: FFfDA7vWuQhP On 2018-02-12 19:56, Alexander Smirnov wrote: > On 02/11/2018 06:25 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> With this class, it becomes almost trivial to replace the distro kernel >> with a custom build. You just need to inherit linux-kernel, specify the >> source URI, define via S where the source is unpacked to and provide a >> defconfig. To switch to a custom kernel recipe, >> PREFERRED_PROVIDER_virtual/kernel has to be adjusted in local.conf or >> the distro conf. >> >> The approach works internally by first running "make deb-pkg" on the >> kernel and the repackages the output to make the binary linux-image and >> linux-header debs act as replacement of their distro packages. This >> results in a suboptimal technical implementation which may eventually be >> replaced by an isar-implemented deb-pkg build process. However, this is >> not expected to affect the user-visible interface of this class. >> >> Signed-off-by: Jan Kiszka >> --- >>   meta/classes/linux-kernel.bbclass | 98 >> +++++++++++++++++++++++++++++++++++++++ >>   1 file changed, 98 insertions(+) >>   create mode 100644 meta/classes/linux-kernel.bbclass >> >> diff --git a/meta/classes/linux-kernel.bbclass >> b/meta/classes/linux-kernel.bbclass >> new file mode 100644 >> index 0000000..5f4df3f >> --- /dev/null >> +++ b/meta/classes/linux-kernel.bbclass >> @@ -0,0 +1,98 @@ >> +# Custom kernel build >> +# >> +# This software is a part of ISAR. >> +# Copyright (c) Siemens AG, 2018 >> +# >> +# SPDX-License-Identifier: MIT >> + >> +DESCRIPTION ?= "Custom kernel" >> +PROVIDES = "virtual/kernel" >> + >> +inherit dpkg-base >> + >> +KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, >> kmod, linux-base (>= 4.3~)" >> +KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1, gcc" >> +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc" >> + >> +REPACK_DIR = "${PP}/repack" >> +REPACK_LINUX_IMAGE_DIR = "${REPACK_DIR}/linux-image" >> +REPACK_LINUX_HEADERS_DIR = "${REPACK_DIR}/linux-headers" >> + >> +dpkg_runbuild() { >> +    E="${@ bb.utils.export_proxies(d)}" >> +    sudo -E chroot ${BUILDCHROOT_DIR} sh -c ' >> +        set -e >> + >> +        apt-get install -y -o Debug::pkgProblemResolver=yes \ >> +            --no-install-recommends ${KBUILD_DEPENDS} >> + >> +        cd ${PP}/${S} >> +        cp ../defconfig .config >> +        make olddefconfig >> + >> +        make -j ${@bb.utils.cpu_count() * 2} deb-pkg >> + >> +        rm -rf ${REPACK_DIR} >> +        mkdir -p ${REPACK_DIR} >> +        mkdir -p ${REPACK_LINUX_IMAGE_DIR} >> +        mkdir -p ${REPACK_LINUX_HEADERS_DIR} >> + >> +        cd ${PP} >> +        tar xzf linux-${PV}_${PV}-1.debian.tar.gz -C ${REPACK_DIR} >> +        dpkg-deb -R linux-image-${PV}_${PV}-1_${KERNEL_ARCH}.deb \ >> +            ${REPACK_LINUX_IMAGE_DIR} >> +        dpkg-deb -R linux-headers-${PV}_${PV}-1_${KERNEL_ARCH}.deb \ >> +            ${REPACK_LINUX_HEADERS_DIR} >> + >> +        dpkg-gencontrol -crepack/debian/control \ >> +            -lrepack/debian/changelog \ >> +            -frepack/debian/files \ >> +            -plinux-image-${PV} \ >> +            -P${REPACK_LINUX_IMAGE_DIR} \ >> +            -DPackage="linux-image-${KERNEL_ARCH}" \ >> +            -DSection=kernel \ >> +            -DPriority=required \ >> +            -DProvides="${PN}" \ >> +            -DDepends="${KERNEL_DEBIAN_DEPENDS}" >> + >> +        # Add Debian-like link installation to postinst >> +        touch ${REPACK_LINUX_IMAGE_DIR}/lib/modules/${PV}/.fresh-install >> +        sed -i ${REPACK_LINUX_IMAGE_DIR}/DEBIAN/postinst \ >> +            -e "/^set -e$/a\\ >> +\\ >> +if [ -f /lib/modules/${PV}/.fresh-install ]; then\\ >> +    change=install\\ >> +else\\ >> +    change=upgrade\\ >> +fi\\ >> +linux-update-symlinks \$change ${PV} /boot/vmlinuz-${PV}\\ >> +rm -f /lib/modules/${PV}/.fresh-install" >> + >> +        # Add Debian-like link removal to postrm >> +        sed -i ${REPACK_LINUX_IMAGE_DIR}/DEBIAN/postrm \ >> +            -e "/^set -e$/a\\ >> +\\ >> +rm -f /lib/modules/${PV}/.fresh-install\\ >> +\\ >> +if [ \"\$1\" != upgrade ] && command -v linux-update-symlinks >> >/dev/null; then\\ >> +    linux-update-symlinks remove ${PV}  /boot/vmlinuz-${PV}\\ >> +fi" >> + >> +        dpkg-gencontrol -crepack/debian/control \ >> +            -lrepack/debian/changelog \ >> +            -frepack/debian/files \ >> +            -plinux-headers-${PV} \ >> +            -P${REPACK_LINUX_HEADERS_DIR} \ >> +            -Vkernel:debarch="${KERNEL_ARCH}" \ >> +            -DPackage="linux-headers-${KERNEL_ARCH}" \ >> +            -DSection=kernel \ >> +            -DDepends="${KERNEL_HEADERS_DEBIAN_DEPENDS}" >> + >> +        dpkg-deb -b ${REPACK_LINUX_IMAGE_DIR} \ >> +            linux-image-${KERNEL_ARCH}_${PV}-1_${KERNEL_ARCH}.deb >> +        rm -f linux-image-${PV}_${PV}-1_${KERNEL_ARCH}.deb >> +        dpkg-deb -b ${REPACK_LINUX_HEADERS_DIR} \ >> +            linux-headers-${KERNEL_ARCH}_${PV}-1_${KERNEL_ARCH}.deb >> +        rm -f linux-headers-${PV}_${PV}-1_${KERNEL_ARCH}.deb >> +    ' >> +} >> > > What is the benefit of having this script in the class? I see that we > have separate files for: > >  - buildchroot >  - kernel modules > > Why this chroot script should be a part of bitbake class? This makes > debugging much more complicated, because I have no possibility to run > this script manually from buildchroot (like I could do with build.sh) I played with it, and it "just" took 6 exports to set up the interface to script-based build. That will likely not be convenient for debugging as well (and I never had to call things manually that way, I got all information from logs), but I can keep that pattern. Will also mean: back to an include, rather than using a class (no big issue). > > Also formatting style looks nasty here. That's not going to change unless you suggest some alternative for the sed-based code injection into postinst/postrm. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux