Re: [PATCH v4 1/1] meta: added do_transform_template task as templating system and switch

[Jan Kiszka <jan.kiszka@web.de>]

On 25.03.19 09:21, Claudius Heine wrote:
> Hi,
>
> On 25/03/2019 09.13, Jan Kiszka wrote:
>> On 25.03.19 08:53, Claudius Heine wrote:
>>> Hi Jan,
>>>
>>> On Sun, 2019-03-24 at 19:28 +0100, Jan Kiszka wrote:
>>>> On 14.02.19 12:28, [ext] claudius.heine.ext@siemens.com wrote:
>>>>> From: Claudius Heine <ch@denx.de>
>>>>>
>>>>> The new introduced variables are TEMPLATE_FILES and TEMPLATE_VARS.
>>>>> TEMPLATE_FILES is a list of files that should be processed in the
>>>>> `do_transform_template` task and TEMPLATE_VARS is a list of bitbake
>>>>> variable names that should be substituted in the template file.
>>>>>
>>>>
>>>> Bad news: This patch introduced a regression into the release (sorry,
>>>> didn't
>>>> manage to test earlier). It destroys the reuse of self-built
>>>> identical packages
>>>> for different targets. Namely, jailhouse-images now tries to build
>>>> the shared
>>>> (per arch) kernel multiple times, and that fails miserably because
>>>> there is a
>>>> common folder for all of them. The issue disappears when removing the
>>>> do_transform_template task from the chain.
>>>
>>> Hmm, have you looked at the resulting 'TEMPLATE_VARS' variable? All
>>> variables in there need to be the same in order for it to have the same
>>> stamp. If that is not the case then maybe overwriting it instead of
>>> appending it might work.
>>>
>>> These are the defaults set in 'template.bbclass':
>>>
>>>      TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME
>>>                        MACHINE DISTRO_ARCH"
>>>
>>> If I understand you correctly then your recipe should not be dependant
>>> on the MACHINE? So either remove MACHINE 'TEMPLATE_VARS_remove =
>>> "MACHINE"' or just set a 'TEMPLATE_VARS' that you really need in your
>>> template files.
>>
>> OK, might be that "MACHINE" is the problem here. Will check. If that turns out
>> to be true, it is highly counter-intuitive and should be fixed, at least for
>> nop-jobs.
>
> Well sane defaults is always WIP :)
>
> I think I added this because the u-boot recipe in meta needed it. It seems that
> u-boot is special here.

OK, clearing TEMPLATE_VARS seems to address the issue (still seeing others, but
that might be a local topic).

Given these side effects, I'm in favor of removing MACHINE from the defaults.
The other vars look harmless, at least so far.

Jan