From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6652594697292218368 X-Received: by 2002:a2e:9597:: with SMTP id w23mr7393905ljh.111.1553503498151; Mon, 25 Mar 2019 01:44:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:4601:: with SMTP id t1ls1811188lja.2.gmail; Mon, 25 Mar 2019 01:44:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqxlgcTTdqSL5Q9CzPgrGmF2OPRsLnQmmKJV7ZH6Sn8XVhhQKIrGYLIprqMN7QYAW+Dq2EKj X-Received: by 2002:a2e:9ec2:: with SMTP id h2mr12321851ljk.186.1553503497698; Mon, 25 Mar 2019 01:44:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553503497; cv=none; d=google.com; s=arc-20160816; b=mKQbnHyHCWDZeND7YJm66w0/RQZc+LXe7oyVzKLXYVr1yov2FXieARtmkLExE8Cx+A Jx8tZD4CxM4KgH9fJDgTjLGll8Kk508IEEd8UAkzl4cpaQ4gAUtRuBJKl4rdGMmGyMD3 Fu0Y90lMt7OdPB2RJMfGJLXTBIa9ttXEvzQuBnHbqcWWQsRgys/4Uvw8/+LhjnIHo0dy hd3XISgsnf5e7mrhx3f1yj2N1xpE8X0xmd+0ecxSQ9KMwUEgUrH1XsvWX8sbJ42Ii7hJ eLocT8wfq0dNvmKnXnqPZpzALLT0yKKz+lw5K2/1BCiV7Xr10cLtS2VfdoQZ7NOMYX+3 mHXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=0qn5F1Pm9RMJW/4UM6CKcqQSFdesQ9gxFL4w5J4yzjc=; b=Zcf494UE+UMOwW6dLyQM/OwZfsVzfZl5iz1js/aeTxirVun3lVL5G9daHJWBv3V2m5 RrRSrMcwnccMtuaMxL092nNBBYFU1OfdzDVgw63Ym57NhG7qGwWPt/dtFSxyQvIhwzdC 0Pt7tuOHAyOJmLRc8Et+GjCFh9vmFe/CZESp1cDN/H3TIKVd4VCh2UdfjHtDC+MQkcdA zBmv6713Rz8my1fVRcayXxwvDxvBm92/7IZTeP/8DySeDU9Ca5VNVmtNmDmWkLd03fGd YVUeb8ed0FJ/3dulzsPDH38IMdEyiBPXPfPc9qKhymQK4BevWjoPy6f56cN1ZLjylwVw lmXQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=isa8M8E8; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.17.12]) by gmr-mx.google.com with ESMTPS id a22si81171lfl.3.2019.03.25.01.44.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 01:44:57 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.17.12 as permitted sender) client-ip=212.227.17.12; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=isa8M8E8; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553503496; bh=0qn5F1Pm9RMJW/4UM6CKcqQSFdesQ9gxFL4w5J4yzjc=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=isa8M8E8cv+QD1PmDXnKDcpmUTmqXztGyC+pkFhNSHLrpDb6/f77PTqF7TghSDgyo rE4MoL+QR8zapwGQsLxmJNmHHFo2j67wdatq84fBo5YvWm5WHYmY5rWu3w9SVcpW9I fkuc5VB+f9Bo2nP//gK+WvVFFuw0Cv8MFCvFTc6E= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M9ojk-1hEz4K38o4-00B5dy; Mon, 25 Mar 2019 09:44:56 +0100 Subject: Re: [PATCH v4 1/1] meta: added do_transform_template task as templating system and switch To: Claudius Heine , isar-users@googlegroups.com Cc: Claudius Heine References: <20190214112850.12469-1-claudius.heine.ext@siemens.com> <20190214112850.12469-2-claudius.heine.ext@siemens.com> <56f05745-cd50-e946-e189-22402b7c4d63@web.de> <15145951-bf01-4a34-7f55-0493573769f2@web.de> <038e94f9-547a-9704-3221-2956b6cde69a@siemens.com> From: Jan Kiszka Message-ID: <57786819-c53a-98ed-91f3-0c9adf2ddb7f@web.de> Date: Mon, 25 Mar 2019 09:44:55 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <038e94f9-547a-9704-3221-2956b6cde69a@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:tXAmpyRwslPeWvWScuTMqrL/DdslFGlUDAqOQqAcgyQMEsN0iPg ayfyqNdghvbOirruUu6qX30fjO+71KwhOCLHcnigj6wjH45STY7Z3QPOTHSPqLj8V9NYcrH yQ416eJteWvMYJIlxNQUnMntcqqja0f0makxalODUpbLghuMHpGCGD1kx7NcVEOKyfNj8j/ F0qLE298BJzzKjQ08oZ+w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nMSlf7+AmQQ=:I8w2I3n2xdOiDFQez2D2qW qjeuUNBF/6UhgYOG0c/znm+dCTBrIGRJznX2J6QFxFcpMaCJvx68hgyNLsvGnQauoneCiqGn3 zhRDNgPl/SgIw2wpLyLvK9gOqRUv5kF1yyf7NhDS4Ou9JLIScfIef2vt+3EoXzHb47D9Xfj38 2PPh66z3M5ULjdTZGOuhWf1wXM4mHsNo0E5ModVcwU1SX3VlHen2ge5bChv1pZahMhk6TOZv+ Qn2bz2aEfUJ4zS52TAii5eFfQxumW6gygdLCsHF2buQOTo1V04L8ZJfeVZeJCPPSFW67T0iZW Xl14KJvODeRrai5ykU+HNQ8hWV8ApYvLO4otY3E4e6UktkBs+ardYb/O+Hv+O4muvUI+meUsu G1Oh/SDQwfYieO633aG4GWv1qB48rJGbqbBDbVVKjZPFneI24TmSk+LoZUxWPEOgdfbjnwfGE tX3IZ/zrlsDhJXDB05men7PmpYHZrrUk8gQJejF7nKW+pf5uE5akNI0PW2KTFcYnNwsD2Y/se VEKG3DOWwBAaIq8P7Qa8Hcj9OloRxamxynicNZGG9IFMnFDikskt/Lvi5IEo0abOyi2fasUaJ OBZfE8aTMbx5RJa8dHL9F5tEiL9/kpkObU62mCcg6mQhmRZuIQsFZ2gf+t2NSgn07otIPHjvt R0GBYEd/QeF93Uspa0hNJRRvqOMQ2mGcdtRTGRocmA+D/ZnH02RNN8AECLbXgjBTNQLoelCit /V0Zh2uzGGYoLtf7omS5XCKYmoWROaJPfRW/t5sKW9AvxxIlWi3TXz9b3fY5C+7EU88OCcAYi bjIBCQtFf659wwgz35qJW/0S8UzvdIMxUL/gok6tjmbl5nU4zUnJi3PJ8c6ov/bBB4d2+kv7T KtY67HfkuTQEi8zKOn+Vgj7rF3Mqg7snHDozuIUKQmTbQaQMWou9YhJ7e/mS7o+j3WDgOvOyW l7J+xnn+URg== X-TUID: XmQmAwTnp+Hd On 25.03.19 09:21, Claudius Heine wrote: > Hi, > > On 25/03/2019 09.13, Jan Kiszka wrote: >> On 25.03.19 08:53, Claudius Heine wrote: >>> Hi Jan, >>> >>> On Sun, 2019-03-24 at 19:28 +0100, Jan Kiszka wrote: >>>> On 14.02.19 12:28, [ext] claudius.heine.ext@siemens.com wrote: >>>>> From: Claudius Heine >>>>> >>>>> The new introduced variables are TEMPLATE_FILES and TEMPLATE_VARS. >>>>> TEMPLATE_FILES is a list of files that should be processed in the >>>>> `do_transform_template` task and TEMPLATE_VARS is a list of bitbake >>>>> variable names that should be substituted in the template file. >>>>> >>>> >>>> Bad news: This patch introduced a regression into the release (sorry, >>>> didn't >>>> manage to test earlier). It destroys the reuse of self-built >>>> identical packages >>>> for different targets. Namely, jailhouse-images now tries to build >>>> the shared >>>> (per arch) kernel multiple times, and that fails miserably because >>>> there is a >>>> common folder for all of them. The issue disappears when removing the >>>> do_transform_template task from the chain. >>> >>> Hmm, have you looked at the resulting 'TEMPLATE_VARS' variable? All >>> variables in there need to be the same in order for it to have the sam= e >>> stamp. If that is not the case then maybe overwriting it instead of >>> appending it might work. >>> >>> These are the defaults set in 'template.bbclass': >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0 TEMPLATE_VARS ?=3D "PN PV DESCRIPTION HOMEPAG= E MAINTAINER KERNEL_NAME >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MACHINE DI= STRO_ARCH" >>> >>> If I understand you correctly then your recipe should not be dependant >>> on the MACHINE? So either remove MACHINE 'TEMPLATE_VARS_remove =3D >>> "MACHINE"' or just set a 'TEMPLATE_VARS' that you really need in your >>> template files. >> >> OK, might be that "MACHINE" is the problem here. Will check. If that tu= rns out >> to be true, it is highly counter-intuitive and should be fixed, at leas= t for >> nop-jobs. > > Well sane defaults is always WIP :) > > I think I added this because the u-boot recipe in meta needed it. It see= ms that > u-boot is special here. OK, clearing TEMPLATE_VARS seems to address the issue (still seeing others= , but that might be a local topic). Given these side effects, I'm in favor of removing MACHINE from the defaul= ts. The other vars look harmless, at least so far. Jan