From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6617812835611181056 X-Received: by 2002:a2e:7e08:: with SMTP id z8-v6mr141470ljc.8.1540967954273; Tue, 30 Oct 2018 23:39:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9b42:: with SMTP id o2-v6ls22145ljj.6.gmail; Tue, 30 Oct 2018 23:39:13 -0700 (PDT) X-Google-Smtp-Source: AJdET5faxi9/GdogaswuTvDwQgPffdQF0BPAxzMwcH+2tCf8OSaGmtXb7P1Gmlnc/VtO0LVjA2pX X-Received: by 2002:a2e:9597:: with SMTP id w23-v6mr143925ljh.25.1540967953650; Tue, 30 Oct 2018 23:39:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540967953; cv=none; d=google.com; s=arc-20160816; b=eW/ma3Q74j+RfjDemO88hLKH4dHn/m/vs+E0FzIqY/iaqYlTPh8FEzfvapkRYI0kh4 zdS0UpzzqDJhx6n0cDp+9+PfsvigBfGeifzCrkxIw5ILu3X48QBlriSqpX3ILQWyMSnr 24Kq6m5wcIiLDYkgr2600shahBY0DR6nJ1+URjL1QH5R+WOZwRTkyF0DqAKG8QpTrNXm 0FoWOIhHHZW2DDKBB+Y/OBQp4o2x9FFXHFSduc3VO6YUqtGBy1AC7zx/Luzx55uHH9G8 6mBMgpnBVV57TCTfD6ljiS0uQjZ0z1dHRzKgkMplJuqoVlyYiI80XyJR62xuX6kIGKac M2Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=kJ6mmHhkeOYWGItu0wGRiMtT1iEoG5yCkOfFSx2k/Dk=; b=eQzz7m3wnxRyiRxM5uwq6wm5svH2rugjuzyUWO1nAkiJhi9HekskaU1Dice2QlnfDQ TkefG6TA5Kl6YFvrKsMq2SmFJrfywbUTxmzqtoj9uHcwsDePpPH07gPXyw9TbpvtawFA D497+8HxEJQdPgXKZ8ue8MIJeNDwQPoAN6TruzwlyI7M91GFSxS52h5MaIFgNiYNxeOB DBfBK3EVyCaw+JRpljVAMmsJxq1Vt36gdGdTd/IRs9UuapaS55HIcBoeM+ajKfagxfQe 5E0Ef3VTNGjM3yqvT4FYlw58L++GVE8RgDb0FOONqrK2n35i7uKsZGTeAUAfdAabN/Ui 21iA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id w13-v6si925738lfe.3.2018.10.30.23.39.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 23:39:13 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w9V6dC6L002345 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Oct 2018 07:39:12 +0100 Received: from [167.87.39.79] ([167.87.39.79]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w9V6dBMi011307; Wed, 31 Oct 2018 07:39:12 +0100 Subject: Re: [PATCH v2 0/2] introduce isar-image class To: Cedric Hombourger , isar-users@googlegroups.com, Baurzhan Ismagulov References: <20181030134154.7adc8bf9@md1pvb1c.ad001.siemens.net> <20181031061025.28840-1-Cedric_Hombourger@mentor.com> From: Jan Kiszka Message-ID: <57847f7a-9b85-65ef-b11e-8952bf532e0f@siemens.com> Date: Wed, 31 Oct 2018 07:39:11 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20181031061025.28840-1-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: waqO1hW9fmos On 31.10.18 07:10, Cedric Hombourger wrote: > Reduce the previous patch series to only include the first two patches. > The changes will allow users to easily create their own image recipes. > Documentation was updated with instructions. > > The second patch refactors do_rootfs() into smaller functions to reduce > its complexity (one function == one purpose/goal). It was also changed > to become a Python function so it may be extended by other classes with > Python code. > > Patches introducing ROOTFS_*_COMMAND are on hold. I will investigate use > of e.g. IMAGE_TRANSIENT_PACKAGES to implement some of the features we are > currently carrying in our own project layers. > > Cedric Hombourger (2): > isar-image-base: introduce and use isar-image class > isar-image: refactor do_rootfs() > > doc/user_manual.md | 33 ++++++++++ > meta-isar/classes/isar-image.bbclass | 72 ++++++++++++++++++++++ > .../files => conf/distro}/debian-configscript.sh | 0 > .../files => conf/distro}/raspbian-configscript.sh | 0 > meta-isar/recipes-core/images/isar-image-base.bb | 57 +---------------- > 5 files changed, 108 insertions(+), 54 deletions(-) > create mode 100644 meta-isar/classes/isar-image.bbclass > rename meta-isar/{recipes-core/images/files => conf/distro}/debian-configscript.sh (100%) > rename meta-isar/{recipes-core/images/files => conf/distro}/raspbian-configscript.sh (100%) > Before we move things in meta-isar around: I'd like to first of all get rid of the dependency on meta-isar for building typical images. Everything that is not of demonstration purpose (specific boards, example recipes etc.) should go to the core layer (meta). Therefore, we should not introduce further generic classes to meta-isar. One background: I already ran into conflict with machine conf files in meta-isar that I wanted to replace with own configs in a downstream layer. While config overloading is possible, it's not as obvious as bbappend, nor does it work well in the presence of kas. So the better approach is avoiding it in the first place - e.g. by not pulling meta-isar. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux