public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Cedric Hombourger <Cedric_Hombourger@mentor.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH] image: include image name in the kernel/initrd image copies
Date: Thu, 18 Oct 2018 11:27:08 +0200	[thread overview]
Message-ID: <578d4e7b-292e-3795-08d7-041c9abe80ee@siemens.com> (raw)
In-Reply-To: <1539853468-156-1-git-send-email-Cedric_Hombourger@mentor.com>

On 18.10.18 11:04, Cedric Hombourger wrote:
> The kernel and initrd images are really image-specific (especially the later
> with the initrd being created/updated as packages get installed into the root
> file-system). Make sure we retain a per-image copy of these images in the

I don't buy this argument yet: Which additional parameters besides the and the 
MACHINE make kernel different? If there is any, can't we associate that 
variation more directly with the image then? It's surely not the image recipe name.

> image deploy directory by inserting the name of the image (${PN}) into the
> full name of the artifacts (set in ${KERNEL_IMAGE} and ${INITRD_IMAGE}).
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>   meta/classes/image.bbclass | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 05ff06f..c0af557 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -22,7 +22,8 @@ def get_image_name(d, name_link):
>       if os.path.exists(path_link):
>           base = os.path.basename(os.path.realpath(path_link))
>           full = base
> -        full += "_" + d.getVar("DISTRO", True)
> +        full += "_" + d.getVar("PN", True)
> +        full += "-" + d.getVar("DISTRO", True)
>           full += "-" + d.getVar("MACHINE", True)
>           return [base, full]
>       if os.path.islink(path_link):
> 

Jan

  reply	other threads:[~2018-10-18  9:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18  9:04 Cedric Hombourger
2018-10-18  9:27 ` Jan Kiszka [this message]
2018-10-18  9:46   ` chombourger
2018-10-18 10:29     ` Jan Kiszka
2018-10-18 10:37       ` Jan Kiszka
2018-10-18 11:45       ` chombourger
2018-10-18 13:53         ` Jan Kiszka
2018-10-18 17:23           ` [PATCH v2] " Cedric Hombourger
2018-10-22 12:49             ` cedric_hombourger
2018-10-22 13:52               ` Jan Kiszka
2018-10-25 11:19                 ` Maxim Yu. Osipov
2018-10-25 11:20                   ` Cedric Hombourger
2018-10-22 15:24             ` Henning Schild
2018-10-25 11:50               ` Cedric Hombourger
2018-10-25 14:22                 ` Henning Schild
2018-10-25 14:46                   ` [PATCH v3] " Cedric Hombourger
2018-10-26 12:58                     ` Maxim Yu. Osipov
2018-11-09 11:04                       ` Jan Kiszka
2018-10-22 15:48       ` [PATCH] " Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578d4e7b-292e-3795-08d7-041c9abe80ee@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox