From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6613620343774904320 X-Received: by 2002:a50:a90a:: with SMTP id l10-v6mr897372edc.8.1539854830218; Thu, 18 Oct 2018 02:27:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:8e89:: with SMTP id w9-v6ls10238845edw.7.gmail; Thu, 18 Oct 2018 02:27:09 -0700 (PDT) X-Google-Smtp-Source: ACcGV60vLGZHGg4PsLS1RpnaFOy2NjZptKOsYO1A2J87M9PODfwZ/4lj1mLGVRJsJqiptAgn1WCN X-Received: by 2002:a50:a550:: with SMTP id z16-v6mr889108edb.12.1539854829748; Thu, 18 Oct 2018 02:27:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539854829; cv=none; d=google.com; s=arc-20160816; b=bIdy8xSzxNqlmnzxHNgPkxE/riiMhxt32xOIrCvbzEPyiGIKmFTbKNtpzv3JeLnQn0 JgKvGpkU2hZunweQLuZTIwiwNd1WUol1MhGrWw4aQPSyug7uGkkNkfSdR4DbDdH9SEuP MCIA0IG2xIPwoFckN0+3O5qyNsv/9gOxIWfLhbiTRmkplDoSUoJUfIj9Sx461U1uEUnP 5YvP4HQqCwvDHEg+J95iZMp77nHBUROrTkGDP02eiVjzMdw+B6EiCLEr+nW6bCzzgkQI k57A98NTBWRGGia7XB1X8btCpviGPVRA3M8+XiQxWN95X4p+j50LlO34oNxW0EoBk6MN +MUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=uYvnPlQ5q0lQSjOOmWuY8zRlTzxzrOPKtVuZqxEsgKM=; b=LDHCPiZScwh5TsR/nYGHIc86F3XJDLM+aahF16CS+mQr5KuoGZu0u8+8tqBPnU3++X dcGwrdUCG60QBix/a0d3Nr4miCGWi8gmC7Hl9reiJjT2qTDUDUfBVZZdozW9WLUEd7eE b5SpmWJ03sRu0v2EINEBK+t6glKch0WDR2/LWUsdGNcS7/sjtXeR3ybjcpWGrFZApGi7 Q3N0fNITCp3QeY1daskgoidtgQuLTNJDq6zvBGUq8Fb9L6+NP2E59XT4b9sHtqYA0DsJ gJvYnzWsfyLdHDQ/FVCvcdCZeRa4rmZKCJy/byqlExX4568AqlJCG9RuOJJUEdL8smBn d7qA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id k41-v6si482311edb.5.2018.10.18.02.27.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 02:27:09 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w9I9R9WA009092 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Oct 2018 11:27:09 +0200 Received: from [139.22.39.23] ([139.22.39.23]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w9I9R8br027673; Thu, 18 Oct 2018 11:27:08 +0200 Subject: Re: [PATCH] image: include image name in the kernel/initrd image copies To: Cedric Hombourger , isar-users@googlegroups.com References: <1539853468-156-1-git-send-email-Cedric_Hombourger@mentor.com> From: Jan Kiszka Message-ID: <578d4e7b-292e-3795-08d7-041c9abe80ee@siemens.com> Date: Thu, 18 Oct 2018 11:27:08 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1539853468-156-1-git-send-email-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: A6VVdsEQaowp On 18.10.18 11:04, Cedric Hombourger wrote: > The kernel and initrd images are really image-specific (especially the later > with the initrd being created/updated as packages get installed into the root > file-system). Make sure we retain a per-image copy of these images in the I don't buy this argument yet: Which additional parameters besides the and the MACHINE make kernel different? If there is any, can't we associate that variation more directly with the image then? It's surely not the image recipe name. > image deploy directory by inserting the name of the image (${PN}) into the > full name of the artifacts (set in ${KERNEL_IMAGE} and ${INITRD_IMAGE}). > > Signed-off-by: Cedric Hombourger > --- > meta/classes/image.bbclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 05ff06f..c0af557 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -22,7 +22,8 @@ def get_image_name(d, name_link): > if os.path.exists(path_link): > base = os.path.basename(os.path.realpath(path_link)) > full = base > - full += "_" + d.getVar("DISTRO", True) > + full += "_" + d.getVar("PN", True) > + full += "-" + d.getVar("DISTRO", True) > full += "-" + d.getVar("MACHINE", True) > return [base, full] > if os.path.islink(path_link): > Jan