From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057120643105423360 X-Received: by 2002:a05:622a:15ce:b0:2d5:8d11:9e11 with SMTP id d14-20020a05622a15ce00b002d58d119e11mr21064554qty.524.1645512582520; Mon, 21 Feb 2022 22:49:42 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a37:6844:0:b0:648:d7e3:5c5c with SMTP id d65-20020a376844000000b00648d7e35c5cls3081876qkc.1.gmail; Mon, 21 Feb 2022 22:49:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0PDrl7oqg9CMNNSPUrvskcPJyoP10zdrFPmd9uO+iGRV3Jukt+zNSCWyWpE9Lft8SeYbL X-Received: by 2002:a37:6902:0:b0:606:853:fe50 with SMTP id e2-20020a376902000000b006060853fe50mr14333243qkc.751.1645512582115; Mon, 21 Feb 2022 22:49:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1645512582; cv=pass; d=google.com; s=arc-20160816; b=HUSw1RRI/GXPKSua5cdWCNwY3SFvGfKv2zms6GOLwfc7Py+gYxFMgbMmFtqrqDg/hE 8ut8aGH34wr3LEARvXa2egam+l/NeoSNdQt5EViy1Dj8sHkX/x1+H3MWBj1hym0T2L7W t6G8faqQPvQlhLwJ/Fsx02VT3uR9d2N7jH1jYauUE+riMc/AAfK7dLC0nSmQ+3ze/ubM jGwXCedjts+2uojtx6qCR12anXCSlEgUp8xkzi3iBPzvz6pyoQtCx0gZK4GMjlpoIeQb 8DbyU63fSaa/eiqoAGumj0okYqOxupnTvdS1f3gmU9/n2wamHkB67ZN1OTw5cCfSV3mm W6Rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=gJZflnIxHXq9k2VvLYXGkmUTxXZ3mS8REfZvkeoUqmU=; b=Gb7S0TBKgk3qfopVQ6Z9T7thqP3oOU/jK1lQIZIZqi8ORPWuPjjt26DufBJxDu2uRA 9+JvS6LAxZUG4UVu7f81ToPAHDineX14hpR4vya5KRVprZv6NG4ExEZChWTTUsD2EY9f Mos11AMq1AxjnxtNQjMiBcOfHUcfM+v7d/mpGjHFKpO4jTT1z3gsk5MdX6j40px1+2U8 7bYH2xUSYIWx5OfyeswehLClq9xHzZRaxVjZfc1xKfI9Y0WKrxz3tk4fbob/WgVeuc0/ TC5N95C5yyo6AnoEt4iTOmXqeUmxFFHrqosJRZ90tviFRVRDQLTOHl8YhedIdkH62ryA kTjw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ugbdI076; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe1e::600 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0600.outbound.protection.outlook.com. [2a01:111:f400:fe1e::600]) by gmr-mx.google.com with ESMTPS id f13si2164796qth.3.2022.02.21.22.49.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Feb 2022 22:49:42 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe1e::600 as permitted sender) client-ip=2a01:111:f400:fe1e::600; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ugbdI076; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe1e::600 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GM3Yekx9wRAeCAfGADkvlAlqAmphd5d/byJL4dN12xya5GBSwqMC38pPe/Tnf2024oEjR6kq7rVbzjd0y7uDXSDlnVtGtw9VhhLCcDdz7m6/OhJAdA0LFUM8WCMQDSAuNiXPebCNgSZW2THYXRMSvNmZhteQ5ToMiKdIWC4vg0n7dyqcVmNUhunvBDW1go4EsrNoeFXY9slFsa6pnqph5DdlfuylWpExtxiB+OhK+lw7hEoVo8BTHogk/0yv3Gm7YBye5OGe1he6xfHPG9W9LKyo6H4VFiWIPOjVjRHAZiNgJi2zRsjDjPQDfpKBjyIPxxbdgCHAG6Im9yOw/p8l9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gJZflnIxHXq9k2VvLYXGkmUTxXZ3mS8REfZvkeoUqmU=; b=Sp7RYOxrs0OgWt/5ERKjfUE7vF/7ssm0nqWC09hocj9Q8ajUx+G4PDtpeyfecN3nmL5IYMxVV6p8H/B4fK3yag18lukRisMRDoripykJIWTi4FmbTrHzGjMwDoKA1IY6LckE6oWlCWFDVR7VZdd6IEg81chyeUmQtjh0VSDA5R9oBOslbx8aRenJpw0kJ9xqvysYThJT2tCoOI0mFa4yOlkiu6RkPEOWfGbjExYITVkaomS2aWLEBEQCQBZH92rVQOKjfBrOahJKCY0a7fYl6qlyESHBfgOaVXoHPqgJATyr0WTcSM8CKSJqkwjMjU2lMiZcTbVhvIuU/+9V8PNnZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.70) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gJZflnIxHXq9k2VvLYXGkmUTxXZ3mS8REfZvkeoUqmU=; b=ugbdI076R4MNbb86iBRz9WT/ETVZyH9VKyb5MAueNdnGIz10f7bJW2TjBME8guRr5h6BH4FOR/3ikGdplMuvBLgVCeJgwRqpFI4ZuBXX6P7tcsH8OwmLhySQKgV1AXGr+1gz0DuWsJbwOmRCYptOMz9ncTpeUxT6/QGq+UhyyLJDHNQNdRd7gNef3p1oJKr8CwEYDtTQmOnR25UTmcJh0U2zamZrWW/0VCRz20RCAWh+uP4z9OF29EOhSf3I3TKcBcv3kJjFdF468CVEy1vEC21lg6XGgDjTgO6vk+kHCkaErPIMS1V3xnjRvoml/0F4TCM2SFcXQEOdhl1ep+nfEA== Received: from AM6PR0502CA0050.eurprd05.prod.outlook.com (2603:10a6:20b:56::27) by AM0PR10MB2818.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:124::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb 2022 06:49:40 +0000 Received: from VE1EUR01FT033.eop-EUR01.prod.protection.outlook.com (2603:10a6:20b:56:cafe::d1) by AM6PR0502CA0050.outlook.office365.com (2603:10a6:20b:56::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21 via Frontend Transport; Tue, 22 Feb 2022 06:49:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.70) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.70 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.70; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.70) by VE1EUR01FT033.mail.protection.outlook.com (10.152.2.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4995.15 via Frontend Transport; Tue, 22 Feb 2022 06:49:39 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SJA.ad011.siemens.net (194.138.21.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Tue, 22 Feb 2022 07:49:39 +0100 Received: from [167.87.32.158] (167.87.32.158) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Tue, 22 Feb 2022 07:49:38 +0100 Message-ID: <57982af9-8bf0-227e-a170-acad96eb6a26@siemens.com> Date: Tue, 22 Feb 2022 07:49:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 6/9] optee-os-stm32mp15x: Do not use shell environment Content-Language: en-US To: Uladzimir Bely , , "Anton Mikanovich" References: <20220213074111.23232-1-ubely@ilbers.de> <20220213074111.23232-7-ubely@ilbers.de> From: Jan Kiszka In-Reply-To: <20220213074111.23232-7-ubely@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.32.158] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3fd70533-6dc2-44d3-e606-08d9f5cf7f8d X-MS-TrafficTypeDiagnostic: AM0PR10MB2818:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zr6bJ1NKvxoMFUfk6yw3hv1HwajKQUx/u7PIzcoBkE/EnBXlCMMyRKjinMCoKUE2JgthZCoxZzcGuv2qia7eXdsxS3+EGUzl0jlvW53Bk43uLC58Mn4GxC6iInEZE3WF0ND92WfC4Jik9wBGpWJ5uNFt4SHsWsV5sS13pLfx5APVwc5mTxO5C/CfDuGTlZIFIfKNZt0B8aObeJH1cBVxI/z49MF/OIH6BTU3wXC3b4yDgGh5BuK5/kKu8BuKgTREcQWDQvsGGpXf01AvDzolYeHhKVMUrZzgOEaKI3x+M4xEsa1BDj0ViaziOGN5VYNF1CkzRlstqX73pxWs7roaSwA78uEA7gHicKz0TLQNlqeGFEowwZLjBFfs/3/D16rgOvHdKV7KVc7c1OiF69oLBIsZ6JHShBtsYmeAjNoBTMaRgJi2SHmiGWuwWIluMJc9efk99E+9dUfQfYEQ7V5szKPQv6L/oTFueJS/L0CVfMg2rakSt9FLhrg6sRH5sBiiw6uRy9Pz3Hf+kS9XVrlgud+etA3QLuQAuj2zX8Ul4ZHLinUi9yONA7TxeHvXCGffOoQef7PA2/y4L+3PyhaCfrpaUppv9pIHuedyxLcf59Z5Ye3+nqp7FQReGNetWCaoKCFqAqM5ya/45kUDk1QWokdWf7rn7je+RCD8dSyxebwZoQk65Zqb0scvALtVhn2WvBlGq77jNVIKw6MwOEein3gb9mS8n32yjmLF4r0RHM9xk6Axi7Y3nqkYZjx74ssa X-Forefront-Antispam-Report: CIP:194.138.21.70;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(86362001)(8676002)(31696002)(36860700001)(82310400004)(82960400001)(356005)(7636003)(40460700003)(70206006)(5660300002)(70586007)(316002)(16576012)(110136005)(7596003)(6706004)(31686004)(83380400001)(8936002)(44832011)(2906002)(36756003)(16526019)(2616005)(186003)(26005)(956004)(336012)(47076005)(508600001)(53546011)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 06:49:39.6208 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3fd70533-6dc2-44d3-e606-08d9f5cf7f8d X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.70];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT033.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2818 X-TUID: V0xXLiXC0m9z On 13.02.22 08:41, Uladzimir Bely wrote: > Move export of TEE_IMPL_VERSION variable directly to debian/rules. > > This makes building process more Debian-like. > > Signed-off-by: Uladzimir Bely > --- > meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb b/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb > index 0fa2005d..9c0efaf1 100644 > --- a/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb > +++ b/meta-isar/recipes-bsp/optee-os/optee-os-stm32mp15x_3.11.0.bb > @@ -21,5 +21,8 @@ OPTEE_BINARIES = "tee-header_v2.stm32 tee-pageable_v2.stm32 tee-pager_v2.stm32" > # Set version manually to PV, the tarball does not contain any hint. > # Alternative: pull from git and add git as build dependency. > dpkg_runbuild_prepend() { > - export TEE_IMPL_VERSION=${PV} > + cat << EOF >> ${S}/debian/rules > + > +export TEE_IMPL_VERSION=${PV} > +EOF > } I think I commented on this anti-pattern elsewhere already: This can lead to piled-up extra lines in the target file. Now that it's merged, please fix up on top, e.g. using a sed rule that avoids duplicate patching or appending to the unpack step. Please also check if you used it elsewhere in fix those spots accordingly. Jan -- Siemens AG, Technology Competence Center Embedded Linux