From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6526857818487652352 X-Received: by 10.28.71.132 with SMTP id m4mr149378wmi.28.1519999037789; Fri, 02 Mar 2018 05:57:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.157.140 with SMTP id p12ls2803577wre.2.gmail; Fri, 02 Mar 2018 05:57:17 -0800 (PST) X-Google-Smtp-Source: AG47ELshBWxvsfEXfdbM/Dclh1cRlCh+yYu3Cn347Iow0aESsP55dLS8Jl0CgA1ZUCmz7yNICDUB X-Received: by 10.223.150.47 with SMTP id b44mr561087wra.7.1519999037240; Fri, 02 Mar 2018 05:57:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519999037; cv=none; d=google.com; s=arc-20160816; b=ecRTPmOLsGpCsEhzmcjsx5xKMUnWquYBc61RovTCIM5tvVUuuvD98lhKTif8Pb9kDz 6Z+oUK6wz3GFxzlewt7RTGFjiFwnORI4x6ef4hmCj4xC1Muh6DiW+YWbreFdoDOvtSEV 4VWevIdIaMfTSpGPsVA0r62LlQV7M9YDiDop7zQdmi/Uxr5RoVJjI1mSbhrzJSRsUEfG TMvS0sBNt9kxG3L533ZPXq+IMpUmAdfO5/h9iWhzfH2WWIrmKzoFpB25/3Y0CWAHje3Y zxpU7IcfoLNfF8wg4Xm5ngDZqQJ9z4k9jFrmw+DAtRNj+I22oS9POWSDw4Td8JulYXIs HosA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=jgTp/iLU1oUz3BarAwTdV6+2MsSJpr/IsRmmSjGQnRE=; b=nJ/DY5adVFKusIjWYLPUWGjV2C8y015IGRSdvOGhruwqNJL6JeO5nGf+xkOongU3ve uRf9LuJhEWcm07PuI2czI5DjeZyhqxNd5jnHP6JSQbhfBlyZ+CFe2sDGv1Uc5TNCukxV 3rqlJvSyykvBHa0OWLXCxH6SXnjeDkJRFbyip6R/Pw9F7iPtppFVoCZVaxLEhU2pKs95 3pbtTo6puNgVjT4GOZ2iSF7NYbaM4clqVwfXVmYoGD+K6MUj0L47S++7ldaZkIBPEKst Rk5SccTPXBljr8Cl2a4cS4LYDm+VCC03kKlTthCk7g18BtVdn3ToXa8Ib72FYfCj0Lrh bnpQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id f137si71192wme.0.2018.03.02.05.57.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Mar 2018 05:57:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w22DvE1n001419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 2 Mar 2018 14:57:16 +0100 Subject: Re: [PATCH] Include error log of failing task in output To: Jan Kiszka , isar-users References: <955aab45-bca0-7458-e3d6-a90616d2cbd7@ilbers.de> <34f64f37-d5ec-5135-96aa-5e1a99d6c264@siemens.com> <5c9f3414-e119-53be-5283-9278a8637bb4@ilbers.de> From: Alexander Smirnov Message-ID: <58c2463b-bfa9-7785-1b5f-6ae2ede05d3c@ilbers.de> Date: Fri, 2 Mar 2018 16:57:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: zSrAvt3e79uZ On 03/02/2018 04:24 PM, Jan Kiszka wrote: > On 2018-03-02 14:04, Alexander Smirnov wrote: >> >> >> On 03/02/2018 03:46 PM, Jan Kiszka wrote: >>> On 2018-03-02 13:43, Alexander Smirnov wrote: >>>> >>>> >>>> On 02/26/2018 04:41 PM, Jan Kiszka wrote: >>>>> From: Jan Kiszka >>>>> >>>>> Particularly helpful in CI environment, but it also saves many manual >>>>> log dumps. >>>>> >>>>> Signed-off-by: Jan Kiszka >>>>> --- >>>>>    meta/conf/isar-bitbake.conf | 2 ++ >>>>>    1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/meta/conf/isar-bitbake.conf b/meta/conf/isar-bitbake.conf >>>>> index b49386c..8a1d86b 100644 >>>>> --- a/meta/conf/isar-bitbake.conf >>>>> +++ b/meta/conf/isar-bitbake.conf >>>>> @@ -42,6 +42,8 @@ BB_STAMP_POLICY ?= "full" >>>>>      BB_NUMBER_THREADS ?= "${@bb.utils.cpu_count()}" >>>>>    +BBINCLUDELOGS ??= "yes" >>>>> + >>>> >>>> Is there any specific reason of using the weakest assignment here? The >>> >>> Because all tuneable confs are included after this statement. >> >> In my understanding, tuneable confs should not contain "?" marks in >> assignment, because they specify concrete configuration. :-) That's what >> I see, for example, in local.conf file. >> >>> >>>> whole file contains "?=" only, for me this looks enough here too. >>> >>> That's likely a bug to be fixed separated. >> >> What is your overall policy for assignment in this case? > > Upstream: Look at oe-core's bitbake.conf. It seems to do weak defaults > pretty consistently for stuff that might be set via ?= in other confs. > Yeah I saw it, but who could overwrite BBINCLUDELOGS? For me this option has the same level as BB_NUMBER_THREADS or PARALLEL_MAKE. So IMHO the only local.conf file is the place to overwrite it. I've looked into OE/Yocto bitbake.conf, and I think there is the following logic that in my opinion makes sense: - Global build system settings are mostly defined using "?=", because they should be overwritten in some global file like local.conf only. Tuning this parameter in machine/*.conf is definitely bad idea. - Settings, related to produced results, like DISTRO, MACHINE, LDFLAGS etc. are defined using "??=", because such things could be overloaded from machine/distro config files, from generic recipes etc. So I still propose to use "?=" here. Alex