From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057120643105423360 X-Received: by 2002:a67:c90f:0:b0:31b:9534:139 with SMTP id w15-20020a67c90f000000b0031b95340139mr8985412vsk.82.1645512648221; Mon, 21 Feb 2022 22:50:48 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6122:a18:b0:331:2000:a64a with SMTP id 24-20020a0561220a1800b003312000a64als1213890vkn.8.gmail; Mon, 21 Feb 2022 22:50:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZIpZvU16sfhJXJXQe56QF3TJWmz6vAfJqVewaHO6S0CFT1OCrfxmBUmDaf6bzTxdJdynd X-Received: by 2002:a05:6122:7c8:b0:331:5fd8:1e83 with SMTP id l8-20020a05612207c800b003315fd81e83mr7762030vkr.25.1645512647578; Mon, 21 Feb 2022 22:50:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1645512647; cv=pass; d=google.com; s=arc-20160816; b=s1wHymj/FT0DtF2ezxSUkOW9K0Wi77UnhQvewldYhtz0/B2dX99zPjxsBEKPQUU7eU 3/k6DYXm1wZmI+tc5dcFSokULRkESV/Tp2pzC5ZC0oQ5BGzAh4CoEz8rD3/25VYuDjPT UCDt4NaQBYStvVcMX6mgvaqbsmfU7edZ1qThst5bzJmpjZK9StKXGizvR+xXAgryR8yd N+ye4nYkYpZoCNvAY/MICfwf6ZpB/4CFlHk8JY+5uiJ/2jdcHIu46hxM5xGZCNlSI/AE diWvDGQnvg7AHa8W0j5VoZaH7vujQaptgWpyd0iFIRdoaQyptQQZu3KZYxO6ew8QUfga TqwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=v6SHFR4UdpEjtNrKxM7fF0FAHzZ/guMAmSB+d90bfp8=; b=GdUu+ssxRnmXhPwgJkoH1upibxpoJitTb2NGJqrg+PNgYIVr/axzk6WRsVkobdL6So z/cK7CJW8v3FX7xW9NsO3WaEemlJix4EphdNgIGGpo1fIfpGw9Twlc2k1rpCE1u5vA2D TK0fpvk68cc6wNxzbACA43Sqv7dttQf8ChDcKlQveB17jH8Dam9PaoK+1mpvIoyqeoR1 DkW6M5Yvn9TieSu/oqs34SZA7RBwAyc3M5cYZfhTZQ6IyPfZENE1MjlTVmRxPRw8dG1B E26JSUKLC5cCUhsjnkUwPJZ8VJ9v6BPKaz9bFwl3wHa3V3ahaj+JzmOhPoN5llHSntvK vZDg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=EyO1AKG5; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::606 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0606.outbound.protection.outlook.com. [2a01:111:f400:fe0c::606]) by gmr-mx.google.com with ESMTPS id p200si1624758vkp.2.2022.02.21.22.50.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Feb 2022 22:50:47 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::606 as permitted sender) client-ip=2a01:111:f400:fe0c::606; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=EyO1AKG5; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0c::606 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MP+A5LXjiNUCTi4JoOnPhKC5SZOfLKR2XRSgooJUCR4eJ7ZrOGaJvm0Ygt6WYQbIwWHKzqEgo26DGIxKyqIrxpmfDmYvr2ONLmJJUzN7QAB/vlFpZQE9QUVV2jCrTVYxSQ3e5fL5X0xfHpfyzQPG7JWqDcgTQ9sUL7l1KFMpG8vtg9KDa8z2CHf/zLopi0/NPoDqjoN9TBI4v8712mhRg1aiVemnK+FYfHaXgM79NV0qbj1ibu9TzsQysBfVqf/ciNbvhqu92fHjb374FxpFvuZGZvCRSZHgfGtR3Xmg2NXW+0RDU6jUhUhLAwJZaPa98OEGDRwNu2YB82CThG7pMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v6SHFR4UdpEjtNrKxM7fF0FAHzZ/guMAmSB+d90bfp8=; b=YHcUqfq5ARsBgbdDipttANqqDT2VkWX9Hy8yJm9dVDHpOK8fN0C5GIDhOX8jkbUOuSi50zbgvFGqkQc4p8urYbVYOvTOFH8AIEgTMnZgqIuXgdKzMjJYM4HHzaGcsNlBnWppXu+SMb8bXB+xqUIwMPlFQSTL45HufEMSFy7h0YhTcBnSw/lQpsT9YIQFbiuRflFh9OdsYAfsvCsnEzXUGgKhCE3EHjYs3bpAxjyfSTkee7Pt0glDSDVIcO9BGgiDU2PvwD8n3Pu0AnBAwztf4nJ7aYaQNduy1dVyHB6czw/538Dr09G8mb8Z677vUSkFvmCtu5QfvZCLqE9pc5gT/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.70) smtp.rcpttodomain=ilbers.de smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v6SHFR4UdpEjtNrKxM7fF0FAHzZ/guMAmSB+d90bfp8=; b=EyO1AKG5IiacaV64akB97qCnOhtegWcZXn8Opb8auFeO1Byu6AahpGluadB13LLF2/+zHtvvFKUQLtBZraaW3JQup5qIeE2iqT2hBkFi2zZtzQs4GlQtH/kocKOUBLeJYpgLs/qogpbWpWNxenEh0WDvExEnpLDXxTwfLw6htSjBTrlpsCRLUwufnRxn8ebfoC8EEZTORkfk5Zoq/G2BcxzVXCAG19pLhKDyPw8S1vnWSM7eEUjc2px9aVwWVSuxxgq24/87lnj8eVPS6pO96YLMtMLXe6OwWjAGOUpQxqNKqVCfPp0ac44i6UgoZQ/TgX4sZPmPDbcDBaKr+64QIQ== Received: from AM7PR03CA0023.eurprd03.prod.outlook.com (2603:10a6:20b:130::33) by DB8PR10MB3100.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:bf::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb 2022 06:50:46 +0000 Received: from VE1EUR01FT015.eop-EUR01.prod.protection.outlook.com (2603:10a6:20b:130:cafe::aa) by AM7PR03CA0023.outlook.office365.com (2603:10a6:20b:130::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21 via Frontend Transport; Tue, 22 Feb 2022 06:50:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.70) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.70 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.70; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.70) by VE1EUR01FT015.mail.protection.outlook.com (10.152.2.237) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4995.15 via Frontend Transport; Tue, 22 Feb 2022 06:50:45 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SJA.ad011.siemens.net (194.138.21.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Tue, 22 Feb 2022 07:50:45 +0100 Received: from [167.87.32.158] (167.87.32.158) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Tue, 22 Feb 2022 07:50:44 +0100 Message-ID: <58e6aaf5-945d-d283-6c7d-18a478258003@siemens.com> Date: Tue, 22 Feb 2022 07:50:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 8/9] linux-mainline: Move cfg fragment test to debian/rules Content-Language: en-US To: Uladzimir Bely , References: <20220213074111.23232-1-ubely@ilbers.de> <20220213074111.23232-9-ubely@ilbers.de> From: Jan Kiszka In-Reply-To: <20220213074111.23232-9-ubely@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.32.158] X-ClientProxiedBy: DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c716396-6488-45c3-a7f8-08d9f5cfa6c9 X-MS-TrafficTypeDiagnostic: DB8PR10MB3100:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u6y7baG/s1Oz+I2zSMx52ltTscSL+a7AxQ/iDRlII/THncvOzeOkl4HXNPFrsKIBB9MWTM+wKP89uz817i+Os1hmc7kWnpagH0bDEJMYrFYqa7/I11aWIj+23WFEzd7vBhpClHPhhUFqUJn2pmRm3po7RzziOyfHNTTjyjbZ5k8l58lCmsORX6jrg7TGG8Z/4FC3JMGngZThWsnA25c8ODDDQqQaweBZV5We5UHt2ujiwrWzP9u31/YekNsoogb/+A2Ys1rOGevP+a7FvX1n3BQZD3q9F7nSYI3SfLg7e9/zv9kdrME40H76md3srjYt8H9hKkdUgzt92yscPlWYQhwrwOFZgletoFwWYsDydkzoAYYVmai5llptEpwVfFdxm4OdC4E3q1ZwWUmhX2jNycVOJ0pU9ZPEZw+j2YhDkG7V8+X12RV7VQebTIyghOfXX9LawNyX+x3NduJCCwQmU0lAS7a/Inp5D5rJ9JF6Vt0LSeub7BWd3YAogX5q0Md1ojiNQJjK4pVH0XRPL8v4lnxQkEamKGTeoDMkqqUZWjeM+GvJfBUddmHj7VZ03AB+tvnBQLgAmoNV4eR8tw3qbt+5+sSN6qwgaH2bNLCvqNRKVhhNmvCc6LLyYsyF+yk6SaG0h8cESBEeusIud632DZ5MoirbBWEuxUUvXwg1qGWsH/Tr4KPGiYODFp5F2i7synlaNrVW5GJIS6Aa1DA+KqP3bznck8s+nF0KSvlvhD2Y3+pk62R7tSzFfqyAFsC2 X-Forefront-Antispam-Report: CIP:194.138.21.70;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(82310400004)(70206006)(70586007)(8676002)(508600001)(6706004)(316002)(16576012)(336012)(83380400001)(110136005)(31696002)(8936002)(5660300002)(956004)(2616005)(36756003)(53546011)(7636003)(82960400001)(356005)(7596003)(47076005)(26005)(186003)(40460700003)(2906002)(86362001)(16526019)(31686004)(36860700001)(44832011)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 06:50:45.4279 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c716396-6488-45c3-a7f8-08d9f5cfa6c9 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.70];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT015.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3100 X-TUID: kH0jN1sew4Zf On 13.02.22 08:41, Uladzimir Bely wrote: > From: Anton Mikanovich > > Perform all config fragments checking in Debian way. > > Signed-off-by: Anton Mikanovich > --- > .../linux/linux-mainline_5.4.70.bb | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/meta-isar/recipes-kernel/linux/linux-mainline_5.4.70.bb b/meta-isar/recipes-kernel/linux/linux-mainline_5.4.70.bb > index 980e137b..28e51c0d 100644 > --- a/meta-isar/recipes-kernel/linux/linux-mainline_5.4.70.bb > +++ b/meta-isar/recipes-kernel/linux/linux-mainline_5.4.70.bb > @@ -25,11 +25,13 @@ LINUX_VERSION_EXTENSION = "-isar" > > # For testing purposes only > dpkg_configure_kernel_append() { > - if ! grep "# CONFIG_MTD is not set" ${S}/${KERNEL_BUILD_DIR}/.config && \ > - ! grep "# CONFIG_MTD_UBI is not set" ${S}/${KERNEL_BUILD_DIR}/.config; then > - grep "# CONFIG_UBIFS_FS is not set" ${S}/${KERNEL_BUILD_DIR}/.config || \ > - bbfatal "Self-check failed: CONFIG_UBIFS_FS still enabled" > - fi > - grep "CONFIG_ROOT_NFS=y" ${S}/${KERNEL_BUILD_DIR}/.config || \ > - bbfatal "Self-check failed: CONFIG_ROOT_NFS not enabled" > +cat << EOF | sed -i '/^override_dh_auto_build/ r /dev/stdin' ${S}/debian/rules > + if ! grep "# CONFIG_MTD is not set" \$(O)/.config && \\ > + ! grep "# CONFIG_MTD_UBI is not set" \$(O)/.config; then \\ > + grep "# CONFIG_UBIFS_FS is not set" \$(O)/.config || \\ > + (echo "Self-check failed: CONFIG_UBIFS_FS still enabled" && exit 1); \\ > + fi > + grep "CONFIG_ROOT_NFS=y" \$(O)/.config || \\ > + (echo "Self-check failed: CONFIG_ROOT_NFS not enabled" && exit 1) > +EOF > } As commented on in patch 6: anti-pattern that we should avoid in Isar code. Jan -- Siemens AG, Technology Competence Center Embedded Linux