public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Subject: [PATCH 4/4] imagetypes_wic: Deprecate WIC_IMAGER_INSTALL
Date: Fri, 10 Nov 2023 18:41:27 +0100	[thread overview]
Message-ID: <59533519e092d29351dc0595f6324daf06502279.1699638087.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1699638087.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Issue a warning that suggests the now preferred alternative if it is
still used but keep it functioning.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 RECIPE-API-CHANGELOG.md             | 6 ++++++
 meta/classes/imagetypes_wic.bbclass | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index b1699be6..fa73cb57 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -554,3 +554,9 @@ Default value is '-I' which sets filter to:
 -I.cvsignore -I.deps -I.git -I.gitattributes -I.gitignore -I.gitmodules
 -I.gitreview -I.hg -I.hgignore -I.hgsigs -I.hgtags -I.mailmap -I.mtn-ignore
 -I.shelf -I.svn -ICVS -IDEADJOE -IRCS -I_MTN -I_darcs -I{arch}
+
+### WIC_IMAGER_INSTALL is deprecated
+
+Use `IMAGER_INSTALL:wic` instead of `WIC_IMAGER_INSTALL?. The latter is still
+supported, but a warning is issued when it is used. Future versions will drop
+`WIC_IMAGER_INSTALL` completely.
diff --git a/meta/classes/imagetypes_wic.bbclass b/meta/classes/imagetypes_wic.bbclass
index e150c0e9..4c74f166 100644
--- a/meta/classes/imagetypes_wic.bbclass
+++ b/meta/classes/imagetypes_wic.bbclass
@@ -19,6 +19,9 @@ python () {
     if not d.getVar('USING_WIC') == '1':
         return
 
+    if d.getVar('WIC_IMAGER_INSTALL'):
+        bb.warn("WIC_IMAGER_INSTALL is deprecated, use IMAGER_INSTALL:wic instead")
+
     import itertools
     import re
 
-- 
2.35.3


  parent reply	other threads:[~2023-11-10 17:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10 17:41 [PATCH 0/4] IMAGER_INSTALL cleanups Jan Kiszka
2023-11-10 17:41 ` [PATCH 1/4] imagetypes_wic: Prepare for WIC_IMAGER_INSTALL being undefined Jan Kiszka
2023-11-10 17:41 ` [PATCH 2/4] Convert WIC_IMAGER_INSTALL to IMAGER_INSTALL:wic Jan Kiszka
2023-11-10 17:41 ` [PATCH 3/4] meta-isar: Limit wic-related imager dependencies to that image type Jan Kiszka
2023-11-10 17:41 ` Jan Kiszka [this message]
2023-11-10 22:00   ` [PATCH 4/4] imagetypes_wic: Deprecate WIC_IMAGER_INSTALL Florian Bezdeka
2023-11-21  7:02 ` [PATCH 0/4] IMAGER_INSTALL cleanups Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59533519e092d29351dc0595f6324daf06502279.1699638087.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox