public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Cedric Hombourger <Cedric_Hombourger@mentor.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH v6 0/2] rbind mounts for /dev and /sys
Date: Tue, 27 Nov 2018 17:45:26 +0300	[thread overview]
Message-ID: <59566b71-f70a-ba1a-fd63-d6ea6d24c84d@ilbers.de> (raw)
In-Reply-To: <1542717658-157-1-git-send-email-Cedric_Hombourger@mentor.com>

Hi Cedric,

After applying these patches I've recognized that after
running ci_build.sh script, the number of mounts significantly increases.

On my PC it looks like that

$ mount | wc -l
34
isar$ ./scripts/ci_build.sh -q -f
...
$ mount | wc -l
100

If I revert these patches the number of mount points
stays the same after running ci_build.sh script.

This behavior significantly affects CI -
builds start to fail. This is a blocking point for CI and if we don't 
find a quick solution I will have to revert these patches in 'next'.

Thanks,
Maxim.

On 11/20/18 3:40 PM, Cedric Hombourger wrote:
> Some of the packages I have been rebuilding within Isar require /sys mounted.
> For instance, golang-google-grpc runs some package tests after it builds itself
> and reads properties from /sys/class/dmi.
> 
> The initial version of this patch series only added a mount of /sys. Henning
> then suggested that we follow Gentoo's guidelines for chroots. As such, this
> patch series is now mounting /dev and /sys as rbind mounts but leaves /proc
> as a regular procfs mount (like Gentoo does).
> 
> ChangeLog:
> 
> v6: remove unnecessary mkdir for /sys
> v5: cover letter added as suggested by Jan (private e-mail)
> v4: limit rbind mounts to /dev and /sys, leave /proc as a regular mount
> v3: rbind mounts for /dev, /proc and /sys, add explicit umount calls
> v2: create /sys directory
> v1: initial submission, simply mount /sys
> 
> Cedric Hombourger (2):
>    buildchroot+bootstrap: rbind mount for /dev
>    buildchroot: add sysfs mount since expected by some packages
> 
>   meta/classes/buildchroot.bbclass                    | 5 ++++-
>   meta/classes/image.bbclass                          | 3 ++-
>   meta/classes/isar-bootstrap-helper.bbclass          | 6 +++++-
>   meta/classes/isar-image.bbclass                     | 3 ++-
>   meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 ++++++--
>   5 files changed, 19 insertions(+), 6 deletions(-)
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

  parent reply	other threads:[~2018-11-27 14:45 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 20:11 [PATCH] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-10  7:15 ` [PATCH v2] " Cedric Hombourger
2018-11-12  9:31   ` Henning Schild
2018-11-13  4:59     ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Cedric Hombourger
2018-11-13  4:59       ` [PATCH v3 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-13 10:43         ` chombourger
2018-11-13 10:59           ` Jan Kiszka
2018-11-13 12:07         ` Henning Schild
2018-11-13 12:37           ` Hombourger, Cedric
2018-11-13 12:59             ` Jan Kiszka
2018-11-14  7:44         ` Henning Schild
2018-11-16 16:29           ` chombourger
2018-11-16 16:31             ` [PATCH v4 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-16 16:31               ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Cedric Hombourger
2018-11-16 16:31               ` [PATCH v4 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-17 14:56                 ` [PATCH v5 0/2] rbind mounts for /dev and /sys Cedric Hombourger
2018-11-17 14:56                   ` [PATCH v5 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-19  9:25                     ` Henning Schild
2018-11-20 12:36                       ` chombourger
2018-11-17 14:56                   ` [PATCH v5 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-19  9:24                     ` Henning Schild
2018-11-20 12:40                       ` [PATCH v6 0/2] rbind mounts for /dev and /sys Cedric Hombourger
2018-11-20 12:40                         ` [PATCH v6 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-20 12:40                         ` [PATCH v6 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-22 16:08                           ` chombourger
2018-11-23 14:13                         ` [PATCH v6 0/2] rbind mounts for /dev and /sys Maxim Yu. Osipov
2018-11-27 14:45                         ` Maxim Yu. Osipov [this message]
2018-11-27 14:48                           ` Hombourger, Cedric
2018-11-29  8:22                             ` Maxim Yu. Osipov
2018-11-29  8:28                               ` Hombourger, Cedric
2018-11-29  8:48                                 ` Maxim Yu. Osipov
2018-11-29 10:00                                 ` Baurzhan Ismagulov
2018-11-29  9:54                             ` Henning Schild
2018-11-19  9:27                   ` [PATCH v5 " Henning Schild
2018-11-19  9:30                     ` Hombourger, Cedric
2018-11-13 12:06       ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Henning Schild
2018-11-12  9:46   ` [PATCH v2] buildchroot: add sysfs mount since expected by some packages Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59566b71-f70a-ba1a-fd63-d6ea6d24c84d@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox