From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7243694205603676160 X-Received: by 2002:a2e:9255:0:b0:2b6:9f4a:fce2 with SMTP id v21-20020a2e9255000000b002b69f4afce2mr3074696ljg.7.1687843271779; Mon, 26 Jun 2023 22:21:11 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:a108:0:b0:2b6:9e10:fd65 with SMTP id s8-20020a2ea108000000b002b69e10fd65ls488285ljl.2.-pod-prod-01-eu; Mon, 26 Jun 2023 22:21:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4GVpdr6KL7IggBcHfAI8DDHotFM9hPGTBfGdCrSftRTwAeQOhINg7IFOP8V056zh8/utFA X-Received: by 2002:a05:651c:115:b0:2b5:7fd2:ec36 with SMTP id a21-20020a05651c011500b002b57fd2ec36mr13152496ljb.21.1687843269930; Mon, 26 Jun 2023 22:21:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687843269; cv=none; d=google.com; s=arc-20160816; b=b3pes+6IR5jyB/b+2A9jiqN1KqDTrFms2f19CRjOMZ9fKT6Q0xgusJqGPZ3x1Lk4KQ q4/rgturFfNvIm1naxnx2AYwOt7/ZLScugOlEP157T0zSfbBZM5SrXe0AiG1ga2PTWlY qAcI3fK+pWakGUzLCawKVEDI3eSiapT3rET1QVyTdDoyqGYJ/o4nt1gsbFQVYnVlRcIp oz5rSgebWLc1R1nehC/s264VUvNQZmeeABtkzYnbIixbcdXXYlyIJsW/gE9OCPTspbke UdSPEKzFY/iHfFMmDojiF0NhfN+T0V9DhPagoWSO6/ImCVX3elJ6G5ZP0y0TvcO12woT KGXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id; bh=CPaCWSK8O1JNDEsBvHQsWHgdHgGa/oiIaVo63yGnsi0=; fh=CvtJwDmZxgCb3Mi2R3XR7hyHg4u5hw3sWGns8hFAqEk=; b=MxMfJbkNtrl1qiBBFM8Ph6jryE16encP0KGhw9CxO9v2JaTZgPNbGGl2rmzoCoqN8N MaVY5x15Z5htdQPHi+DE/zM5WWRy1w1MupusGCGPkS2AQlKJ+n2GZWztkLNpzXZDaXtK XKKViw35K2tsyyvF1QyFYd4DlH8Nm1cwNM5d/+tvBRnbvSwY9/N9ea2heeM7VPCoke/8 drT7m716ILbYIjNNxaY4bj4F3A6rZwFCOHBkFcRlBjnaeY3qCnqvhhqB2QEfzYDjWWer nPy9vXYAc2JgDlnx6vChIb7GhKY6fCFzgogPYXOaRqQyMxPaTJEH2ama8qEmkvBtmdY2 nOng== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id e30-20020a2e501e000000b002b699657ca8si561867ljb.3.2023.06.26.22.21.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jun 2023 22:21:09 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 35R5L78s004793 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jun 2023 07:21:08 +0200 Message-ID: <59898ad86db4a90e5494ddb1f9f736ec363e2d48.camel@ilbers.de> Subject: Re: [PATCH v4 00/12] Move testsuite hacks to separate layer From: Uladzimir Bely To: Henning Schild Cc: isar-users@googlegroups.com Date: Tue, 27 Jun 2023 08:21:07 +0300 In-Reply-To: <20230621154936.40a49db0@md1za8fc.ad001.siemens.net> References: <20230620060544.19745-1-ubely@ilbers.de> <20230621154936.40a49db0@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 9GK/k4xfq8Lh On Wed, 2023-06-21 at 15:49 +0200, Henning Schild wrote: > Am Tue, 20 Jun 2023 08:05:32 +0200 > schrieb Uladzimir Bely : >=20 > > There are a lot of hacks in Isar are used by testsuite only. Some > > of > > them even cause variable setting issues for users. To prevent this > > kind of issues introduce separate meta-test layer to be used by > > testsuite only. >=20 > I always disliked all the QEMU_ variables in the machine configs. > Because they are really only relevant for isar ci and whether they > should be written down in bitbake is questionable, now that we clean > up > i recommend moving that out as well. >=20 AEMU_ variables are not only used for CI, but also for manual running the compiled image (scripts/start_vm or testsuite/start_vm.py). At least, having them in machine configs means having an example of qemu run arguments, even if used won't use the scripts. I would say, we should have in machine configs everything we need to successfully compile and boot the image (similar to installing uboot- related packages for some hardware targets). > Henning >=20 > > This patchset also removes variables setting from multiconfigs to > > allow building without multiconfigs. > > The current patchset version is not fully tested and lack some > > documentation, but it should be a good starting point. > >=20 > > Changes since v3: > > - Cleanup machine configs from IMAGE_INSTALL and IMAGE_PREINSTALL > > entries that are not related to machine configuration. > > - Base qemuamd64-sb config on qemuamd64 one. > >=20 > > Changes since v2: > > - Fix warnings from bitbake during parsing multiconfigs by making > > files from `meta-isar/recipes-core/images` visible for isar-image- > > ci. > >=20 > > Changes since v1: > > - Rebased on latest `next`. > > - Added RECIPE-API-CHANGELOG.md entry. > >=20 > > The patchset is additionally tested with `meta-iot2050` downstream. > >=20 > > Anton Mikanovich (10): > > =C2=A0 CI: Introduce meta-test layer > > =C2=A0 ubuntu: Fix WKS_FILE overriding > > =C2=A0 CI: Move qemuamd64-bookworm hacks to CI layer > > =C2=A0 CI: Move qemuamd64-bullseye hacks to CI layer > > =C2=A0 CI: Move qemuamd64-buster hacks to CI layer > > =C2=A0 CI: Move qemuarm-bookworm hacks to CI layer > > =C2=A0 CI: Move qemuarm64-bookworm hacks to CI layer > > =C2=A0 meta-isar: Remove qemuamd64-sb settings from multiconfig > > =C2=A0 meta-isar: Remove imx6-sabrelite settings from multiconfig > > =C2=A0 meta-isar: Unify multiconfigs to use weak assignments > >=20 > > Uladzimir Bely (2): > > =C2=A0 meta-isar: Cleanup machine configs > > =C2=A0 meta-isar: Base qemuamd64-sb config on qemuamd64 > >=20 > > =C2=A0RECIPE-API-CHANGELOG.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 13 +++ > > =C2=A0meta-isar/conf/distro/ubuntu-common.inc=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 |=C2=A0 2 + > > =C2=A0meta-isar/conf/local.conf.sample=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 + > > =C2=A0meta-isar/conf/machine/imx6-sabrelite.conf=C2=A0=C2=A0=C2=A0 |=C2= =A0 4 + > > =C2=A0meta-isar/conf/machine/phyboard-mira.conf=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0 1 - > > =C2=A0meta-isar/conf/machine/qemuamd64-sb.conf=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | 23 ++--- > > =C2=A0meta-isar/conf/machine/qemuamd64.conf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 15 --- > > =C2=A0meta-isar/conf/machine/rpi-common.conf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 17 +--- > > =C2=A0.../conf/machine/starfive-visionfive2.conf=C2=A0=C2=A0=C2=A0 |=C2= =A0 3 - > > =C2=A0meta-isar/conf/machine/virtualbox.conf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 1 - > > =C2=A0meta-isar/conf/machine/vmware.conf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 - > > =C2=A0.../conf/multiconfig/bananapi-bullseye.conf=C2=A0=C2=A0 |=C2=A0 4= +- > > =C2=A0.../conf/multiconfig/bananapi-buster.conf=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0 4 +- > > =C2=A0.../multiconfig/de0-nano-soc-bullseye.conf=C2=A0=C2=A0=C2=A0 |=C2= =A0 4 +- > > =C2=A0.../conf/multiconfig/de0-nano-soc-buster.conf |=C2=A0 4 +- > > =C2=A0.../conf/multiconfig/hikey-bookworm.conf=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 4 +- > > =C2=A0.../conf/multiconfig/hikey-bullseye.conf=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 4 +- > > =C2=A0.../multiconfig/imx6-sabrelite-bullseye.conf=C2=A0 |=C2=A0 6 -- > > =C2=A0.../multiconfig/imx6-sabrelite-buster.conf=C2=A0=C2=A0=C2=A0 |=C2= =A0 6 -- > > =C2=A0.../conf/multiconfig/nanopi-neo-bullseye.conf |=C2=A0 4 +- > > =C2=A0.../conf/multiconfig/nanopi-neo-buster.conf=C2=A0=C2=A0 |=C2=A0 4= +- > > =C2=A0.../conf/multiconfig/qemuamd64-bookworm.conf=C2=A0 |=C2=A0 1 - > > =C2=A0.../conf/multiconfig/qemuamd64-bullseye.conf=C2=A0 |=C2=A0 2 - > > =C2=A0.../conf/multiconfig/qemuamd64-buster.conf=C2=A0=C2=A0=C2=A0 |=C2= =A0 4 - > > =C2=A0.../conf/multiconfig/qemuamd64-focal.conf=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0 2 - > > =C2=A0.../conf/multiconfig/qemuamd64-jammy.conf=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0 2 - > > =C2=A0.../multiconfig/qemuamd64-sb-bullseye.conf=C2=A0=C2=A0=C2=A0 | 11= +-- > > =C2=A0.../conf/multiconfig/qemuarm-bookworm.conf=C2=A0=C2=A0=C2=A0 |=C2= =A0 6 -- > > =C2=A0.../conf/multiconfig/qemuarm64-bookworm.conf=C2=A0 |=C2=A0 3 - > > =C2=A0.../multiconfig/sifive-fu540-sid-ports.conf=C2=A0=C2=A0 |=C2=A0 4= +- > > =C2=A0.../starfive-visionfive2-sid-ports.conf=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 |=C2=A0 4 +- > > =C2=A0.../conf/multiconfig/stm32mp15x-bullseye.conf |=C2=A0 4 +- > > =C2=A0.../conf/multiconfig/stm32mp15x-buster.conf=C2=A0=C2=A0 |=C2=A0 4= +- > > =C2=A0.../conf/multiconfig/virtualbox-bullseye.conf |=C2=A0 5 +- > > =C2=A0meta-isar/recipes-ci/images/isar-image-ci.bb=C2=A0 |=C2=A0 9 -- > > =C2=A0meta-test/conf/bblayers.conf.sample=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 18 ++++ > > =C2=A0meta-test/conf/conf-notes.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 3 + > > =C2=A0meta-test/conf/layer.conf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | 20 ++++ > > =C2=A0meta-test/conf/local.conf.sample=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 95 > > +++++++++++++++++++ meta-test/recipes-ci/images/isar-image-ci.bb=C2=A0 = | > > 51 ++++++++++ .../isar-ci-ssh-setup/files/postinst=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 0 > > =C2=A0.../isar-ci-ssh-setup_0.1.bb=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 = 0 > > =C2=A0testsuite/cibuilder.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 + > > =C2=A0testsuite/citest.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 32 ++++--- > > =C2=A044 files changed, 274 insertions(+), 136 deletions(-) > > =C2=A0delete mode 100644 meta-isar/recipes-ci/images/isar-image-ci.bb > > =C2=A0create mode 100644 meta-test/conf/bblayers.conf.sample > > =C2=A0create mode 100644 meta-test/conf/conf-notes.txt > > =C2=A0create mode 100644 meta-test/conf/layer.conf > > =C2=A0create mode 100644 meta-test/conf/local.conf.sample > > =C2=A0create mode 100644 meta-test/recipes-ci/images/isar-image-ci.bb > > =C2=A0rename {meta-isar =3D> > > meta-test}/recipes-ci/isar-ci-ssh-setup/files/postinst (100%) > > rename > > {meta-isar =3D> > > meta-test}/recipes-ci/isar-ci-ssh-setup/isar-ci-ssh-setup_0.1.bb > > (100%) > >=20 >=20