Re: [PATCH v3 2/2] isar-image: refactor do_rootfs()

[Jan Kiszka <jan.kiszka@siemens.com>]

On 07.11.18 21:16, Cedric Hombourger wrote:
> Hi again,
> 
> My test build on a machine _without_ a direct Internet connection has completed.
> Any idea how I can reproduce your issue? or help troubleshoot?
> 
> Note: tested with HEAD = 60db83cdcae60bdca6d3e3ed2cc7c44712d4dd91
> 

Works for me as well, and the code changes do not touch anything proxy-related.

I'm more concerned about the structure of this change, as commented in the other 
mail. Cedric, could you follow up on that?

Thanks,
Jan

> Cedric
> 
> On Wed, 7 Nov 2018 at 20:46, Cedric Hombourger <chombourger@gmail.com 
> <mailto:chombourger@gmail.com>> wrote:
> 
>     Hi Henning,
> 
>     I apologize if that's the case. On my side, the proxy appears to be used
>     just fine. I have added a trace in isar_image_gen_rootfs() and I can see:
> 
>     DEBUG: Executing python function do_rootfs
>     DEBUG: Executing shell function root_cleandirs
>     DEBUG: Shell function root_cleandirs finished
>     DEBUG: Executing shell function isar_image_gen_fstab
>     DEBUG: Shell function isar_image_gen_fstab finished
>     DEBUG: Executing shell function isar_image_gen_rootfs
>     ######## http_proxy=http://127.0.0.1:3142 ##########
> 
>     I also checked my apt-cacher-ng and I saw a bunch of requests coming in
>     while do_rootfs was executing.
>     Will double-check on a machine that does not have direct access to the
>     Internet to make sure.
> 
>     Cedric
> 
>     On Wed, 7 Nov 2018 at 19:45, Henning Schild <henning.schild@siemens.com
>     <mailto:henning.schild@siemens.com>> wrote:
> 
>         Am Thu, 1 Nov 2018 11:13:02 +0100
>         schrieb Cedric Hombourger <Cedric_Hombourger@mentor.com
>         <mailto:Cedric_Hombourger@mentor.com>>:
> 
>          > Split the do_rootfs() shell function into four (smaller) shell
>          > functions to generate the fstab file (isar_image_gen_fstab), populate
>          > the root file-system (isar_image_gen_rootfs), configure it
>          > (isar_image_conf_rootfs) and perform some house-keeping
>          > (isar_image_cleanup). do_rootfs is now a python function and
>          > sequentially calls the helper functions listed above.
>          >
>          > Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com
>         <mailto:Cedric_Hombourger@mentor.com>>
>          > ---
>          >  meta/classes/isar-image.bbclass | 15 ++++++++++++++-
>          >  1 file changed, 14 insertions(+), 1 deletion(-)
>          >
>          > diff --git a/meta/classes/isar-image.bbclass
>          > b/meta/classes/isar-image.bbclass index ec2b9e3..e0508be 100644
>          > --- a/meta/classes/isar-image.bbclass
>          > +++ b/meta/classes/isar-image.bbclass
>          > @@ -21,7 +21,7 @@ ISAR_RELEASE_CMD ?= "${ISAR_RELEASE_CMD_DEFAULT}"
>          >  do_rootfs[root_cleandirs] = "${IMAGE_ROOTFS} \
>          >                               ${IMAGE_ROOTFS}/isar-apt"
>          >
>          > -do_rootfs() {
>          > +isar_image_gen_fstab() {
>          >      cat > ${WORKDIR}/fstab << EOF
>          >  # Begin /etc/fstab
>          >  /dev/root    /               auto
>          > defaults              0       0 @@ -33,11 +33,15 @@
>          > devtmpfs      /dev            devtmpfs
>          > mode=0755,nosuid      0       0 # End /etc/fstab
>          >  EOF
>          > +}
>          >
>          > +isar_image_gen_rootfs() {
>          >      setup_root_file_system --clean --keep-apt-cache \
>          >          --fstab "${WORKDIR}/fstab" \
>          >          "${IMAGE_ROOTFS}" ${IMAGE_PREINSTALL} ${IMAGE_INSTALL}
>          > +}
>          >
>          > +isar_image_conf_rootfs() {
>          >      # Configure root filesystem
>          >      if [ -n "${DISTRO_CONFIG_SCRIPT}" ]; then
>          >          sudo install -m 755 "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}"
>          > "${IMAGE_ROOTFS}" @@ -45,7 +49,9 @@ EOF
>          >                                                             
>           "${BAUDRATE_TTY}"
>          >          sudo rm "${IMAGE_ROOTFS}/${DISTRO_CONFIG_SCRIPT}"
>          >     fi
>          > +}
>          >
>          > +isar_image_cleanup() {
>          >      # Cleanup
>          >      sudo rm "${IMAGE_ROOTFS}/etc/apt/sources.list.d/isar-apt.list"
>          >      test ! -e "${IMAGE_ROOTFS}/usr/share/doc/qemu-user-static" && \
>          > @@ -57,3 +63,10 @@ EOF
>          >      sudo umount -l ${IMAGE_ROOTFS}/proc
>          >      sudo rm -f
>          > "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" }
>          > +
>          > +python do_rootfs() {
>          > +    bb.build.exec_func("isar_image_gen_fstab", d)
>          > +    bb.build.exec_func("isar_image_gen_rootfs", d)
>          > +    bb.build.exec_func("isar_image_conf_rootfs", d)
>          > +    bb.build.exec_func("isar_image_cleanup", d)
>          > +}
> 
>         I am loosing my proxies somewhere in current next ... i suspect this
>         guy but did not confirm yet.
> 
>         Henning
> 
>         -- 
>         You received this message because you are subscribed to a topic in the
>         Google Groups "isar-users" group.
>         To unsubscribe from this topic, visit
>         https://groups.google.com/d/topic/isar-users/Pzt7vsbc8VE/unsubscribe.
>         To unsubscribe from this group and all its topics, send an email to
>         isar-users+unsubscribe@googlegroups.com
>         <mailto:isar-users%2Bunsubscribe@googlegroups.com>.
>         To post to this group, send email to isar-users@googlegroups.com
>         <mailto:isar-users@googlegroups.com>.
>         To view this discussion on the web visit
>         https://groups.google.com/d/msgid/isar-users/20181107194531.17356c59%40md1za8fc.ad001.siemens.net.
>         For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email 
> to isar-users+unsubscribe@googlegroups.com 
> <mailto:isar-users+unsubscribe@googlegroups.com>.
> To post to this group, send email to isar-users@googlegroups.com 
> <mailto:isar-users@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/isar-users/CAKbb94fWOV4NN2WMuXCvRF%2B5%2BV73w8N0ZcS43vZbPmS_kckQ_A%40mail.gmail.com 
> <https://groups.google.com/d/msgid/isar-users/CAKbb94fWOV4NN2WMuXCvRF%2B5%2BV73w8N0ZcS43vZbPmS_kckQ_A%40mail.gmail.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux