From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6617812835611181056 X-Received: by 2002:a19:d8c6:: with SMTP id r67mr311265lfi.3.1541659937051; Wed, 07 Nov 2018 22:52:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9813:: with SMTP id a19-v6ls102336ljj.7.gmail; Wed, 07 Nov 2018 22:52:16 -0800 (PST) X-Google-Smtp-Source: AJdET5fTBpUnalFVTAprUoDe6TOc9PGhngX+W4PjsE/sNj4mjcVYOjME9kOtQ2KO3Lip+aSJqKpt X-Received: by 2002:a2e:42ce:: with SMTP id h75-v6mr343647ljf.27.1541659936415; Wed, 07 Nov 2018 22:52:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541659936; cv=none; d=google.com; s=arc-20160816; b=X6NvNTDa/0+2x5zVgK44mtDJbCcD6PD6WorBdYUpJzvtd38OlFJZj0k2vJzgG8SzKh 3TbULPSaX+XVFDTaXWXfclUT0PXSe4C4j+0JhjUHyO+uq8PIZZigFfoCdRxNWENuCoDR TrLGQGKY9E0rojG94OJkc7Y7PTPKcv5MHbrGMVtnh40CKv3JrN3sc0MMFPNpAzipYUEi 5R5JPyp0mzCPWF/EMqT24JdxLECmINg6a1qYera5NWjzPACy0FCCsZcPZJLucWs5FRLw /sYxG/o/ooHGS9vLcONPEWQnLj8f0ed4qKskyC+JBkLItWxh1GJBQvSqo8n7d9sR33PE a4xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=SxV8r3cxkaRVgZs5TYh0zXIV6o6PZcJjYkEi0MfRBj8=; b=tUXN0rgm5QBcHOIU/Fe7LnjOMrh4Qzd4jqroTcv46HGBJSpr1wJLTSEYucetdj159O OSu5ns4Z4HPxLcGfy7J+n+JGMS8Ynn0CWrx113ZxAnu5e3/ahBLP+JV457xIc5ct6Maw xtxyVj1L1wWVP6MVygigK/9kE4UogQlGynbq6NIE/1p6nMii0O3rmYWwqCsR/Ei6+c6Z TFEdrATh+CxRLlU7yf/dNDc+3DjGR2WThduh5A+RoUeok6uqjwf5aqK0uo9JTO2jbwUw cIALMiUAjeiuO/wttIqm9jCa0KK736iEwRqBfEtF8+ewjn/+Xlz13uHQyGRqmVMK7h09 +8mg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id l5-v6si116983ljh.4.2018.11.07.22.52.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 22:52:16 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id wA86qFXe030205 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Nov 2018 07:52:15 +0100 Received: from [139.22.39.185] ([139.22.39.185]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wA86qE0J001297; Thu, 8 Nov 2018 07:52:14 +0100 Subject: Re: [PATCH v3 2/2] isar-image: refactor do_rootfs() To: Cedric Hombourger , Henning Schild Cc: Cedric Hombourger , isar-users@googlegroups.com References: <57847f7a-9b85-65ef-b11e-8952bf532e0f@siemens.com> <20181101101302.8674-1-Cedric_Hombourger@mentor.com> <20181101101302.8674-2-Cedric_Hombourger@mentor.com> <20181107194531.17356c59@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <5a0ef64c-4853-2aa5-e0c6-8ca2406c20c8@siemens.com> Date: Thu, 8 Nov 2018 07:52:13 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: hjuH1TQ1hBqP On 07.11.18 21:16, Cedric Hombourger wrote: > Hi again, > > My test build on a machine _without_ a direct Internet connection has completed. > Any idea how I can reproduce your issue? or help troubleshoot? > > Note: tested with HEAD = 60db83cdcae60bdca6d3e3ed2cc7c44712d4dd91 > Works for me as well, and the code changes do not touch anything proxy-related. I'm more concerned about the structure of this change, as commented in the other mail. Cedric, could you follow up on that? Thanks, Jan > Cedric > > On Wed, 7 Nov 2018 at 20:46, Cedric Hombourger > wrote: > > Hi Henning, > > I apologize if that's the case. On my side, the proxy appears to be used > just fine. I have added a trace in isar_image_gen_rootfs() and I can see: > > DEBUG: Executing python function do_rootfs > DEBUG: Executing shell function root_cleandirs > DEBUG: Shell function root_cleandirs finished > DEBUG: Executing shell function isar_image_gen_fstab > DEBUG: Shell function isar_image_gen_fstab finished > DEBUG: Executing shell function isar_image_gen_rootfs > ######## http_proxy=http://127.0.0.1:3142 ########## > > I also checked my apt-cacher-ng and I saw a bunch of requests coming in > while do_rootfs was executing. > Will double-check on a machine that does not have direct access to the > Internet to make sure. > > Cedric > > On Wed, 7 Nov 2018 at 19:45, Henning Schild > wrote: > > Am Thu, 1 Nov 2018 11:13:02 +0100 > schrieb Cedric Hombourger >: > > > Split the do_rootfs() shell function into four (smaller) shell > > functions to generate the fstab file (isar_image_gen_fstab), populate > > the root file-system (isar_image_gen_rootfs), configure it > > (isar_image_conf_rootfs) and perform some house-keeping > > (isar_image_cleanup). do_rootfs is now a python function and > > sequentially calls the helper functions listed above. > > > > Signed-off-by: Cedric Hombourger > > > --- > >  meta/classes/isar-image.bbclass | 15 ++++++++++++++- > >  1 file changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/meta/classes/isar-image.bbclass > > b/meta/classes/isar-image.bbclass index ec2b9e3..e0508be 100644 > > --- a/meta/classes/isar-image.bbclass > > +++ b/meta/classes/isar-image.bbclass > > @@ -21,7 +21,7 @@ ISAR_RELEASE_CMD ?= "${ISAR_RELEASE_CMD_DEFAULT}" > >  do_rootfs[root_cleandirs] = "${IMAGE_ROOTFS} \ > >                               ${IMAGE_ROOTFS}/isar-apt" > > > > -do_rootfs() { > > +isar_image_gen_fstab() { > >      cat > ${WORKDIR}/fstab << EOF > >  # Begin /etc/fstab > >  /dev/root    /               auto > > defaults              0       0 @@ -33,11 +33,15 @@ > > devtmpfs      /dev            devtmpfs > > mode=0755,nosuid      0       0 # End /etc/fstab > >  EOF > > +} > > > > +isar_image_gen_rootfs() { > >      setup_root_file_system --clean --keep-apt-cache \ > >          --fstab "${WORKDIR}/fstab" \ > >          "${IMAGE_ROOTFS}" ${IMAGE_PREINSTALL} ${IMAGE_INSTALL} > > +} > > > > +isar_image_conf_rootfs() { > >      # Configure root filesystem > >      if [ -n "${DISTRO_CONFIG_SCRIPT}" ]; then > >          sudo install -m 755 "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}" > > "${IMAGE_ROOTFS}" @@ -45,7 +49,9 @@ EOF > > >  "${BAUDRATE_TTY}" > >          sudo rm "${IMAGE_ROOTFS}/${DISTRO_CONFIG_SCRIPT}" > >     fi > > +} > > > > +isar_image_cleanup() { > >      # Cleanup > >      sudo rm "${IMAGE_ROOTFS}/etc/apt/sources.list.d/isar-apt.list" > >      test ! -e "${IMAGE_ROOTFS}/usr/share/doc/qemu-user-static" && \ > > @@ -57,3 +63,10 @@ EOF > >      sudo umount -l ${IMAGE_ROOTFS}/proc > >      sudo rm -f > > "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" } > > + > > +python do_rootfs() { > > +    bb.build.exec_func("isar_image_gen_fstab", d) > > +    bb.build.exec_func("isar_image_gen_rootfs", d) > > +    bb.build.exec_func("isar_image_conf_rootfs", d) > > +    bb.build.exec_func("isar_image_cleanup", d) > > +} > > I am loosing my proxies somewhere in current next ... i suspect this > guy but did not confirm yet. > > Henning > > -- > You received this message because you are subscribed to a topic in the > Google Groups "isar-users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/isar-users/Pzt7vsbc8VE/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > isar-users+unsubscribe@googlegroups.com > . > To post to this group, send email to isar-users@googlegroups.com > . > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/20181107194531.17356c59%40md1za8fc.ad001.siemens.net. > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to isar-users+unsubscribe@googlegroups.com > . > To post to this group, send email to isar-users@googlegroups.com > . > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/CAKbb94fWOV4NN2WMuXCvRF%2B5%2BV73w8N0ZcS43vZbPmS_kckQ_A%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux