From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6646963333394071552 X-Received: by 2002:a17:906:404f:: with SMTP id y15-v6mr1114134ejj.5.1547641025173; Wed, 16 Jan 2019 04:17:05 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:b656:: with SMTP id c22ls1445634ede.0.gmail; Wed, 16 Jan 2019 04:17:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN5kllsqfn+fqXtffIzBLsFOUOQPIoFmarv3mzpkatQOelCCYOPWtp/Ya0TxN6EOzJpOw8bS X-Received: by 2002:a50:a5f1:: with SMTP id b46mr1248378edc.12.1547641024649; Wed, 16 Jan 2019 04:17:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547641024; cv=none; d=google.com; s=arc-20160816; b=mYcteHUVullrr4PJOE8NbVBXQ5pEfSfSZN6wWAQ14pMd0MPFPTCIaEqIQhvTOgBMaw biYjFeITXTK3NTbv9f3J8EECpE47O7bTbNtPxiGir49ixsdPniIVClUbJGGknWcelGJf qdvsJ4WxF78ST0nsw05iyJGcOAbdsEFi927BFCcoVr2TfK90AwwyX/ioGH6EpTdna5Vp mydy4eA9gXD9vhsQ0r9AhW0aHRkG6YZYXuE+b4q9QMA4CJTieC67zZyuTdUfCOdL8UFE fM6oYZOfM4djXvL+TgFFyull+cWnXqqyENrzsNMgwyCOl3IFRhBfoluyeOeW7fkEOVbz seBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=8Lhj1kWn8yv3Qmp7Gt8OUHJhywYkT4Ba042aY61LuKM=; b=zcani8tbOQ2Qx2owZ2XHFEdmheIWZf0p4DKBgCatsOeODRV8MN2Nqa+Xhu7QUc3Wux HEu9lXq8Aw1HPJrImH2E8HYxUB2feNyOK+xM53fsHiEqfUs3HLqiNvQqzoYF9IGXwbcv sfK4FRqu4RzgTWUTHAYubIMMMWJTIYzqFcjQ/NR0yUOLzhvEeFAO76eRt8iL3A+rTXbD 77v5fAxu1+s+py76DwRV1KvLq7ni7WotwGJSmWx0mjm4dH3lEYfuD76XGtZl8+a3mst/ 2z2cUAFizvAPjLDd22e/8Cl6XCjRqCVKIo3ePo4To8Eco2DDTwn3Gp9NfYx3NXnMx4LO rXOw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id m24si653358edc.3.2019.01.16.04.17.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 04:17:04 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x0GCH4II005739 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jan 2019 13:17:04 +0100 Received: from [139.23.230.199] ([139.23.230.199]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0GCH3tu004891; Wed, 16 Jan 2019 13:17:03 +0100 Subject: Re: [PATCH v3 08/14] bootimg-efi-isar: Fix serial console setup for grub To: Henning Schild Cc: isar-users References: <20190116104705.201f38c9@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <5a5bc4eb-b738-e1b2-0d9e-42c7d2311a6c@siemens.com> Date: Wed, 16 Jan 2019 13:17:03 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190116104705.201f38c9@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: I/gJy1D2BjLH On 16.01.19 10:47, Henning Schild wrote: > Am Wed, 16 Jan 2019 06:32:21 +0100 > schrieb "[ext] Jan Kiszka" : > >> From: Jan Kiszka >> >> We were lacking terminal_input/output to make the serial console truly >> work. >> >> Signed-off-by: Jan Kiszka >> --- >> meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py >> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index >> 1ca200f..c6a6a02 100644 --- >> a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ >> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -65,8 >> +65,10 @@ class BootimgEFIPlugin(SourcePlugin): # Create grub >> configuration using parameters from wks file bootloader = >> creator.ks.bootloader >> - grubefi_conf = "" >> - grubefi_conf += "serial --unit=0 --speed=115200 --word=8 >> --parity=no --stop=1\n" >> + grubefi_conf = "serial --unit=0 --speed=115200 --word=8 >> --parity=no --stop=1\n" >> + grubefi_conf += "terminal_input --append serial\n" >> + grubefi_conf += "terminal_output --append serial\n" >> + grubefi_conf += "\n" > > Good catch and very useful improvement! Would it help to involve > grub-mkconfig into the flow and create the config from something > like /etc/default/grub? We could work towards evaluating (and configuring via) default/grub, but that would be an add-on topic for later. We already do that for u-boot (via u-boot-script), in fact. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux