From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 21 Nov 2025 18:08:00 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-lf1-f63.google.com (mail-lf1-f63.google.com [209.85.167.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5ALH7x6O015939 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Nov 2025 18:07:59 +0100 Received: by mail-lf1-f63.google.com with SMTP id 2adb3069b0e04-5943ca95853sf2340639e87.2 for ; Fri, 21 Nov 2025 09:07:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1763744874; cv=pass; d=google.com; s=arc-20240605; b=Hl9n6ZZ9O5IDeFhs17Hy+txUzmNw6rZD2+BuPVRaQJmVoYD4R9RrFjVO0ODce9PWsl iRaS8A6kIP+PCorhXGb/AXbh+byMxP6H+r76ncdnqFGTxyj6ZWCxuoY4QOUb8fcTiv4h gvrmGXhlev6Q+PpSi6R+0LxWP1vIkWwBbPlWFX8WLoqxXAN6AjvmPazlA3eEHbrUnCRd 4YRMiyhMVava8buStun6coaED1NY3kSVQfAYuNTyLtLbPIbi6Aqucy4ACcIaqdG2+lIj jYI6NXM/4U40vqPNaaszwS6stXjplqa8FbDJniRJPcKNNxuptB8kerpPOH0e+O82EF4l Td3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:content-transfer-encoding :in-reply-to:content-language:references:to:from:subject:user-agent :mime-version:date:message-id:sender:dkim-signature; bh=OIo8hdDFZdkrlTcgtd3Ckg26wnliTYCGjwybWcpxNcA=; fh=3GMhnwXig/mXMk6ve/ss7gJE384+avnJCMkMuJ1ZqR0=; b=gx/nNDEkgqoJs6riYUc0NJjH7MP2Y67/IDYysQh+BbZ4Q2Cox1WrEbMy8Sn31/R8N1 Sr0B88nQoDsudApDDIruRrH0mSKYTvlfBZR0Mkk7qhPuBXj/scIbax/z0Gqdlizb4Y3z kB7KBg3e8J/PmQ05YgjAHXGQCX3UOBupkaARB5nz5LMyCFAcHlhbfUN7wrUGJMqY1/uo 6RpQ7HvPWa/FCbyEkoyMwQNgeez/67ZXobWLWvOzrnXYtCHAJp19xynB0+74pOfs1He/ mU7pXdmoViVfelwbhZKBqMGyxZWj8qjsykWvU9g2esyfFeGBf1FXam8pV4N28Sc7rJv7 Wlqg==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1763744874; x=1764349674; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:in-reply-to :content-language:references:to:from:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=OIo8hdDFZdkrlTcgtd3Ckg26wnliTYCGjwybWcpxNcA=; b=GH6YCrlvPfkrrDS31LfuRAp8G2owdlcFDqNWl11dVqrwXFCrX/LVPVrl3U6iBwDSbS SEYa4Q3B2yPxUtL9lEmTeRLYfL2KReWpdTEEh+8UM6FeRub7kgO4ndO1jrSwMzPWBBJI vZ7u124roBedon+ZNP0DjhsKBdw2YnaSWkXm5npsGcARAupZm7l0XX/LxUKaVv/ox93o z+pKlVzicR8xXg0fR2zcLRhgDlUnYLNk3UOQzNcTKLDCMbKyfN3IojGY6XFE7tXMjJk0 CmENl6ZA1MksNep0EaL0+ZaOMDqX10bfp31qadcImnyHusmekZyqAFAh5Z5M8okPLlrk UaxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763744874; x=1764349674; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=OIo8hdDFZdkrlTcgtd3Ckg26wnliTYCGjwybWcpxNcA=; b=ng+2f0u9uKNcjqNisJdFxI4lBkoA06ayila1SDfo0L38BqUiKH4EK0hMp8zwYecCx5 1WxYyXVxkyA6BvHrEA32PNXaxQR7m6B/3oe6KLb09t5nFaHBPjvawx0qUnbCH93s0b+C YHyL94Bu9XTK7MsrYAM1C6T5KOvaShAhxr7hZTTpmWqQpSwqJMvx1DSq8jmyvGlMJhrH YDjaSH9Q8XJ57RbHBiXB6EXKwZcERAz5Bck3LI6V8JQd+gMsMX2AiG1hT7i992U/5Pd6 fi76IAvbqfUk3sMA+vDQjfeV86ip8tIYx/yKvREhlBP4al3oFNYSs8vmV5B8tPeVCUtp LeGQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCUVAL3acDf+ORkTpcCHfsVc5ImwbNBAco4UrpjIwePvuFpzoRsHD02C7UhtLXT7VpVIUC6u@ilbers.de X-Gm-Message-State: AOJu0YyS2NkAW1ZtbTb90BtMiaLNfsdZZo33R0rUJNftxyJeiJAkKVRx WUIJUx7x3DmF+Hbi46KRHP+ul+fjKP5mOfFIbqKatAJnLYiNfYGFYpJt X-Google-Smtp-Source: AGHT+IGeaPg2L4RUXY2AroSCN9Xq8GrzvHG9aTaAoq5yJF9qXHoafkvwkOVCP+mgpSZDpne0DUInxA== X-Received: by 2002:a05:6512:b9d:b0:594:493a:a27f with SMTP id 2adb3069b0e04-596a3eddab2mr1234989e87.36.1763744873443; Fri, 21 Nov 2025 09:07:53 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+avyYJecezUcdfChf4x9/cr22MLcDz6xF1Qg3ND4zrGAA==" Received: by 2002:ac2:5687:0:b0:596:a35d:3c0a with SMTP id 2adb3069b0e04-596a35d3cdbls431612e87.0.-pod-prod-05-eu; Fri, 21 Nov 2025 09:07:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCULFM4DmYnUr2ygx4LedcqjAeJDS9+PFP/6yiDEi99YA6ikj+/V8xbRNVdge8PcWyDCzOl23ri3KLbH@googlegroups.com X-Received: by 2002:a05:6512:104f:b0:593:f74:9088 with SMTP id 2adb3069b0e04-596a3ee5881mr969708e87.43.1763744870354; Fri, 21 Nov 2025 09:07:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1763744870; cv=none; d=google.com; s=arc-20240605; b=U5AqiU6Nd5HA+T2bZIdSspjhLrntiFxC61l9TM+5+tsK+osxWjBXQk/ZKqYA5A8FRz T8lRVaggP1s1EPDZXgLhESEEtCqD3QHWAYI36tqV2ihwnmVt4xIJ5yCvgpvARZh4gMNC LSbrRf+8ymlSliXn55e3hCRcycVjRaw14thfyBxki1HXRfD55L0cXDccEmym04ItPC4O xUp0Whdq+8D7LVay3ttX8ougTC4wW1a5fGBOU3iLrBvrLrxxOUhiKzHQHrSi3ZsFQTkv /6L5AIlHO/AKd5HGzjBGeseGUZJ7Ohq1iDUVresQciXXJ3++mwUmOxo3ZzXOtJT/3JUe Hesw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id; bh=yA3Ny5pybriar2IPOgJ8GgDciZpcdjqojlZ01GYPcXc=; fh=jqvT4ZcaBqcViD9oxV+ItAwVch2WzoVE9Puk1cStOl0=; b=D8H1wmfPiA7iV5k7OezLWvGOo1m/WvG172qi2JRCXNL3NCDXqUJeOLs5bsWot3/Rpf myG7YiEU8oWj70N2utPPhqoXOGY9QkjPyWUwcfo8Wyv0Hla4CV9cpqJGfYnOPq8kup/n 3f1FAjfT2lOIWfhTVM9dRp2XW2VQ3BBUGIFk/DcZxwX9P9BtLi628q1rKONDLdU+T0CO /ProP/ARQZ82lPBGvfdaNn4p5pGX48FlTWkCyDTWs3cs/KVqTZtwQVuJ1OrLBRDKtqe+ kKjaFDdVc/ZeNoTX6R0b2UxFZYABOp5nRsKuNRnhrVtnNORQKtP5/UobEWJY9A1644ZD mRSw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 2adb3069b0e04-5969dba0852si108637e87.4.2025.11.21.09.07.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Nov 2025 09:07:50 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 5ALH7mum015928 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Nov 2025 18:07:49 +0100 Message-ID: <5ae801ae-55e0-48ab-9db4-a55d7c03954b@ilbers.de> Date: Fri, 21 Nov 2025 18:07:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/1] image: introduce IMAGE_INITRD, deprecate INITRD_IMAGE From: Zhihang Wei To: Cedric Hombourger , isar-users@googlegroups.com, wzh@ilbers.de References: <20251102190129.727186-1-cedric.hombourger@siemens.com> <9cb68e63-3820-4678-a607-b35a574a8e74@ilbers.de> Content-Language: en-US In-Reply-To: <9cb68e63-3820-4678-a607-b35a574a8e74@ilbers.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: faupJQLTAfY/ Hi Cedric, After some checking I think we need to rework this patch. The INITRD_IMAGE variable was origionally used, when we already have a=20 customized initrd image binary. In this case, the default initrd image=20 should not be generated. And the logic was implemented as (until commit ea6f44c9): In image bb.class: - If 'INITRD_IMAGE' is not empty, set 'no-generate-initrd'. - Since image.bbclass inherits rootfs.bbclass: =C2=A0 - rootfs.bbclass checks 'no-generate-initrd'. =C2=A0 - If it is NOT set, add the task to generate the default initrd. However, this did not actually work. the default initrd image was always=20 generated. The issue came from initramfs.bbclass: - initramfs.bbclass has no logic to set 'no-generate-initrd'. - It also inherits rootfs.bbclass, which means: =C2=A0 - rootfs.bbclass sees 'no-generate-initrd' as unset, so it always= =20 generates default initrd image. The patch "[v3 1/1] rootfs: rework no-generate-initrd rootfs feature"=20 fixes this behavior, and it was merged to next as 78d42de0. However, I=20 tested your patch before rebasing onto the latest next. It passed CI and=20 your additional test cases, and I applied it as c3c4e72c. At that moment=20 it caused a merge conflict, and I did not resolve the conflict correctly. After both the patches were merged to next, two of the test cases you=20 added failed: - InitRdTest.test_var_initrd_image, and - InitRdTest.test_var_image_initrd_and_initrd_image. Both tests set INITRD_IMAGE variable to a meaningful value. But the=20 logic for determining whether to generate a default initrd has been=20 reworked and moved entirely into rootfs.bbclass. Under the new logic: - rootfs.bbclass does not add 'generate-initrd' when INITRD_IMAGE is set. - rootfs.bbclass adds initrd generation tasks only when=20 'generate-initrd' is set. - Since both initramfs.bbclass and image.bbclass inherit rootfs.bbclass,=20 neither will generate a default initrd image in this case. Back to your patch, I'm wondering whether it makes sense to keep both=20 INITRD_IMAGE and your new variable. If my understanding is correct, they=20 serve different purposes: - INITRD_IMAGE is used when a custom initrd image binary is provided. - Your variable is used when a custom recipe should be used to build the=20 initrd image. Because I did not resolve the merge conflict correctly when applying=20 your patch, I suggest reverting c3c4e72c for now and reworking your=20 patch on top of 78d42de0. Thanks, Zhihang On 11/12/25 17:41, Zhihang Wei wrote: > Applied to next, thanks. > > The patch was rebased onto the current next. > > Best regards, > Zhihang > > On 11/2/25 20:01, 'Cedric Hombourger' via isar-users wrote: >> INITRD_IMAGE could be set to the full name of an initrd image to be >> found in DEPLOY_DIR_IMAGE. Downstream layers had to assume how Isar >> names its image artifacts (${DISTRO}-${IMAGE}-initrd.img suffix for >> initrd images) and insert the build of their initramfs recipe into >> the image build pipeline. >> >> IMAGE_INITRD is introduced to (1) have a constistent naming convention >> for variables consumed by the image class (IMAGE_ prefix) (2) only >> require this variable to be set when a custom initrd should be built >> and used by the imager. >> >> For instance, cip-core was doing the following: >> >> =C2=A0=C2=A0=C2=A0 INITRAMFS_RECIPE ?=3D "cip-core-initramfs" >> =C2=A0=C2=A0=C2=A0 INITRD_IMAGE =3D "${INITRAMFS_RECIPE}-${DISTRO}-${MAC= HINE}.initrd.img" >> =C2=A0=C2=A0=C2=A0 do_image_wic[depends] +=3D "${INITRAMFS_RECIPE}:do_bu= ild" >> >> And it could now be changed to: >> >> =C2=A0=C2=A0=C2=A0 IMAGE_INITRD ?=3D "cip-core-initramfs" >> >> (their layer would likely keep their INITRAMFS_RECIPE variable as it >> may be considered as an API towards its own downstream users). >> >> INITRD_IMAGE is "only" deprecated; meaning that it may still be used >> (but build-time warnings will be raised). If both IMAGE_INITRD and >> INITRD_IMAGE are set then the latter will be ignored (a warning noting >> that both were set will be emitted). >> >> These changes were tested against (1) new CI test-cases and (2) CIP >> Core 1.9.0 both with and without adaptions to its code. >> >> Patch dependencies: >> =C2=A0 [1]=20 >> https://lists.isar-build.org/isar-users/20251101111326.600581-1-cedric.h= ombourger@siemens.com/T/#t >> =C2=A0 [2]=20 >> https://lists.isar-build.org/isar-users/20251030094451.1303871-1-Quirin.= Gylstorff@siemens.com/T/#t >> >> InitRd tests: >> >> =C2=A0=C2=A0 builder@ed1e0b7e8d4e:/work/testsuite$ trun --max-parallel-t= asks=3D1=20 >> -p sstate=3D1 -t initrd citest.py >> =C2=A0=C2=A0 JOB ID=C2=A0=C2=A0=C2=A0=C2=A0 : bdf8f7130f426014b0c008d009= 5ad317a9f66bee >> =C2=A0=C2=A0 JOB LOG=C2=A0=C2=A0=C2=A0 :=20 >> /tmp/tmp72bozbdi/avocado/job-results/job-2025-11-02T18.30-bdf8f71/job.lo= g >> =C2=A0=C2=A0=C2=A0 (1/8) citest.py:InitRdTest.test_dracut_in_image: STAR= TED >> =C2=A0=C2=A0=C2=A0 (1/8) citest.py:InitRdTest.test_dracut_in_image: PASS= (104.93 s) >> =C2=A0=C2=A0=C2=A0 (2/8) citest.py:InitRdTest.test_dracut_build_initrd: = STARTED >> =C2=A0=C2=A0=C2=A0 (2/8) citest.py:InitRdTest.test_dracut_build_initrd: = PASS (34.36 s) >> =C2=A0=C2=A0=C2=A0 (3/8) citest.py:InitRdTest.test_dracut_build_failure:= STARTED >> =C2=A0=C2=A0=C2=A0 (3/8) citest.py:InitRdTest.test_dracut_build_failure:= FAIL:=20 >> Bitbake suceeded but was expected to fail! (143.54 s) >> =C2=A0=C2=A0=C2=A0 (4/8) citest.py:InitRdTest.test_var_initrd_image: STA= RTED >> =C2=A0=C2=A0=C2=A0 (4/8) citest.py:InitRdTest.test_var_initrd_image: PAS= S (259.88 s) >> =C2=A0=C2=A0=C2=A0 (5/8) citest.py:InitRdTest.test_var_image_initrd: STA= RTED >> =C2=A0=C2=A0=C2=A0 (5/8) citest.py:InitRdTest.test_var_image_initrd: PAS= S (237.34 s) >> =C2=A0=C2=A0=C2=A0 (6/8)=20 >> citest.py:InitRdTest.test_var_image_initrd_and_initrd_image: STARTED >> =C2=A0=C2=A0=C2=A0 (6/8)=20 >> citest.py:InitRdTest.test_var_image_initrd_and_initrd_image: PASS=20 >> (242.03 s) >> =C2=A0=C2=A0=C2=A0 (7/8) citest.py:InitRdCrossTests.test_dracut_in_image= : STARTED >> =C2=A0=C2=A0=C2=A0 (7/8) citest.py:InitRdCrossTests.test_dracut_in_image= : PASS=20 >> (407.83 s) >> =C2=A0=C2=A0=C2=A0 (8/8) citest.py:InitRdCrossTests.test_dracut_build_in= itrd: STARTED >> =C2=A0=C2=A0=C2=A0 (8/8) citest.py:InitRdCrossTests.test_dracut_build_in= itrd: PASS=20 >> (44.71 s) >> =C2=A0=C2=A0 RESULTS=C2=A0=C2=A0=C2=A0 : PASS 7 | ERROR 0 | FAIL 1 | SKI= P 0 | WARN 0 |=20 >> INTERRUPT 0 | CANCEL 0 >> =C2=A0=C2=A0 JOB TIME=C2=A0=C2=A0 : 1482.17 s >> >> See [1] and/or [2] for an explanation (and proposed fix) for the single >> test failure. >> >> Cedric Hombourger (1): >> =C2=A0=C2=A0 image: introduce IMAGE_INITRD, deprecate INITRD_IMAGE >> >> =C2=A0 RECIPE-API-CHANGELOG.md=C2=A0=C2=A0=C2=A0 | 28 +++++++++++++ >> =C2=A0 doc/user_manual.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 3 +- >> =C2=A0 meta/classes/image.bbclass | 31 ++++++++++++-- >> =C2=A0 testsuite/citest.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 8= 3 ++++++++++++++++++++++++++++++++++++++ >> =C2=A0 4 files changed, 140 insertions(+), 5 deletions(-) >> > --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= 5ae801ae-55e0-48ab-9db4-a55d7c03954b%40ilbers.de.