Re: [PATCH v3 04/11] linux-mainline: Add fTPM support

[Uladzimir Bely <ubely@ilbers.de>]

On Tue, 2023-07-25 at 16:43 +0300, Uladzimir Bely wrote:
> On Thu, 2023-07-20 at 19:08 +0200, 'Jan Kiszka' via isar-users wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > Needed for the stm32mp15x demo of fTPM.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >  meta-isar/recipes-kernel/linux/files/ftpm-module.cfg     | 3 +++
> >  meta-isar/recipes-kernel/linux/linux-mainline_5.4.203.bb | 2 ++
> >  2 files changed, 5 insertions(+)
> >  create mode 100644 meta-isar/recipes-kernel/linux/files/ftpm-
> > module.cfg
> > 
> > diff --git a/meta-isar/recipes-kernel/linux/files/ftpm-module.cfg
> > b/meta-isar/recipes-kernel/linux/files/ftpm-module.cfg
> > new file mode 100644
> > index 00000000..f47620bc
> > --- /dev/null
> > +++ b/meta-isar/recipes-kernel/linux/files/ftpm-module.cfg
> > @@ -0,0 +1,3 @@
> > +CONFIG_TEE=m
> > +CONFIG_OPTEE=m
> > +CONFIG_TCG_FTPM_TEE=m
> > diff --git a/meta-isar/recipes-kernel/linux/linux-
> > mainline_5.4.203.bb
> > b/meta-isar/recipes-kernel/linux/linux-mainline_5.4.203.bb
> > index 76f73f02..27ebf131 100644
> > --- a/meta-isar/recipes-kernel/linux/linux-mainline_5.4.203.bb
> > +++ b/meta-isar/recipes-kernel/linux/linux-mainline_5.4.203.bb
> > @@ -14,6 +14,8 @@ SRC_URI += " \
> >      file://x86_64_defconfig \
> >      file://no-ubifs-fs.cfg \
> >      file://no-root-nfs.cfg;apply=no"
> > +SRC_URI:append:stm32mp15x = " \
> > +    file://ftpm-module.cfg"
> >  
> >  SRC_URI[sha256sum] =
> > "fc933f5b13066cfa54aacb5e86747a167bad1d8d23972e4a03ab5ee36c29798a"
> >  
> > -- 
> > 2.35.3
> > 
> 
> This patch seems to make CI fail at "CrossTest.test_cross" build.
> 
> In this test we build in parallel two "armhf" targets that both use
> "mainline" kernel - stm32mp15x-bullseye and de0-nano-soc-bullseye.
> 
> Due to the same distro/kernel/arch they are both build in parallel in
> the same workdir (build/tmp/work/debian-bullseye-armhf/linux-
> mainline/5.4.203-r0) but due to "append:stm32mp15x" they should use
> different kernel config. This causes two parallel confliction builds
> and results in some weird error:
> 
> ```
> cat: /workspace/build/isar_ub_devel_fast/469/build/tmp/work/debian-
> bullseye-armhf/linux-mainline/5.4.203-r0/rootfs/dpkg_partial.log: No
> such file or directory
> ```
> 
> By the way, NoCrossTest.test_nocross doesn't fail since it doesn't
> build another bullseye/armhf linux-mainline in parallel with one for
> stm32mp15x.
> 

There are two possible ways to fix the issue:
 1. use "ftpm-module" config fragment not only for stm32mp15x (either
globally, either only for armhf targets)
 2. split "linux-mainline" build

We would actually prefer way [1] since it doesn't increase build time
in CI. Some additional modules should not be a problem even if they are
not really used/required.

I'm going to make a local fix (e.g., use ftpm fragment for all targets)
and to check if it works.