From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7320571525847842816 Date: Sun, 7 Jan 2024 20:40:37 -0800 (PST) From: Srinuvasan Arjunan To: isar-users Message-Id: <5af8f7b9-aed0-4fbc-bbda-8bbed6330f08n@googlegroups.com> In-Reply-To: <4468ef6f-5b19-4e1a-87cb-85c1edf10648@siemens.com> References: <20240105111552.664182-1-srinuvasan_a@mentor.com> <4468ef6f-5b19-4e1a-87cb-85c1edf10648@siemens.com> Subject: Re: [PATCH] classes/image-tools-extension.bbclass: remove prepare isar-apt part MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_91319_686693487.1704688837792" X-TUID: 5JDp8vfgvQfa ------=_Part_91319_686693487.1704688837792 Content-Type: multipart/alternative; boundary="----=_Part_91320_676195095.1704688837792" ------=_Part_91320_676195095.1704688837792 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Friday, January 5, 2024 at 6:21:42=E2=80=AFPM UTC+5:30 Jan Kiszka wrote: On 05.01.24 12:15, Srinuvasan Arjunan wrote:=20 > From: Srinuvasan =20 >=20 > Now isar-apt configured during sbuildchroot generation, hence remove the= =20 prepare=20 > isar-apt part from the imager_run method.=20 >=20 > This changes depends on [1]=20 >=20 > [1]: https://groups.google.com/g/isar-users/c/k8ZNw3OkWLw=20 >=20 > Signed-off-by: Srinuvasan =20 > ---=20 > meta/classes/image-tools-extension.bbclass | 13 -------------=20 > 1 file changed, 13 deletions(-)=20 >=20 > diff --git a/meta/classes/image-tools-extension.bbclass=20 b/meta/classes/image-tools-extension.bbclass=20 > index 58799fcf..46bdf78b 100644=20 > --- a/meta/classes/image-tools-extension.bbclass=20 > +++ b/meta/classes/image-tools-extension.bbclass=20 > @@ -44,19 +44,6 @@ imager_run() {=20 > distro=3D"${HOST_BASE_DISTRO}-${BASE_DISTRO_CODENAME}"=20 > fi=20 >=20 > - # prepare isar-apt=20 > - schroot -r -c ${session_id} -d / -u root -- sh -c " \=20 > - mkdir -p '/etc/apt/sources.list.d'=20 > - echo 'deb [trusted=3Dyes] file:///isar-apt ${DEBDISTRONAME} main' > \= =20 > - '/etc/apt/sources.list.d/isar-apt.list'=20 > -=20 > - mkdir -p '/etc/apt/preferences.d'=20 > - cat << EOF > '/etc/apt/preferences.d/isar-apt'=20 > -Package: *=20 > -Pin: release n=3D${DEBDISTRONAME}=20 > -Pin-Priority: 1000=20 > -EOF"=20 > -=20 > E=3D"${@ isar_export_proxies(d)}"=20 > deb_dl_dir_import ${schroot_dir} ${distro}=20 > schroot -r -c ${session_id} -d / -u root -- sh -c " \=20 Good catch! I assume this is just redundant but harmless code now,=20 right? If not, it should better be folded into a v4 of my patch.=20 Jan=20 --=20 Siemens AG, Technology=20 Linux Expert Center=20 Yes, It is harmless, however we could cleanup this part due to=20 redundant, Please fold this into V4. Srinu=20 ------=_Part_91320_676195095.1704688837792 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Friday, January 5, 2024 at 6:21:42=E2= =80=AFPM UTC+5:30 Jan Kiszka wrote:
On 05.01.24 12:15, Srinuvasan Arjunan wrote:
> From: Srinuvasan <srinuv...@sie= mens.com>
>=20
> Now isar-apt configured during sbuildchroot generation, hence re= move the prepare
> isar-apt part from the imager_run method.
>=20
> This changes depends on [1]
>=20
> [1]: https://groups.google.com/g/isar-u= sers/c/k8ZNw3OkWLw
>=20
> Signed-off-by: Srinuvasan <srin= uv...@siemens.com>
> ---
> meta/classes/image-tools-extension.bbclass | 13 -------------
> 1 file changed, 13 deletions(-)
>=20
> diff --git a/meta/classes/image-tools-extension.bbclass b/meta/c= lasses/image-tools-extension.bbclass
> index 58799fcf..46bdf78b 100644
> --- a/meta/classes/image-tools-extension.bbclass
> +++ b/meta/classes/image-tools-extension.bbclass
> @@ -44,19 +44,6 @@ imager_run() {
> distro=3D"${HOST_BASE_DISTRO}-${BASE_DISTRO_CODENAM= E}"
> fi
> =20
> - # prepare isar-apt
> - schroot -r -c ${session_id} -d / -u root -- sh -c " \
> - mkdir -p '/etc/apt/sources.list.d'
> - echo 'deb [trusted=3Dyes] file:///isar-apt ${DEBDIS= TRONAME} main' > \
> - '/etc/apt/sources.list.d/isar-apt.list'
> -
> - mkdir -p '/etc/apt/preferences.d'
> - cat << EOF > '/etc/apt/preferences.d/isar-= apt'
> -Package: *
> -Pin: release n=3D${DEBDISTRONAME}
> -Pin-Priority: 1000
> -EOF"
> -
> E=3D"${@ isar_export_proxies(d)}"
> deb_dl_dir_import ${schroot_dir} ${distro}
> schroot -r -c ${session_id} -d / -u root -- sh -c " \

Good catch! I assume this is just redundant but harmless code now,
right? If not, it should better be folded into a v4 of my patch.

Jan

--=20
Siemens AG, Technology
Linux Expert Center=C2=A0

=C2=A0 = =C2=A0Yes, It is harmless, however we could cleanup this part due to redund= ant, Please fold this into V4.

=C2=A0 =C2=A0 =C2= =A0Srinu=C2=A0
------=_Part_91320_676195095.1704688837792-- ------=_Part_91319_686693487.1704688837792--