public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Zhihang Wei <wzh@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH 1/1] fix(schroot): only mount base-apt if enabled
Date: Fri, 10 Jul 2026 11:20:11 +0200	[thread overview]
Message-ID: <5afa22a6-fa15-4a72-9315-e729734d98e7@ilbers.de> (raw)
In-Reply-To: <20260703144326.2041711-1-felix.moessbauer@siemens.com>

Applied to next, thanks.

Zhihang

On 7/3/26 16:43, 'Felix Moessbauer' via isar-users wrote:
> On partial rebuilds we might work on rootfs that do not have the
> /base-apt directory anymore. This currently fails, as we unconditionally
> mount the /base-apt when creating the schroot. This happens when running
> any imager_run command on such a chroot. We fix it by only mounting
> base-apt if needed.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   meta/classes-recipe/sbuild.bbclass | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes-recipe/sbuild.bbclass b/meta/classes-recipe/sbuild.bbclass
> index 95dadee3..af1216ea 100644
> --- a/meta/classes-recipe/sbuild.bbclass
> +++ b/meta/classes-recipe/sbuild.bbclass
> @@ -43,8 +43,10 @@ EOF
>           cp -rf "${SCHROOT_CONF}/sbuild" "${SBUILD_CONF_DIR}"
>           sbuild_fstab="${SBUILD_CONF_DIR}/fstab"
>   
> -        fstab_baseapt="${REPO_BASE_DIR} /base-apt none rw,bind,private 0 0"
> -        grep -qxF "${fstab_baseapt}" ${sbuild_fstab} || echo "${fstab_baseapt}" >> ${sbuild_fstab}
> +        if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
> +            fstab_baseapt="${REPO_BASE_DIR} /base-apt none rw,bind,private 0 0"
> +            grep -qxF "${fstab_baseapt}" ${sbuild_fstab} || echo "${fstab_baseapt}" >> ${sbuild_fstab}
> +        fi
>   
>           fstab_pkgdir="${WORKDIR} /home/builder/${BPN} none rw,bind,private 0 0"
>           grep -qxF "${fstab_pkgdir}" ${sbuild_fstab} || echo "${fstab_pkgdir}" >> ${sbuild_fstab}

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/5afa22a6-fa15-4a72-9315-e729734d98e7%40ilbers.de.

      reply	other threads:[~2026-07-10  9:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 14:43 'Felix Moessbauer' via isar-users
2026-07-10  9:20 ` Zhihang Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5afa22a6-fa15-4a72-9315-e729734d98e7@ilbers.de \
    --to=wzh@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox