From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Harald Seiler <hws@denx.de>, isar-users@googlegroups.com
Subject: Re: [PATCH v2] meta: Add targz image class
Date: Fri, 23 Nov 2018 10:32:05 +0300 [thread overview]
Message-ID: <5b838cf5-cddc-57d4-6833-a9a3aa659a2f@ilbers.de> (raw)
In-Reply-To: <0a84c12f027ce7691f78e99c26c019473ef74300.camel@denx.de>
Hi Harald,
Could you please answer to Cedric's email (see below)?
Kind regards,
Maxim.
On 11/20/18 4:14 PM, chombourger@gmail.com wrote:>
>
> On Tuesday, November 20, 2018 at 2:07:35 PM UTC+1, Harald Seiler wrote:
>
> > How will we test that?
>
> The final tar could be checked agains the rootfs tree generated
> during the build using:
>
> tar --compare --file=archive-file.tar -C /some/where/
>
> I am not sure if this is worth it though, as this will always work
> unless tar itself made a mistake ... I think the recipe is trivial
> enough that this check can be omitted.
>
>
> I wonder if Jan was instead asking how would be have this feature
> tested? possibly from a CI perspective?
>
On 11/20/18 4:19 PM, Harald Seiler wrote:
> Signed-off-by: Harald Seiler <hws@denx.de>
> ---
> meta/classes/targz-img.bbclass | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 meta/classes/targz-img.bbclass
>
> diff --git a/meta/classes/targz-img.bbclass b/meta/classes/targz-img.bbclass
> new file mode 100644
> index 0000000..cce8ded
> --- /dev/null
> +++ b/meta/classes/targz-img.bbclass
> @@ -0,0 +1,15 @@
> +# This software is a part of ISAR.
> +# Copyright (c) Siemens AG, 2018
> +#
> +# SPDX-License-Identifier: MIT
> +
> +TARGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.tar.gz"
> +
> +do_targz_image[stamp-extra-info] = "${DISTRO}-${MACHINE}"
> +
> +do_targz_image() {
> + rm -f ${TARGZ_IMAGE_FILE}
> + sudo tar -cvzf ${TARGZ_IMAGE_FILE} -C ${IMAGE_ROOTFS} .
> +}
> +
> +addtask targz_image before do_build after do_rootfs
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
next prev parent reply other threads:[~2018-11-23 7:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 11:50 [PATCH] " Harald Seiler
2018-11-20 11:54 ` Jan Kiszka
2018-11-20 12:51 ` Henning Schild
2018-11-20 13:07 ` Harald Seiler
2018-11-20 13:14 ` chombourger
2018-11-20 13:19 ` [PATCH v2] " Harald Seiler
2018-11-23 7:32 ` Maxim Yu. Osipov [this message]
2018-11-23 11:38 ` Harald Seiler
2018-11-24 14:01 ` Cedric Hombourger
2018-11-27 9:13 ` [PATCH v3] " Harald Seiler
2018-12-10 12:04 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b838cf5-cddc-57d4-6833-a9a3aa659a2f@ilbers.de \
--to=mosipov@ilbers.de \
--cc=hws@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox