From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6625908871596605440 X-Received: by 2002:a1c:4444:: with SMTP id r65mr2166402wma.22.1542958336422; Thu, 22 Nov 2018 23:32:16 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7502:: with SMTP id o2-v6ls3057723wmc.11.canary-gmail; Thu, 22 Nov 2018 23:32:16 -0800 (PST) X-Google-Smtp-Source: AJdET5eaxvAV+xxRsR9/tZKLf+gUCHbt62rd+XKWE2tAZkSGv8FgiVQwDnojNYP0b4I95xai0ZrV X-Received: by 2002:a1c:6e11:: with SMTP id j17-v6mr2032019wmc.0.1542958336045; Thu, 22 Nov 2018 23:32:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542958336; cv=none; d=google.com; s=arc-20160816; b=LLgg7av6KcYzKjQBJTNiiIpMwopIsz6QEEHW3dO3z3/7RaaxoWsNHU2akfhw+qRpyS 1Chv2ypN4B3b9S0rPN9HJe+K2NBxvd2/5HbYDLh1EMuWco1itb3jpMnaWyg3hBsywmiK QF/tVtGbRYjuPbXFwo3+dKqwxutRDakoxvIFs858/VPx7fORz1aBjcimcJeYsVLkLSec uzMfdwOL5UWyFD5Wt/FZlcqvxmKpx7Qg5BjDJowaRnNAdAr0jXytrQ/pPssilacOiwWH N7iDO+qhml2T65gyR+/2PgMevNpmN/+4PsiqqLVJPXOrNAf6dvxp4bTvLSZsYUKg24CR yH6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=sRHBxjX6kHBzunfFS5uIerNqEYEpiG7wsYM3V06E8sg=; b=zfGqu2eo7zEN4DdDPAeELvVIJ02PkpiZQDEiTp9HAysj3+oHW+CdIklWFZIUQYKSgB fr6r3RtnxD6VctzMNMpzmfKNCDRnvAcBSP+c6lm6H3AynlzHC3h53Y1eZnjRtCLvQZ9z tOXLZ5ed4vbh6fi2BAjcltZwf41zcvjBfaZWJOrAZvPQgbMH8O5gKRbbvzmd/T8Zvb50 /2YQCCTwSifz+SRbcRRtIMsc5TdSnpSws3CKW3bkyGDCT9OFsmZesH/IbG6vWAY2HmE8 ubMxO1vx1d633lqN02fHV4OTsrLSzpvXpnC3Oir3jQ3igA7ZKyYQyM8S0BnRX/N0jE/V 4KYA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id k39si751771wre.2.2018.11.22.23.32.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Nov 2018 23:32:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wAN7WAvg024821 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 23 Nov 2018 08:32:12 +0100 Subject: Re: [PATCH v2] meta: Add targz image class To: Harald Seiler , isar-users@googlegroups.com References: <20181120135119.119185af@md1za8fc.ad001.siemens.net> <0a84c12f027ce7691f78e99c26c019473ef74300.camel@denx.de> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <5b838cf5-cddc-57d4-6833-a9a3aa659a2f@ilbers.de> Date: Fri, 23 Nov 2018 10:32:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <0a84c12f027ce7691f78e99c26c019473ef74300.camel@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: lwduNBvUG1ed Hi Harald, Could you please answer to Cedric's email (see below)? Kind regards, Maxim. On 11/20/18 4:14 PM, chombourger@gmail.com wrote:> > > On Tuesday, November 20, 2018 at 2:07:35 PM UTC+1, Harald Seiler wrote: > > > How will we test that? > > The final tar could be checked agains the rootfs tree generated > during the build using: > > tar --compare --file=archive-file.tar -C /some/where/ > > I am not sure if this is worth it though, as this will always work > unless tar itself made a mistake ... I think the recipe is trivial > enough that this check can be omitted. > > > I wonder if Jan was instead asking how would be have this feature > tested? possibly from a CI perspective? > On 11/20/18 4:19 PM, Harald Seiler wrote: > Signed-off-by: Harald Seiler > --- > meta/classes/targz-img.bbclass | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 meta/classes/targz-img.bbclass > > diff --git a/meta/classes/targz-img.bbclass b/meta/classes/targz-img.bbclass > new file mode 100644 > index 0000000..cce8ded > --- /dev/null > +++ b/meta/classes/targz-img.bbclass > @@ -0,0 +1,15 @@ > +# This software is a part of ISAR. > +# Copyright (c) Siemens AG, 2018 > +# > +# SPDX-License-Identifier: MIT > + > +TARGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.tar.gz" > + > +do_targz_image[stamp-extra-info] = "${DISTRO}-${MACHINE}" > + > +do_targz_image() { > + rm -f ${TARGZ_IMAGE_FILE} > + sudo tar -cvzf ${TARGZ_IMAGE_FILE} -C ${IMAGE_ROOTFS} . > +} > + > +addtask targz_image before do_build after do_rootfs > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov