From: Alexander Smirnov <asmirnov@ilbers.de>
To: Christian Storm <christian.storm@siemens.com>,
isar-users@googlegroups.com
Subject: Re: [PATCH] buildchroot: soft-assign default IMAGE_INSTALL
Date: Thu, 14 Dec 2017 17:58:49 +0300 [thread overview]
Message-ID: <5c4ac75d-0139-2304-325f-ac7029fd1b74@ilbers.de> (raw)
In-Reply-To: <20171207131748.29963-1-christian.storm@siemens.com>
On 12/07/2017 04:17 PM, Christian Storm wrote:
> Commit 383ef25 "buildchroot: Add prepare and cleanup tasks" introduced
> a hard dependency on IMAGE_INSTALL being set. If unset, bitbake fails.
> Hence, make a soft-assigned default IMAGE_INSTALL="" in case
> IMAGE_INSTALL isn't set.
>
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
> meta/recipes-devtools/buildchroot/buildchroot.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
> index 9b9f5f6..99d5295 100644
> --- a/meta/recipes-devtools/buildchroot/buildchroot.bb
> +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
> @@ -93,6 +93,7 @@ do_prepare() {
>
> addtask prepare after do_build
>
> +IMAGE_INSTALL ??= ""
> DEPENDS += "${IMAGE_INSTALL}"
> do_cleanup[deptask] = "do_deploy_deb"
> do_cleanup[nostamp] = "1"
Not relevant anymore, do_prepare/do_cleanup dropped.
Alex
prev parent reply other threads:[~2017-12-14 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 13:17 Christian Storm
2017-12-14 14:58 ` Alexander Smirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c4ac75d-0139-2304-325f-ac7029fd1b74@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=christian.storm@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox