* [PATCH] buildchroot: soft-assign default IMAGE_INSTALL
@ 2017-12-07 13:17 Christian Storm
2017-12-14 14:58 ` Alexander Smirnov
0 siblings, 1 reply; 2+ messages in thread
From: Christian Storm @ 2017-12-07 13:17 UTC (permalink / raw)
To: isar-users; +Cc: Christian Storm
Commit 383ef25 "buildchroot: Add prepare and cleanup tasks" introduced
a hard dependency on IMAGE_INSTALL being set. If unset, bitbake fails.
Hence, make a soft-assigned default IMAGE_INSTALL="" in case
IMAGE_INSTALL isn't set.
Signed-off-by: Christian Storm <christian.storm@siemens.com>
---
meta/recipes-devtools/buildchroot/buildchroot.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
index 9b9f5f6..99d5295 100644
--- a/meta/recipes-devtools/buildchroot/buildchroot.bb
+++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
@@ -93,6 +93,7 @@ do_prepare() {
addtask prepare after do_build
+IMAGE_INSTALL ??= ""
DEPENDS += "${IMAGE_INSTALL}"
do_cleanup[deptask] = "do_deploy_deb"
do_cleanup[nostamp] = "1"
--
2.15.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] buildchroot: soft-assign default IMAGE_INSTALL
2017-12-07 13:17 [PATCH] buildchroot: soft-assign default IMAGE_INSTALL Christian Storm
@ 2017-12-14 14:58 ` Alexander Smirnov
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Smirnov @ 2017-12-14 14:58 UTC (permalink / raw)
To: Christian Storm, isar-users
On 12/07/2017 04:17 PM, Christian Storm wrote:
> Commit 383ef25 "buildchroot: Add prepare and cleanup tasks" introduced
> a hard dependency on IMAGE_INSTALL being set. If unset, bitbake fails.
> Hence, make a soft-assigned default IMAGE_INSTALL="" in case
> IMAGE_INSTALL isn't set.
>
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
> meta/recipes-devtools/buildchroot/buildchroot.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
> index 9b9f5f6..99d5295 100644
> --- a/meta/recipes-devtools/buildchroot/buildchroot.bb
> +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
> @@ -93,6 +93,7 @@ do_prepare() {
>
> addtask prepare after do_build
>
> +IMAGE_INSTALL ??= ""
> DEPENDS += "${IMAGE_INSTALL}"
> do_cleanup[deptask] = "do_deploy_deb"
> do_cleanup[nostamp] = "1"
Not relevant anymore, do_prepare/do_cleanup dropped.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-14 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-07 13:17 [PATCH] buildchroot: soft-assign default IMAGE_INSTALL Christian Storm
2017-12-14 14:58 ` Alexander Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox