From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6496794200421433344
X-Received: by 10.28.54.38 with SMTP id d38mr286231wma.3.1513263538450;
        Thu, 14 Dec 2017 06:58:58 -0800 (PST)
X-BeenThere: isar-users@googlegroups.com
Received: by 10.28.124.26 with SMTP id x26ls1142184wmc.7.canary-gmail; Thu, 14
 Dec 2017 06:58:57 -0800 (PST)
X-Google-Smtp-Source: ACJfBou6UumjGr4Lu6mIOxkTRCZrtahGP6jByA9IzzlaJ5z8DCuawzJpYJwiROi/vuNdf0TQVg4h
X-Received: by 10.223.142.214 with SMTP id q80mr773503wrb.22.1513263537678;
        Thu, 14 Dec 2017 06:58:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1513263537; cv=none;
        d=google.com; s=arc-20160816;
        b=GT9UFl3oloCiummF2i2P8OfXLvj05pgl8OOx36q1R6Pp3Uq0FIcPWYI8RCtAipyRLz
         rFnTFgu+GWenAA0VIR5SqVQBGdrSwQ1JR7OPbvbpSE6MB40763ZfeGe2xVXVlKh6qnyZ
         zFysCeCkgDuL+Dws05d23nyapYRXPhfgr89abhkKN4M5rmrkr6eZ7B5mZWUHHSaGo83j
         LVkxLTzaIGhspXQOjdrNrkOqAo0ZVZ0ixwLnDuMXI6CJKgCAPo0G4hGeyXIrt/iHh20r
         YU0zJsi7YMt7BvE48RwOPJ4VyMFAVGGGrdObhHreemxosJ98QFVEQ57PBSmC3unusO6V
         dSiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:content-language:in-reply-to:mime-version
         :user-agent:date:message-id:from:references:to:subject
         :arc-authentication-results;
        bh=PNmNOa0TXVA1tWk2OrEOLSDBw/XQ+BvQ4nV2mwdaBZQ=;
        b=pCFqZHaQ4FWDGekCiDbU04zG9IWrYpvwlpwHyrc6Dg5WpjBQbPogA3Tm3p5dUoWSof
         1b1Yr3PKOCdlkZ8SYXSzS8mGTsIxbuDpdz4Uuurf2WrQkJFrTvjYqz6urysr8b34iLfU
         Qg19hc+qMYELMRYGdls+wNF0TSy1NsFsmlMYfNzW8JLnT/VpNAT2DXK937LmIxHPLx1T
         WFpHC+ZDaPSMH2vn79jXiMqp5VN0+e/nTusE9S30PUgQvbfT3e0QvFEXnAyu7EcvzSQl
         awTwm3v/i29JOlohdJZtWtCgyLwAI2FJ+dR475qXw+QbvKxcx9QAzDoEyRFl0AcLijta
         ztGg==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de
Return-Path: <asmirnov@ilbers.de>
Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211])
        by gmr-mx.google.com with ESMTPS id r70si1500714wmg.2.2017.12.14.06.58.57
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Thu, 14 Dec 2017 06:58:57 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211;
Authentication-Results: gmr-mx.google.com;
       spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de
Received: from [10.0.2.15] ([188.227.110.165])
	(authenticated bits=0)
	by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id vBEEwsbl002556
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
	Thu, 14 Dec 2017 15:58:56 +0100
Subject: Re: [PATCH] buildchroot: soft-assign default IMAGE_INSTALL
To: Christian Storm <christian.storm@siemens.com>, isar-users@googlegroups.com
References: <20171207131748.29963-1-christian.storm@siemens.com>
From: Alexander Smirnov <asmirnov@ilbers.de>
Message-ID: <5c4ac75d-0139-2304-325f-ac7029fd1b74@ilbers.de>
Date: Thu, 14 Dec 2017 17:58:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171207131748.29963-1-christian.storm@siemens.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-TUID: /W+QLIOoNyMK

On 12/07/2017 04:17 PM, Christian Storm wrote:
> Commit 383ef25 "buildchroot: Add prepare and cleanup tasks" introduced
> a hard dependency on IMAGE_INSTALL being set. If unset, bitbake fails.
> Hence, make a soft-assigned default IMAGE_INSTALL="" in case
> IMAGE_INSTALL isn't set.
> 
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
>   meta/recipes-devtools/buildchroot/buildchroot.bb | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
> index 9b9f5f6..99d5295 100644
> --- a/meta/recipes-devtools/buildchroot/buildchroot.bb
> +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
> @@ -93,6 +93,7 @@ do_prepare() {
>   
>   addtask prepare after do_build
>   
> +IMAGE_INSTALL ??= ""
>   DEPENDS += "${IMAGE_INSTALL}"
>   do_cleanup[deptask] = "do_deploy_deb"
>   do_cleanup[nostamp] = "1"

Not relevant anymore, do_prepare/do_cleanup dropped.

Alex