From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6673096226406137856 X-Received: by 2002:a17:906:a417:: with SMTP id l23mr1145804ejz.4.1553701518196; Wed, 27 Mar 2019 08:45:18 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:9107:: with SMTP id e7ls3981635eda.9.gmail; Wed, 27 Mar 2019 08:45:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzuRBr9bnm1QubpnMJcYnagW552pRLJWuqlq7ZmaPSAbClapqM67ZwIBkEXzfRX+QNDQ7tO X-Received: by 2002:a50:b3d6:: with SMTP id t22mr1109783edd.2.1553701517739; Wed, 27 Mar 2019 08:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553701517; cv=none; d=google.com; s=arc-20160816; b=IY1CR3V6Nmgm/YBTb1VGHjTWyXk6hIktEvmQo22usAPYBarvr2UdFPadelbUIT1JaQ Yq+x8VonvBLFmDrduzWw/6EYzPF6Xa2DlPRxvwxGw/MtgniMQhbZ2dLG4UQS7u5esRki cZrUOMkJPR36pU1bO7vr7TxxEyDa9HFa6CZku2SMpN/5tqL6zeocq3ULjyp60sAkKoMn vzIomnITWNWOcJtm9V99Evs4x/RvVs7lycpZH/iAfN99CMM6t8sMHqjMP3Y5bMwodt11 9fw/LmsfarhjOejTdjuuW7IWNaBilTSWx29TLYRto1WsQYzQTMUMoA2J1dti3jWNyGBM z60w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=EhJn0RfewxjG9W9i8wbfJbfgCS8m8PupjOQ+77rlcw0=; b=wJRnMasMaFXUaUWf/kHi110g1d6qpN0npOi2hmX8qKHhLEuuHMRQ4NTnaMs/KXcxqs xwvWpTZ/TF9VYG9Xwvk5u0Nq8WFeTvrpSxrfittyKodRk1AxacPzYzqju/I1/B2qAWGO 7ik/qVtV3Zgo24vxUJ1pe2hWAGEqSCFNYxaW0Ne6DxWfGvynH9x3anX28bd8MPvzNPjH IrMfeznWOAUBdJnpu0w/qOE49B4pWgL4Gaq1dwdI0zkD/AKrXFhqBS5VfJnvKIbDiiNg ifdpxHE4+7+3OSPOBzozUz5EgswIpy+bCpDfFhBXcn3OkEwEi8kzC5zlx5ACJQvZKlbp m8Pw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id jt16si721907ejb.0.2019.03.27.08.45.17 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 08:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.1.3] (221.18-242-81.adsl-dyn.isp.belgacom.be [81.242.18.221]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2RFjEsR032170 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Mar 2019 16:45:16 +0100 Subject: Re: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe To: claudius.heine.ext@siemens.com, isar-users@googlegroups.com Cc: Claudius Heine References: <20190327154124.14663-1-claudius.heine.ext@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <5c5d2c74-6585-1481-0ce4-6be4e898e708@ilbers.de> Date: Wed, 27 Mar 2019 16:45:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190327154124.14663-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: vT7pc3RYGlJN On 3/27/19 4:41 PM, claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > In machines that have not set those variables, it is stil possible that > those classes are parsed. The parsing itself should not fail in that > case, instead those recipes should just be skipped. Please use spell checker (especially in commit message before submitting patches). Maxim. > Signed-off-by: Claudius Heine > --- > meta/classes/ubi-img.bbclass | 2 +- > meta/classes/ubifs-img.bbclass | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass > index f61a940..777b8c4 100644 > --- a/meta/classes/ubi-img.bbclass > +++ b/meta/classes/ubi-img.bbclass > @@ -5,7 +5,7 @@ > > python() { > if not d.getVar("UBINIZE_ARGS"): > - bb.fatal("UBINIZE_ARGS must be set") > + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set") > } > > UBINIZE_CFG ??= "ubinize.cfg" > diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass > index ed37357..881d2bb 100644 > --- a/meta/classes/ubifs-img.bbclass > +++ b/meta/classes/ubifs-img.bbclass > @@ -5,7 +5,7 @@ > > python() { > if not d.getVar("MKUBIFS_ARGS"): > - bb.fatal("MKUBIFS_ARGS must be set") > + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set") > } > > inherit image > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov