Re: [PATCH 2/2] ci_build: Introduce REPRO_TARGETS_SET

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 23/05/2019 14.34, Maxim Yu. Osipov wrote:
> On 5/23/19 2:27 PM, Claudius Heine wrote:
>> Hi Maxim,
>>
>> On 18/05/2019 13.11, Maxim Yu. Osipov wrote:
>>> Use minimal targets set to test local apt repo caching feature
>>>
>>> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
>>> ---
>>>   scripts/ci_build.sh | 11 ++++++++++-
>>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
>>> index ae9f5c9..9d370ac 100755
>>> --- a/scripts/ci_build.sh
>>> +++ b/scripts/ci_build.sh
>>> @@ -34,6 +34,10 @@ TARGETS_SET="\
>>>             # qemu-user-static of <= buster too old to build that
>>>             # multiconfig:qemuarm64-buster:isar-image-base
>>> +REPRO_TARGETS_SET="\
>>> +            multiconfig:qemuarm-stretch:isar-image-base \
>>> +            multiconfig:qemuarm64-stretch:isar-image-base \
>>> +            multiconfig:qemuamd64-stretch:isar-image-base"
>>
>> What is probably missing here a 
>> 'multiconfig:qemu*-buster:isar-image-base' target.
>>
>> At least after my current base-apt patchset it should be possible to 
>> build stretch and buster in the same build environment.
> 
> Would be great.
> Are you going to send the next version of your series (w/o ci patches 
> from v1 series)? If yes - please add patch to ci_build.sh updating  > REPRO_TARGETS_SET with qemu*-buster targets.

Will do, but will first run the CI on them again.

In principle we could also add rpi-stretch if cross-build is not enabled.

Claudius

> 
> Regards,
> Maxim.
> 
> 
>> Claudius
>>
>>>   show_help() {
>>>       echo "This script builds the default Isar images."
>>> @@ -116,10 +120,15 @@ fi
>>>   if [ -n "$REPRO_BUILD" ]; then
>>>       # Enable use of cached base repository
>>> -    bitbake $BB_ARGS -c cache_base_repo  $TARGETS_SET
>>> +    bitbake $BB_ARGS -c cache_base_repo $REPRO_TARGETS_SET
>>>       while [ -e bitbake.sock ]; do sleep 1; done
>>>       sudo rm -rf tmp
>>>       sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= 
>>> "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf
>>> +    bitbake $BB_ARGS $REPRO_TARGETS_SET
>>> +    while [ -e bitbake.sock ]; do sleep 1; done
>>> +    # Cleanup and disable use of cached base repository
>>> +    sudo rm -rf tmp
>>> +    sed -i -e 's/ISAR_USE_CACHED_BASE_REPO ?= 
>>> "1"/#ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf
>>>   fi
>>>   # Start build for the defined set of configurations
>>>
>>
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de