From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6739560601010307072 X-Received: by 2002:adf:ec91:: with SMTP id z17mr14660750wrn.346.1569857168935; Mon, 30 Sep 2019 08:26:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:dccc:: with SMTP id x12ls3193006wrm.3.gmail; Mon, 30 Sep 2019 08:26:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6GyI7T0qseSV3LLuyW190mdKJfuvzyXrXlmAC4/PjmoXCbxwQCnJ8LFyPnn72SxCu/A+O X-Received: by 2002:adf:f0c7:: with SMTP id x7mr14430856wro.2.1569857168367; Mon, 30 Sep 2019 08:26:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569857168; cv=none; d=google.com; s=arc-20160816; b=EyVM/CQvWYvXFJKzgANopWOgzkTWx5Tyg9eVhc8eQM5YQI7mxISuAirXmYML9znkBh wNydJSbtJJ6in6wAxMSdNkTDWW26uXdLbKJyRlaLekQXJMQ10YGlzmG5LrVEO0hqH6gG hpYGiINyRAEYUNRPY/zXtMBvxKgJ3cnFyxFO8hnq3oqeVtqL7BDhzRyYRMIRY6f8/n5k waQGc7EQsqWJWvldJMgSEWPcHib8KeEfWJy++useDtTTquhs7ePU9+aaxrTAgu6S6Dqa i7hOAu3PPWD8lSaPJkLNPUjjHMNCAW+X7T3zkLmHqJbB8OuwUiDQlNlwc+CGzkQnG5EV Z0Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=UHCf8tWv0nSeDJJ0cDlK5fpjTDPDuESpZkHfOCjFDVQ=; b=jA3JrQ0CnNw0FxP2PAWXja2YOnWQK4CHgiOVUoqt9axMePJJQau7wkN4Xqne0rcOp5 3ddknN1lDj0H84ks/tXzbwASxKL+cCRP4OijM2knWmHt40zP33lrXAAcZdtXcAczenC5 hlv1wSQ09XarEJbh4D65kuxvvbjeYslTycOek/p8MYI7U8m1XiHFCRuT1CNEY2An68+p wWc00tLoojWjrc/yfdoag1aOFuutqpYzunVRiyeu5WkrC2e0AUhxJJZvjxgxBPte+7vf Pv0IjsryVFxkQn+kNCfNKnrBd8VVsdKBPl48VG+0bhQ5p3627bl85UBQ4zyv+bRHdkmr XBoA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id i21si9989wml.4.2019.09.30.08.26.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Sep 2019 08:26:08 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x8UFQ8Bc007986 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 30 Sep 2019 17:26:08 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x8UFQ78h022658 for ; Mon, 30 Sep 2019 17:26:08 +0200 Subject: Re: [PATCH v6 12/27] Detect false sharing of recipes To: isar-users References: <5a2e329b881ec0b392d0f1abd116f1deeee0f66f.1569176231.git.jan.kiszka@siemens.com> <20190929145700.ads3zbq7hz77olcw@yssyq.m.ilbers.de> <248aa6db-6327-9604-40b6-e7135a5f9961@siemens.com> <20190930095610.shyewhozb46dautr@yssyq.m.ilbers.de> <20190930145326.prsfzcxogzebwbll@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: <5cb07f77-c81f-53ee-7b4c-183e5609ae4c@siemens.com> Date: Mon, 30 Sep 2019 17:26:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190930145326.prsfzcxogzebwbll@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: /igabxnKKmXj On 30.09.19 16:53, Baurzhan Ismagulov wrote: > On Mon, Sep 30, 2019 at 12:14:38PM +0200, Jan Kiszka wrote: >>>> isar-bootstrap had two issue: >>>> >>>> 1. Not rebuilding when it should (on changes to its configuration) >> >> https://groups.google.com/d/msg/isar-users/nciPZ484-nI/kf9C-_9tAQAJ >> (finding the right messing in googlegroups is a horrific mess...) >> >>>> 2. False sharing of it deployment directory >> >> https://groups.google.com/d/msg/isar-users/nciPZ484-nI/vjjYVf9tAQAJ > > Ok, thanks for the explanation. You unshared the host rootfses for Debian armhf > and Raspbian armhf. After that, the locks in isar_bootstrap() and > do_apt_config_prepare() are indeed not necessary. > > Actually, sharing both was an intended optimization because the resulting host > rootfses are identical. However, the implementation drops one via locking and > not via bitbake pipeline, and isn't executed on config change. Not sure how > difficult it would be to do that right. I can merge #9 and #10 for now. As the commit log stated, this assumption ("are identical") was wrong in the first place. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux