Re: [PATCH 2/2] wic: Set default WKS_FILE for non efi targets

[Anton Mikanovich <amikan@ilbers.de>]

17/01/2025 15:05, Jan Kiszka wrote:
> On 14.11.24 14:48, Anton Mikanovich wrote:
>> diff --git a/meta/classes/imagetypes_wic.bbclass b/meta/classes/imagetypes_wic.bbclass
>> index 3b697cdd..0a8d4b4d 100644
>> --- a/meta/classes/imagetypes_wic.bbclass
>> +++ b/meta/classes/imagetypes_wic.bbclass
>> @@ -8,6 +8,9 @@ USING_WIC = "${@bb.utils.contains('IMAGE_BASETYPES', 'wic', '1', '0', d)}"
>>   WKS_FILE_CHECKSUM = "${@'${WKS_FULL_PATH}:%s' % os.path.exists('${WKS_FULL_PATH}') if bb.utils.to_boolean(d.getVar('USING_WIC')) else ''}"
>>   
>>   WKS_FILE ??= "sdimage-efi"
>> +# grub-efi is incompatible with targets riscv64 and mipsel
>> +WKS_FILE:riscv64 ??= "qemuriscv"
>> +WKS_FILE:mipsel ??= "qemudefault"
> This part was wrong, breaking downstream layers: overrides win over
> normal assignments. So,
>
> WKS_FILE = "my-file"
>
> will lose in the face of the above. Fixing...
>
> Jan
>
Hello Jan,

Thanks for checking. This change was introduced as a hotfix for the 
installer
image creation of riscv64 and mipsel targets with no WKS_FILE provided in
machine config (to make it works just like any other arch). As this 
syntax is
wrong we need to find some other style for the fix.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/5ccbec3d-1faa-45c7-b649-9604c345bf9e%40ilbers.de.