From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 23 Jul 2026 15:37:02 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f59.google.com (mail-ed1-f59.google.com [209.85.208.59]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 66NDb18H009329 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Jul 2026 15:37:01 +0200 Received: by mail-ed1-f59.google.com with SMTP id 4fb4d7f45d1cf-698c181a258sf863666a12.0 for ; Thu, 23 Jul 2026 06:37:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1784813816; cv=pass; d=google.com; s=arc-20260327; b=rugocIpE3bKkAA2p+RG35APQ7VJwY4TnRiaUSYzHqgoEk1AUp4Fw9fa3KWbuQMUFIp Xo82AIa9z+cLB2gfnD2FclBxilbQyDTw/SmuXLsHxnJshVHxeOJ3HCm1zKgHU7sw7gtP MzQ6CAcY3kC4+6GYBSUBuJJOhgi5ssDVDYSYkWnCDwHb3euK5tXrx9oC4uYWs77UuVve HnxHIq7EXmbbytAr1GaD4YJ+ZPHPoUkj7aBhTZe0yt7WGGN6n6ATvv1ZTdW0nFxFCXzM TyCDcSSSqANJA06arB3r35jNTCP5L/t9q6y97KhrN7IHEY2hRngcxKWBZP1WzOqI2STM LLLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=TVfry2d1Bmf4xbsT1pSsiyj93aXdtIJjMYts72v+J1s=; fh=IHdCxwydM6LBOhFVI1VuiBfmPEKnWhkGrinydidWv6Q=; b=AlsRKN6SPaoAxvyiEvzc83RZ86IkYLV0ZpyGY7fApbaFR0vSayiPyht6CVowSJj4dY 5oA/u9DrJknbNxeDrNod/nJYFVOBhKGJvMwFGUKECw1kNZlLphm7H0vxw4pjultgo+BW ZJMJfgYCKzuZm76T0WLoxCGk+tSZFp6658V1ihogpoBKyI3DhR1ES78v9/dOg+MzM6Vu tWjwACoukSTVJ7wa19vDYpyMmXT190vrHQl2/Xw3RC8X4VtAsf8FgVKmzLpMzkh++uNn d3zlvahRSy6+45PbJjrw4c1znRiKPXIdTs0sato27aB9PuXoIxGZhuFxmu/P5nuR3cTY aqhA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1784813816; x=1785418616; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:content-type:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to:content-type; bh=TVfry2d1Bmf4xbsT1pSsiyj93aXdtIJjMYts72v+J1s=; b=R8ie9qDQPX4Q9xfT8KFGqLtjzKCnKkIG+si4YpF3krpc7zPzl8aIxLjJvyeN/rjEES MJL0Br2h4k7J2M/eSUHC/HjjdU0un+/BuC0EPsLTjvhalvSc7ssOzohmQvrQLcC1t4YU bsdQCmgeeK5IV5wkE9gGuENKjcxiUQDsl2c3394HmHppBpmgrWfd32UBG/alXqqEGal6 NQh9fgG6M9IlOQYB07keRTufBYzGv+ZhAeXhQBZGVC5DR/pmV2v3A7N0pO3D9OtyTr/N h6cXF3ZI8uxLuDl7Z+nX2S+E5tTpFs5H8IJwoLhDheiCldYU96vcg+bmfWqk0McOXbsJ AUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784813816; x=1785418616; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:content-type :in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:x-beenthere:x-gm-message-state:sender :from:to:cc:subject:date:message-id:reply-to:content-type; bh=TVfry2d1Bmf4xbsT1pSsiyj93aXdtIJjMYts72v+J1s=; b=UiKOEdWoijqZW/Iav07XE76iC9DyA/QG9kCUGCAPG03LEUImucCsC86m8eO6ygeIOb cWeilq+hZUK/Gw/hwCtQXXkI4jXqpwHXNMhI/6yEZ90sE/po+HplTHX7t5FFH2NSqXwU lZ74z5C6QIqC5a8Tu18c++4TyhJVvsLTPsy0q++MICkh/0pDLVUMtY8amHAYPuDXxPz6 U9d63P1IwIJECoDgpNk6rW0gmiHgqpEzaRfvHUuY4loqjRoO5U2F3rBDIh/c8lzit611 0gmW9he8XX39R1HWphvMnMRM7aqlqV0205tIEsY+NT+TZND3f1M1gqxCx1tKwTF1nhJV 2RqA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AHgh+Rr8NV1wjKDlBYuClIjz5a7vI9XrTSbHUswN6cc8NRPLaCp2NHagBMeH5EYtfTsGPnqYlD/5@ilbers.de X-Gm-Message-State: AOJu0YwTHipTw7JU7j+RptsBLNg09cRaNjNYN+KousCkcadoPjBaXK7P AFB8aARwRLnMfgMNk3dbz3rRESlssxYcqPKe9KMGuz43PfWQzbqJfLL+ X-Received: by 2002:a05:6402:52c4:b0:698:e595:a5c with SMTP id 4fb4d7f45d1cf-69f6bc1aaf8mr1173042a12.6.1784813816215; Thu, 23 Jul 2026 06:36:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="Aa7YSPS3mQ9ubO7BS9ZA0T7YTtHiZ0Qvhtxn1oT96iRXwjdHDA==" Received: by 2002:aa7:dd02:0:b0:698:599e:a7d7 with SMTP id 4fb4d7f45d1cf-69f60d73354ls1038721a12.1.-pod-prod-04-eu; Thu, 23 Jul 2026 06:36:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+Ro6y4YU44WraYqNvO3Fc2Eafj60uRWMJ2af4ZRCJJfwFIphJQlLjzAxEB1/f/9c+NIUdT2BwG93lfux@googlegroups.com X-Received: by 2002:a17:907:1c02:b0:c15:b332:260f with SMTP id a640c23a62f3a-c1c5089e82fmr157344766b.30.1784813813348; Thu, 23 Jul 2026 06:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784813813; cv=none; d=google.com; s=arc-20260327; b=qJJc9E2jcHoitgv2yNrNA0RqfAHUBq9LH03m2T58oqUU+EFAn+p7N+Hd8GXVHjPpGd yLBNceF0lI4E1/bItPkJ9eafQWEMvHIX0MI8qq73ZXGT1AlgyxvjXwQdanz1ff+lBs3u DrdoXZUayxOADJb5glFi0sRs20Z/G1sVng1p4wT2A4n4YPGYHkhblTlbXbEQX9BsOxuN aiB/rkdnfhg04LKnBEMJhA1ikgO8LBOV6EGHjnQqvJZjidmVyRupbx+Nsg3Tvb6hyb7w NJdcBOfZqG/FsoAS23ZJzajKDf8fXuaq/SJotbZ0krKrnu8V5CLeyluoD1OmlRgs8hGk eOVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=pwC10Sqg9gDHfrT0XRv2FizCmutrGqTQSltRsuiod04=; fh=PICfM4Fo6fj0YFd/Sa2/vzFoNnq31QOnYxZYf2j1CDU=; b=brnNF6tKvMLvTrSumqJwswAp5bFMaV5fYFhxszpPMeFYUM1B5vwcMznTvxVA4It78Q EshGEohQxSZ92az8uR7ukRITEiZUvqnSEWxldXYWDt0FSqZNn5M6pHuCtiokYHMxASoh D4+bKDBLs02EeTraTa/RCSz8UiG/U7ApjQhLOvveKLXTcMWywGZa0gNoVreaAQBHqVOe o02HtqZkiEe2ZxZ6x1CDyLOVvtqvUW+3hpr6LkYjwUFk3iDcigu5W2RwQooqFI8XHgVt KW51aRpSBoh893Pyo6KnkLU1OS5e2YcVORxVL5D3qjFgi4ZvFxCG6/3bygTt8KozlKKf bkbQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id a640c23a62f3a-c1c32c21037si11817166b.3.2026.07.23.06.36.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Jul 2026 06:36:53 -0700 (PDT) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.148] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 66NDaqSV009324 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2026 15:36:52 +0200 Message-ID: <5d2fd657-ce85-4b4a-a062-d32afeb37897@ilbers.de> Date: Thu, 23 Jul 2026 15:36:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] dpkg: directly deploy via sstate cache To: "MOESSBAUER, Felix" , "isar-users@googlegroups.com" References: <20260721150415.845260-1-felix.moessbauer@siemens.com> <20260721150415.845260-2-felix.moessbauer@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: WnVMb3zOClfO On 7/23/26 12:16, MOESSBAUER, Felix wrote: > On Tue, 2026-07-21 at 17:04 +0200, Felix Moessbauer wrote: >> By that, we can get rid of the custom sstate logic, which should be >> avoided if not needed. Further, the deploy process is now cleaner, as we >> deploy from a dedicated dir instead of the WORKDIR. >> >> Signed-off-by: Felix Moessbauer >> --- >> Changes since v1: >> >> - adapt barebox.bbclass to deploy from DEPLOYDIR instead of WORKDIR >> >> doc/technical_overview.md | 2 +- >> meta/classes-recipe/barebox.bbclass | 4 +-- >> meta/classes-recipe/dpkg-base.bbclass | 37 +++++++++------------------ >> 3 files changed, 15 insertions(+), 28 deletions(-) >> >> diff --git a/doc/technical_overview.md b/doc/technical_overview.md >> index f7e00f7b..fe427cae 100644 >> --- a/doc/technical_overview.md >> +++ b/doc/technical_overview.md >> @@ -217,7 +217,7 @@ Both consist of the following steps: >> finally unmount again (`dpkg_undo_mounts`). >> >> 6. Task `do_deploy_deb`: add successfully built packages >> - `${WORKDIR}/*.deb` to the isar-apt repository >> + `${DEPLOYDIR}/*.deb` to the isar-apt repository >> `${REPO_ISAR_DIR}/${DISTRO}` >> >> ## 3.6 Populate Target Filesystem >> diff --git a/meta/classes-recipe/barebox.bbclass b/meta/classes-recipe/barebox.bbclass >> index 45d77e3c..c9a767d5 100644 >> --- a/meta/classes-recipe/barebox.bbclass >> +++ b/meta/classes-recipe/barebox.bbclass >> @@ -47,12 +47,12 @@ BAREBOX_BASE_BIN ?= "barebox" >> >> do_deploy[dirs] = "${DEPLOY_DIR_IMAGE}" >> do_deploy() { >> - dpkg --fsys-tarfile ${WORKDIR}/${PN}_${CHANGELOG_V}_${DISTRO_ARCH}.deb | \ >> + dpkg --fsys-tarfile ${DEPLOYDIR}/${PN}_${CHANGELOG_V}_${DISTRO_ARCH}.deb | \ >> tar xOf - ./usr/lib/barebox/barebox.bin \ >> > "${DEPLOY_DIR_IMAGE}/${BAREBOX_BASE_BIN}.img" >> ln -sf ${BAREBOX_BASE_BIN}.img ${DEPLOY_DIR_IMAGE}/barebox.bin >> >> - dpkg --fsys-tarfile ${WORKDIR}/${PN}_${CHANGELOG_V}_${DISTRO_ARCH}.deb | \ >> + dpkg --fsys-tarfile ${DEPLOYDIR}/${PN}_${CHANGELOG_V}_${DISTRO_ARCH}.deb | \ >> tar xOf - ./usr/lib/barebox/barebox.config \ >> > "${DEPLOY_DIR_IMAGE}/${BAREBOX_BASE_BIN}.config" >> ln -sf ${BAREBOX_BASE_BIN}.config ${DEPLOY_DIR_IMAGE}/barebox.config >> diff --git a/meta/classes-recipe/dpkg-base.bbclass b/meta/classes-recipe/dpkg-base.bbclass >> index db912e90..e2ed4dfb 100644 >> --- a/meta/classes-recipe/dpkg-base.bbclass >> +++ b/meta/classes-recipe/dpkg-base.bbclass >> @@ -12,6 +12,8 @@ inherit repository >> inherit deb-dl-dir >> inherit essential >> >> +DEPLOYDIR = "${WORKDIR}/deploy" >> + >> DEPENDS ?= "" >> RPROVIDES ?= "${PROVIDES}" >> >> @@ -186,6 +188,10 @@ dpkg_prepare_unshare_ccache() { >> setfacl -m u:${UNSHARE_SUBUID_BASE}:rwX -m u:${@int(d.getVar('UNSHARE_SUBUID_BASE')) + 999}:rwx "${CCACHE_DIR}" >> } >> >> +dpkg_collect_debs() { >> + find ${WORKDIR} -maxdepth 1 -name "*.deb" -exec mv {} ${DEPLOYDIR} \; >> +} >> + >> python do_dpkg_build() { >> bb.build.exec_func('dpkg_chroot_prepare', d) >> try: >> @@ -193,45 +199,26 @@ python do_dpkg_build() { >> finally: >> bb.build.exec_func('dpkg_chroot_finalize', d) >> } >> +do_dpkg_build[cleandirs] = "${DEPLOYDIR}" >> +do_dpkg_build[sstate-plaindirs] = "${DEPLOYDIR}" > Hi, > > I'm currently playing around with using a hash equivalence server in > the testsuite (which brings major speedups on repeated runs and also > reduces the storage size needed). However, when do_dpkg_build is served > from the sstate cache, that WORKDIR-internal plaindir is not guaranteed > to be materialized (e.g. when the task is covered via hash equivalence > without a setscene restore). do_deploy_deb then runs against an empty > deploy dir, breaking the build. > > I already have fix for that which substitutes this patch. However, > depending on the timeline (and that this patch works in the current > mode), I'm wondering if I should send that as a replacement or as a > later improvement, together with a ton of sstate fixes that currently > remain unnoticed. > > Felix Hi Felix, I would say send it as a later improvement because we are about to merge this patch. Zhihang -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/5d2fd657-ce85-4b4a-a062-d32afeb37897%40ilbers.de.