From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6989998000320806912 X-Received: by 2002:a05:6638:35aa:: with SMTP id v42mr3544644jal.21.1627548563750; Thu, 29 Jul 2021 01:49:23 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a6b:ea0c:: with SMTP id m12ls908626ioc.2.gmail; Thu, 29 Jul 2021 01:49:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQV6Nnq17/eyMnieH+KYP4Qw0rAl8nKeUycKatE1Y/bqo9IjmZeFYF0fjnHvpoQbz0y4/7 X-Received: by 2002:a5d:9f11:: with SMTP id q17mr3111434iot.62.1627548563358; Thu, 29 Jul 2021 01:49:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1627548563; cv=pass; d=google.com; s=arc-20160816; b=ZMbLAyhc6GHvl9kykXgunPj5grDaXY5ZPB/LlBnKixxysZ1atDQacJ4Vy/3laZHNg0 lqN0izLESsfVsTzRz8BeXUVtIKfoluqfpm2rAKC7E1s45XgYnc53ldJ5uowcV2OGDjAK URgPOs6V4THnciH14SHgZcKajup9YtEDuAvxMMb4MAyTwHzh9Ki/sJPrd/92nF6hq+Xd EXP/Zdb6X/6gC4Mt/V18wNubF146c68JUDtRSyN5rwopZdQ4At08xR9TNNDf5HO6HdTR YrJ9z0fvHOHaIUEDQXRM7veKEsykM7Z9ng6z6yqrLhWLv3x3Gb6Y/gAboJAXSlc5Pw/l Ie9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-language:content-transfer-encoding:in-reply-to :user-agent:date:message-id:from:references:to:subject :dkim-signature; bh=Io/nu+BZx3QiftH0683FbEyvzmhTZ+CAQZtfj8acx6o=; b=ttRC3SUiOET9rtFodBWgSJjylFDSw7nPds/7IMiLX24PUpwKvtiLfMaEEKIGE8PqQ2 QHw9wDzGuJd44D2ldSjbGO7/wQs/fDSBR+OGvl0ahExkT+zApp7w3g87X8y45QKYZmEY qNYdJDF2uRDGjeb856Lkckt/Iyv882AvSTCCkO3wvrMb9Dq0FHCp8TxkZ56yR0gTgw7a a1G19sLEqq6cWXk2x98zawSsRiDDJ0o4fl4Joydu6PJVWeadtq00YTqGknyhWBWG/aQC 9aMVrB3xbKYAwIWJFd42dTK06mzHYqWO32hveRbBTtg4WkYrUHXg6Mx7Alm5OQEMfElG BhQQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b="mlG/17AS"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.3.52 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30052.outbound.protection.outlook.com. [40.107.3.52]) by gmr-mx.google.com with ESMTPS id w12si127052ilu.1.2021.07.29.01.49.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jul 2021 01:49:23 -0700 (PDT) Received-SPF: pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.3.52 as permitted sender) client-ip=40.107.3.52; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b="mlG/17AS"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.3.52 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hMaazzuAdKCSfk+bGOZPfypYBjqjaoYjyPsRfl6lkRkwc9hsEysHyQKR0J1sLLLdo+33vB4tWqXyFEh9kj6HSRcuxa2g5yQC3+X4sbukU4/cMM7ctM0xzJOXjL1YKa98zOI8rdwEojG+zXwPEh+TDoD6pMa4vQezfjeEkDB9EdiI0DYaLigWaCc/sHa1Qeo8ocsmZHFY65/Be24Vr7Z0s9f8pBA8tK+y3HlB6Jre7rZJlFi+jCFpFi5mjcd7b2Bi7u1kOGnKmV70PDbsytptkJcHD/YFktiC8v/nIQ5iUoZO794bWNHfVDcfyoG6MNHw5U/1VojAssVEVBAFp7mlsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Io/nu+BZx3QiftH0683FbEyvzmhTZ+CAQZtfj8acx6o=; b=cKz7+EA+92WdtEyx0YCNOeBtemuD8QEtQJYkco791BZ8MKcEMwE2ZEiCES+3GZ+apGxLbff96h7SpYLEVmV20uHFIihhNtcfMfC6GYaz15z8ByWKYSk8ItR75mi17Xx+303Y65eVkWtUqQWZzM7SssmXkVs8aln+eXrPIFUx5I8NHiy07MttocruKwzi8c9e5KwBn2dUw9E/nqUim9WXu1BzQRvz2RPpE9lJHP7U48COoqY5od5t/CMmjF0bC/hfT2g80Oftcb9P9uQ4zYdZnKxWRcirXDuBhQs8k6RmcDVl5t6pzF2DLuHdB26rE5WEwO14JpdVtqrRj7xHsunNiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Io/nu+BZx3QiftH0683FbEyvzmhTZ+CAQZtfj8acx6o=; b=mlG/17ASLKn3GNsVMYaU38cMFl8sU/spZvhm0iH4Qm8H3N5jAzWFz+5svb6J8R5CGOWCPNwks5HaspdH7Eel5aXa/BSzZu3oxFqnDGrPUgkLxSFLTMt1n/+UP08CzaV5kfVeegFCS21sgqeLoBZ6w2dj3EAYFh8tYS9TrarV1uM= Authentication-Results: googlegroups.com; dkim=none (message not signed) header.d=none;googlegroups.com; dmarc=none action=none header.from=siemens.com; Received: from PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:ab::7) by PR3PR10MB3916.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:48::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.29; Thu, 29 Jul 2021 08:49:21 +0000 Received: from PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d6e:ae99:c95c:83bd]) by PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d6e:ae99:c95c:83bd%9]) with mapi id 15.20.4373.018; Thu, 29 Jul 2021 08:49:21 +0000 Subject: Re: [PATCH 2/4] classes: simplify tag handling in container class To: Henning Schild , isar-users@googlegroups.com References: <20210728152210.7089-1-henning.schild@siemens.com> <20210728152210.7089-3-henning.schild@siemens.com> From: Silvano Cirujano Cuesta Message-ID: <5d95f9be-f68b-76df-5d50-a7cf92c5de3c@siemens.com> Date: Thu, 29 Jul 2021 10:49:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: <20210728152210.7089-3-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: PR0P264CA0202.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::22) To PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:ab::7) Return-Path: silvano.cirujano-cuesta@siemens.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [139.23.72.45] (195.145.170.159) by PR0P264CA0202.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17 via Frontend Transport; Thu, 29 Jul 2021 08:49:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cafb0be-7396-4caa-c71d-08d9526dc257 X-MS-TrafficTypeDiagnostic: PR3PR10MB3916: X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T9QvG6+F1T+GgrULAzs3A6ZHNbJiIG1AS3wKP/P/XnSz+743CFEW5ZuFcO9+YJr/sD6J3mOLVIV7LNJCqC1UkhhnI/5U1/Cj2o/Ce8l+RBYG+bFRq23rIJtlYGrybZN2C6JvdLAZXsU5/ultWUrcIfHsfaSwXkh5iEJvKDlquVuKHLXr2va/jUmtoPZjZOaKLLeL5kyilts+8/pXD7E+CyhNOC/GXkcaINA+8ffNfrDfVE2PHY6YsVZT6gY+otZU/6H5RhygUNjlriIDtKuuf97vNTbPMglrMD43dxV70LKk1z/Bdru832sxP9SO0wxjzuvR5w93uAe3Q0jNRB1sCkbMCrr6QDSNENZrJcevgfm6tcpWvj+m7+QfLz11K7LEVFXTCixkO7UPz5KgWtPxPWM/myGla7CuRGetHHElESeU8ln7T/SoySM+Fk1s1/nuLHclRfGuRuoKTNVTK+YB28Qt2B4DD2SfMFHSz/R9+Jyjqwj2voUZVEU4Wj4ePvE8KKANo9f+KeD/JC6QK9IRViZwZc8YSp3Un+Wuqu0dyg9z+Ty2vcgp85+8FVMjFPAOjdy6ZPaQkIQ52G+Ohx6OPIij4ux0pPxr8gScck8GkLSZjhC43bMNIbPUnXsLqXtcSfLbgca8KWtq8geiLcIhi8i1pT+2YAT5ZEQPge9g1gpVP2vXK2043pc3ARum651Wit3/VHi+BFMcKcnAFy0+M1fayc6pIEvhpqhxiYsCgFi0ilIO8gR3xJ2iS2ny66xF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(31686004)(478600001)(38100700002)(66476007)(316002)(956004)(66556008)(2616005)(31696002)(26005)(83380400001)(2906002)(16576012)(8676002)(8936002)(36756003)(186003)(53546011)(6486002)(86362001)(5660300002)(6706004)(66946007)(78286007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3B0S2VVbU04T2toS0NUdDRQaUVRV0tySVFVZy8vNk5jNndjTTB4ZWt2OG5D?= =?utf-8?B?THd4ZFlRa1VMRnh4V09xNXFiVXNacVdxUHZJUmlGQk5tL3lwaU42aHBIeXYx?= =?utf-8?B?SXNhaWNJZC9VQ3RNdDIrZUtFaVZzVFZkeERuZktXUHRQSzNaTlhKOU84M0tJ?= =?utf-8?B?QW12cmlpcHdpUllJT2VGUHNESFpVN2RVWFIwY1RUVlBzeTMwQUdGUUMvRnpj?= =?utf-8?B?aThibUFyUWV0d0g4N0FtVXViU3FGWVMyU090UDRvRkVjUi9tL2ZxaHF5aGVL?= =?utf-8?B?cm5TOG5ScDZ5V3ZiYkR0ZnBRWEVHQko2ZEhTaWluSy9aQXVUUVdrQW1FL2ww?= =?utf-8?B?MHpRUUZrYmNLeDB6SENGWlREczBnZ3Y1SmNLMURCeCtvYldsKytLc3hVeWtR?= =?utf-8?B?SysvcjZiL3NCb3Nrb09UdWYvVG50SUJ1RUF1d2ZtWkFKRGdBTkllQ3hBTUJm?= =?utf-8?B?cW5EZFJBcGMzOGRzaG5DenFjOVA2LzZ3endtNjdqb3kvNWhJTFA0V1JsTHBS?= =?utf-8?B?TVZtWXVYMWllejF1MkJIS3pleWFSOU1UQ3haNGlLa2t1OGdRTVpIbEZ4b3F5?= =?utf-8?B?d0lHaU84c3lyUkNoRmlwOW8rNnU3QmJtRm5LcWV5Q3hjUnFKZHh3K2hiellZ?= =?utf-8?B?aE40TkIwcjZuaDIwb2ZHNHAzYUhRS0NyUzhZeHhsREl4ampkTnJsSDIzK1J4?= =?utf-8?B?UE5NOVUrNXpSMTYrVTU0MlhZNCtvcm04d1ZTRUF5RFNQb2VHOFdqNW5SZmpC?= =?utf-8?B?c24zekphRU9oOGtjUUxlbVhndm9EY3M3MkxzQVROYUpKTUJkbzN4d2ZJN1Ni?= =?utf-8?B?SmpWaGZFYUJvdXFaWkViNUJNU1UzZ21nalVndGdwMTIyNDRPYTBMeGhNcHpO?= =?utf-8?B?eG5tVFFiSVVqWjluN3haZHJKenJxaThQS1BodXRyVEE5a1VWM09raVkwTUVq?= =?utf-8?B?a200RDFBY3dJWEpEemthOXRjWUtkNjRIZUR4TE51V0U5TjJvcXBKN3ZuL1ZV?= =?utf-8?B?YUl2YTNMT2IvaGFNK0NPaStGa2Q1MUhkQ2dETnJuanhOYWljelBlOVY0Y1Fr?= =?utf-8?B?bGZHb2ZObHk4c2N0b0diMGpWL2Evb0U4dDFPMUQ1blpVblB3M3h2QlBvMjVi?= =?utf-8?B?Q1I4ZnJpcDR3TGlyUFpuRG9PQ2tvYjluUkl4WkdJR0d1TktFYmdRNzdtTVRG?= =?utf-8?B?OXlZblNlMVVqRDJjZ3ZSWVEzY3hwMXFFS25vOWl6ZE1EYlVKNERmb2tEb3N6?= =?utf-8?B?Nm03ZXhFWU43dFJ5d2tzcXU1aFcveWJOVDZrYkpkOU9uaUh2ZHpSblYzUURE?= =?utf-8?B?L0NiRVBWWkJIbUduV0QvOTRwT1BPQ2FYajZGZy8xaUI5WEN4ZmM2dHFSN2dT?= =?utf-8?B?TnFWbE5xZktaSEdvWEJZSzUxUkxDYlJvbGxOOGdjRGpOZWxMTm4vemxMem52?= =?utf-8?B?ajZXdThXMDRwMVQwTVBJTkQydkRxREVYa2pCb2FSV05iNUNaVzN2dWtZak9z?= =?utf-8?B?c2ZYR01Qb1VjdHd2ZXR4NFpSK3p1c0Q4VG02ZFVVSkhJSHF5RGhrK1J3VDdX?= =?utf-8?B?V1kzWUVBRkhBNU4reXRjKzMwTkZVTkxNM2dOUVhLS3lOazk0S25zTHZvb0FF?= =?utf-8?B?UEMxT3hOVE1ia2JMblRhV3BYbUpDLzBYN2JDWEx0N1hvbjFmdGM1WTFuVitT?= =?utf-8?B?S3dWVHI5UDZxOWJsUmIrOG5wdWZ1SnlyVVZhNWkvS0YxNk1ZN0FxcHFtZnph?= =?utf-8?Q?8hiF2B0JblmdYUjECjplQigjvoEIOudmI7HF73q?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cafb0be-7396-4caa-c71d-08d9526dc257 X-MS-Exchange-CrossTenant-AuthSource: PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 08:49:21.5818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cRZQw8Jx+/4zrI79OZWW0os/Hlm0vKRBPQLYi6VsHIFAwJSKFoVc2orl6vZvfZT3yDcJ0gAaDpt4fw50nylBL1iU9reeJYitz1CZ2FAqBCJhKAbKe59CZFA4wsvu0lWt X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB3916 X-TUID: tbO1jcaOMH7/ On 28/07/2021 17:22, Henning Schild wrote: > Call the variable "tag" and use it in all places where "latest" was > hardcoded. This prepares for another patch that will allow chosing > something else than "latest" for a tag. I named it "full_tag" to remark the difference with the tag of the empty container image. But you're probably right, that simply "tag" is a better name. Replacing the hard-coded tag is also meaningful. > > Signed-off-by: Henning Schild > --- > meta/classes/image-container-extension.bbclass | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass > index 6537fc693265..0e70ba9c1405 100644 > --- a/meta/classes/image-container-extension.bbclass > +++ b/meta/classes/image-container-extension.bbclass > @@ -10,7 +10,7 @@ CONTAINER_FORMATS ?= "docker-archive" > containerize_rootfs() { > local cmd="/bin/dash" > local empty_tag="empty" > - local full_tag="latest" > + local tag="latest" > local oci_img_dir="${WORKDIR}/oci-image" > local rootfs="$1" > local rootfs_id="$2" > @@ -33,7 +33,7 @@ containerize_rootfs() { > > # pack container image > bbdebug 1 "pack container image" > - sudo umoci repack --image "${oci_img_dir}:${full_tag}" \ > + sudo umoci repack --image "${oci_img_dir}:${tag}" \ > "${oci_img_dir}_unpacked" > sudo umoci remove --image "${oci_img_dir}:${empty_tag}" > sudo rm -rf "${oci_img_dir}_unpacked" > @@ -49,14 +49,14 @@ containerize_rootfs() { > case "${image_type}" in > "docker-archive" | "oci-archive") > if [ "${image_type}" = "oci-archive" ] ; then > - target="${image_type}:${image_archive}:latest" > + target="${image_type}:${image_archive}:${tag}" > else > - target="${image_type}:${image_archive}:${image_name}:latest" > + target="${image_type}:${image_archive}:${image_name}:${tag}" > fi > rm -f "${image_archive}" "${image_archive}.xz" > bbdebug 2 "Converting OCI image to ${image_type}" > skopeo --insecure-policy copy \ > - "oci:${oci_img_dir}:${full_tag}" "${target}" > + "oci:${oci_img_dir}:${tag}" "${target}" > bbdebug 2 "Compressing image" > xz -T0 "${image_archive}" > ;; > @@ -69,8 +69,8 @@ containerize_rootfs() { > die "Adding the container image to a container runtime (${image_type}) not supported if running from a container (e.g. 'kas-container')" > fi > skopeo --insecure-policy copy \ > - "oci:${oci_img_dir}:${full_tag}" \ > - "${image_type}:${image_name}:latest" > + "oci:${oci_img_dir}:${tag}" \ > + "${image_type}:${image_name}:${tag}" > ;; > *) > die "Unsupported format for containerize_rootfs: ${image_type}" Silvano Cirujano Cuesta -- Siemens AG, T RDA IOT SES-DE Corporate Competence Center Embedded Linux