public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Claudius Heine <claudius.heine.ext@siemens.com>
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [PATCH 0/1] Cleanup of the configscripts
Date: Tue, 10 Apr 2018 15:49:25 +0200	[thread overview]
Message-ID: <5da80511-b4af-1bd0-a2be-bc46e027a595@siemens.com> (raw)
In-Reply-To: <20180410131454.1955-1-claudius.heine.ext@siemens.com>

On 04/10/2018 03:14 PM, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Hi,
> 
> this patch contains some cleanup of the configuration scripts.
> I tried testing it with the raspberry pi, but could do it since isar is
> apparantly incompatible with rasberry pi 3. And thats the only version I
> had available.
> 
> But I took a look at the files on the boot partition and they look fine.

We also might want to start the discussion about what to do with the 
rest of the configuration script content:

   1. Setting up the locale settings
   2. Setting up /etc/fstab
   3. Creating /dev/console
   4. Setting up getty for serial connection
   5. purging unused locale setting and man files
   6. executing 'apt-get clean'

I sort of see reason to do general cleanup jobs in the configuration 
script. Since that should be done after all packages are installed but 
before we could extract all used packages for the reproducable build 
feature. Most of those other steps I would rather do in post/preinst 
steps of a package. The order is not really that important there. Maybe 
its possible to create some sort of 'isar-general-setup' package, that 
does all of that based on bitbake variables and is included in every 
image per default.

What do you think?

Cheers,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

  parent reply	other threads:[~2018-04-10 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 13:14 claudius.heine.ext
2018-04-10 13:14 ` [PATCH 1/1] meta-isar/isar-image-base: remove uncesessary cmd lines from cfg scripts claudius.heine.ext
2018-04-10 13:49 ` Claudius Heine [this message]
2018-04-11  9:24 ` [PATCH 0/1] Cleanup of the configscripts Claudius Heine
2018-04-11 10:19   ` Claudius Heine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5da80511-b4af-1bd0-a2be-bc46e027a595@siemens.com \
    --to=claudius.heine.ext@siemens.com \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox