From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6592507174472122368 X-Received: by 2002:a1c:ecb:: with SMTP id 194-v6mr8309wmo.9.1535785128459; Fri, 31 Aug 2018 23:58:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7e03:: with SMTP id z3-v6ls1388782wmc.4.gmail; Fri, 31 Aug 2018 23:58:48 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbjelY98ROgeB4m43B6lAg+qKqDe/OUmbOgaoiZ7ad06nu5GHUQdeEv8g8Rv4WDJUOnxuoz X-Received: by 2002:a7b:c00e:: with SMTP id c14-v6mr8525wmb.16.1535785128107; Fri, 31 Aug 2018 23:58:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535785128; cv=none; d=google.com; s=arc-20160816; b=Z/O1ZGVkTa/0m7ISHqHO5yZe12oW0+RiRiDbh9ROi9V7aPXUvC/JzVGOZEBYsdyhLU tT7e3gfij6UURaadVyfbnZn8BIQYH0vKCeBUbCHe1wJTsK6YRKntXHX6XAMreXI/+C9+ DdGzEeR8/XvsnyOXlFD7Pgj/P+wxsDtNMp95FUpKKtljDK1ql4kTgzoY0Y3pdTKELJr3 3RcZUycFEULNlQfpLU4wu7/AsnxqEs5R+gIfnCqgwBKY7i/CzJeheWBrW5JWbig3R6s1 azC/UKQamdG8zSjmswfCgapa577gUyFfixm9HBDM5cL+wNETKY/XY6mo+vrdWCJZQJ75 iCCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=G0qD/flB79xHhLw1dvlfJ12FOsdUjMY7dC3zVzqB8dM=; b=NQpMk0DkdrJH3xg55XTuiyfPWvIcjXIZzS9uTI/8kIutBwHqzXrm+qNnjGnUMdqlUJ GBGH/uZ8Btcc71ICtvbUwt4fLKTGyUyJmYGZz8ubAfTrsqKSLubrOomuIxGkqz3iC8rB 3mux2/WQZO+VBWY1Gz8HY9DxBF9HY8LASVeIUPMz1N+phrJpKknRt42UARqsCXLevvtw 57mU5TO7mwHpDU5DqD/F0BEhGmhX5zw+INeDSpIdMZuXMAQIOrzZziqam8gTzGOZbLEt G/Gcrc+UMyAgeCUWEKnEVZWuRGmyLny5g6DBcSjMrW8N8vsAmNzHpAm9kKG+dINv+snU Yo8A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [217.72.192.78]) by gmr-mx.google.com with ESMTPS id b192-v6si193171wmd.2.2018.08.31.23.58.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Aug 2018 23:58:48 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 217.72.192.78 as permitted sender) client-ip=217.72.192.78; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MJTZX-1ftW600NRb-0035EL; Sat, 01 Sep 2018 08:58:47 +0200 Subject: Re: [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare From: Jan Kiszka To: chombourger@gmail.com, isar-users , Maksim Osipov References: <20180822154145.07d4a2ca@md1pvb1c.ad001.siemens.net> <1535264488-128-1-git-send-email-Cedric_Hombourger@mentor.com> <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> <1e560261-edee-203b-db74-4ed5d1a35541@siemens.com> <78c2e4d4-6fff-c312-323e-582b961460d5@siemens.com> Message-ID: <5dcaa3ae-76be-b3b5-e1b5-926783bf9808@web.de> Date: Sat, 1 Sep 2018 08:58:36 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <78c2e4d4-6fff-c312-323e-582b961460d5@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:zBfUvQPdF/BvXi1Sn7sPWBeCpRHwwL/YxabI34VylZqqD+5WwMO Fj74Pw+0d4eALavcJFdY3jqAfW1Q+YcTVlsEkIYC69AUJGS4pWc3jQkMJBgQmp+79iGwKUr uf7ebj2s/D+WY2bV3IDsll/BYr8FswFl8OZ22wxZ9YqfD0+KOfjF1JupB6vPMApQsgN0RSt 9dQaRPpPVXOs4/JkTMaCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:LjvtTENx8+s=:UPOGkDRZ6Q/rPYIXI73OKG fiETCbetUF8tpdabcl6r2GsLVi03P7pjRnbrdVfwdR310l2QlwVlJadc6raiWCBN7aCiPcKt/ v9ouq5sg1qntSrastUqzpF3XEl/7ldzAzGvRBCl8HOmIielEONSSrKwWG5WSGLB49KyqAhJ0t Ei8XD9oj8AEniakdVGU9g35mrCJbMZDLeZ3W2UJkedhb6UJ6qdfYyrc5X96ziaWA/51RXip1t WmL1PdWOhqJA/PIglwqSco54W479aOU9dHiKGYmCXEEf+Lrk+cH6hsKoCxXBzj+xXPpKp8l1t mxJV32s7kRSEbfdnbH6r0mgXbFZ57RwVqM/1+Hc4ji7bPx5q3s+3ueQDuv0Z0IdlrAuuilWvW wji45ROH3RzUQlEh3T1wJsiPHaKWkUt3mVpTvdDJS/FwGITJZ2X2kFQzj+gUyw90TKo4uLueG 7VwDNNNcNWxuQ+GJThajzQtby2EEXRSw2IyzCoKtuPZmA5D0/wqNTCyf3MJK9zAzgl4F/GJ0p mW5nGZBsrCoJh6zzC/E7KNWdpg4qGNLKlSV4yiep7RIWa2xkJhxrCt5Uq+OGb/j66sAEDBe1g 1SMB7IbVP250Hs/BEzvEoPVk8D6txH3NL71JUWU7tXh4S95fnBasdVR2d6k1zuEB7MWVTLwwr KcIxWrJEKQbH/iRCLmpqs3uUqDJA89p5VcbShm4QohnbYAQd8plDS7Pa+y7QoJwCVesoalGkd NWy7KvhMaVNUQu1kDl53DUCYvDHXn1s7NuOCNk7oTbUqpymbbDvdcp6Aa9bMK/MZ23JBKMTDF CuTMaBR X-TUID: TJVq3SkdX8tv On 2018-08-31 11:05, [ext] Jan Kiszka wrote: > On 2018-08-31 10:41, Jan Kiszka wrote: >> On 2018-08-31 10:33, chombourger@gmail.com wrote: >>> >>> >>> On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: >>> >>>     Re-reading the patch with my new knowledge: >>> >>>     On 2018-08-26 08:21, Cedric Hombourger wrote: >>>      > diff --git a/meta/recipes-kernel/linux-module/module.inc >>>     b/meta/recipes-kernel/linux-module/module.inc >>>      > index 3075f44..3a3cab1 100644 >>>      > --- a/meta/recipes-kernel/linux-module/module.inc >>>      > +++ b/meta/recipes-kernel/linux-module/module.inc >>>      > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" >>>      > >>>      >   inherit dpkg >>>      > >>>      > -dpkg_runbuild_prepend() { >>>      > +do_prepare_prepend() { >>> >>>     Shouldn't that be dpgk_prepare_append()? >>> >>> >>> Wouldn't it be too late? >>> I am afraid that debian/control wouldn't be complete and prevent >>> installation of build dependencies >>> >> >> Right, we need that for the installation... >> >> I was wondering, though, if it wouldn't be cleaner to hook additions >> to the inner handler. >> >> Anyway, all this is not mature yet: >> >> - debianization does not require locking, only the dependency >>    installation does >> >> - I'm quite sure something is broken now with dpkg-raw, because there is >>    no lock involved, but we can pull packages that way as well >> > > Yep, confirmed: We so far installed the dependencies of both regular and > raw packages in the build script under the lock. Now you pulled that > installation into deps.sh, but that script is not executed by dpkg-raw, > nor is there any lock on the related prepare step. > > Can we fix this quickly? Or better revert and redo the series (given the > other issues)? I have to correct myself: dpkg-raw packages only have runtime dependencies, no Build-Depends. Thus they never installed anything into the buildchroot and also never used the build script - we are fine in this regard. I'll write a few patches to address the other issues. Jan > > Jan > >> - we should cleanly name the steps, as you suggested, so that users know >>    what to overwrite / append /prepend >> >> Jan >> >