public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	isar-users@googlegroups.com
Cc: vijaikumar.kanagarajan@gmail.com, jan.kiszka@siemens.com
Subject: Re: [PATCH v7 0/1] add support for debian build profiles
Date: Wed, 9 Feb 2022 15:17:30 +0300	[thread overview]
Message-ID: <5de2856c-0dcc-6e59-0566-d2adae198262@ilbers.de> (raw)
In-Reply-To: <20220201161619.726934-1-felix.moessbauer@siemens.com>

01.02.2022 19:16, Felix Moessbauer wrote:
> Changes since v6:
>
> - always expand ISAR_CROSS_COMPILE variable when used in debian build profiles / options
> - rebased onto next
>
> Changes since v5:
>
> - squash into a single commit to ensure atomicity of patch (review comment from Jan Kiszka)
>
> Changes since v4:
>
> - fix devshell (glitch introduced in v3)
>
> Changes since v3:
>
> Set variables via export shell directive instead of setting via os.environ.
> This change is required as os.environ sets the environment of the whole bitbake run, hence affects other tasks as well.
> As we have to use export, there is no way for us to check if the variable is already exported.
> Also checking the current env-vars in isar_deb_build_profiles does not help as the bb function is called prior to the invocation of the shell function that does the compiling.
> I added a statement to the RECIPE-API-CHANGELOG about that.
>
> Changes since v2:
>
> - only provide DEB_BUILD_PROFILES variable (no _CROSS variable)
> - add "cross" directly to env variable when cross-compiling
> - add DEB_BUILD_OPTIONS bitbake variable
>    (profiles like "nocheck" must also add "nocheck" to DEB_BUILD_OPTIONS)
> - update API changelog
> - use DEB_BUILD_OPTIONS in hello.bb example
>
> Changes since v1:
>
> - fix erronous code removal reported by Vijai
> - only use value of DEB_BUILD_PROFILES_CROSS when cross-compiling (no combination of values)
> - improve API changelog docs
> - rebased onto next
> - use DEB_BUILD_PROFILES infrastructure in linux-custom.inc
>
>
> Felix Moessbauer (1):
>    add support for debian build profiles and options
>
>   RECIPE-API-CHANGELOG.md                       |  8 ++++++++
>   meta-isar/recipes-app/hello/hello.bb          |  8 ++------
>   meta/classes/dpkg-base.bbclass                | 19 +++++++++++++++++++
>   meta/classes/dpkg.bbclass                     |  7 ++++++-
>   .../libubootenv/libubootenv_0.3-3.bb          |  5 +----
>   meta/recipes-kernel/linux/linux-custom.inc    | 13 ++++++++-----
>   6 files changed, 44 insertions(+), 16 deletions(-)
>
Applied to next, thanks.


      parent reply	other threads:[~2022-02-09 12:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 16:16 Felix Moessbauer
2022-02-01 16:16 ` [PATCH v7 1/1] add support for debian build profiles and options Felix Moessbauer
2022-02-02 13:42 ` [PATCH v7 0/1] add support for debian build profiles Anton Mikanovich
2022-02-09 12:17 ` Anton Mikanovich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5de2856c-0dcc-6e59-0566-d2adae198262@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=vijaikumar.kanagarajan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox