From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7332083556496179200 X-Forwarded-Encrypted: i=2; AJvYcCUSs0WX5eowN785L8bFymAICLVpdmercLxkxw/KGW60kETlthClryyqkSfXkR1tdbiIdaMQSwWfQC+U1PRkLXp5aoO+HCzl11wMfJg= X-Received: by 2002:a2e:9d05:0:b0:2d0:7a98:a493 with SMTP id t5-20020a2e9d05000000b002d07a98a493mr3830805lji.39.1707293968214; Wed, 07 Feb 2024 00:19:28 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9788:0:b0:2d0:b64a:cce1 with SMTP id y8-20020a2e9788000000b002d0b64acce1ls154217lji.0.-pod-prod-04-eu; Wed, 07 Feb 2024 00:19:26 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUGN4rHjQ/Vt6yqugSB2LDncAUkSWm2dyFDUe8GOO1LUXgH6JEIZ7NJkWwmd4YTioBDUXgZYIt6q/yGDhYuaneUM0GBk4CQOc3+vc0= X-Google-Smtp-Source: AGHT+IHyt5EvVp+yKWAx+wHXyYtgB8j4Q/vLxWraV5XRqTwCFyb+Z1wWKcXSmmbOmPBdubgkbmUu X-Received: by 2002:a05:651c:b0a:b0:2d0:cbeb:7087 with SMTP id b10-20020a05651c0b0a00b002d0cbeb7087mr408133ljr.27.1707293965762; Wed, 07 Feb 2024 00:19:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707293965; cv=none; d=google.com; s=arc-20160816; b=J/k/iOREhga7lpBC+d1vpwCYHyfxcFzX3nUNrSxkK6KQc1Lffpb8IazVpDJ900RMVB TyV6qmwyncekCR40iOfjmcKiW+kyAhcjtAF+WaG/T9utBONr/89aX/lMjt1G5+QV0tmG MOskidckmxnXawO/g/qplJeABBV3D8+Rftn6KFiVNqNuwqwApdKNKoevNFfKL/iQAEAQ 5RCBI9skppXPRSoOvR0eMit2CD6t3KcW2kysSu1Dn8DxH+7bhngLn7vfNEAuGsQuA/FS KLUyeWfaI7xEYwrl/m3dvUOo5C2iF9hSpZfTUVaOvDKW9e0Sn7t/jBgscCm8gbaAWbmq y0uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id; bh=LzS/gPYZXC8Y34bfcoU5WX99eRZ5E81EUX39zh8uAPE=; fh=ziDKmEhnSMeHI183hWeq7dY/KQglEL1qM3JrFhO4tG8=; b=nOmj1PYpD314cEGjsWVMBibP/ySfPT/CHk/lx+k++MGKjDgo17J2gC6LikLLlN+YtS KFQTlqbw9/NJNKPSOKq05rVdDpoEpd5LH3KDC++ex2p5mcwGVqwNnyZGC6XCttkZ5Sd1 crGi4ljhxzEai6NWg19hh9TGRIL3APdRfqCBSf5JAY6Tx2QBZQGjy+U6Vyo0nvpNfMaZ VOhmi6H57XCRHYIaWbZqs20KUTMC4RAx2WPaNTpOAjmxKhVr6yARcVs0OiQEoifuCy6e o2uBRizvXP6E84ss53bBpq/SXJKCg6nwC+rLYCvePlu0Oy19xl+pqwB8ExzEaS+9qWdk asSg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de X-Forwarded-Encrypted: i=1; AJvYcCUX+lWAcgcUfEhqjlHEc5kNYjq+iy8pCq4ckfHvdkO8sj3xBDtYFc28tOpuI3/wkRm4VkIuOFnLeNqPkbpZMLatM3l3Xgs8m6L1XzI= Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id e20-20020a2e9854000000b002d09f409141si53921ljj.4.2024.02.07.00.19.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2024 00:19:25 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 4178JMxq014906 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Feb 2024 09:19:24 +0100 Message-ID: <5e2090afdce6e54ec85374db2b34f84a141bbaa5.camel@ilbers.de> Subject: Re: [PATCH 1/1] fix: clean apt-cache dirs in dpkg_runbuild as root From: Uladzimir Bely To: Felix Moessbauer , isar-users@googlegroups.com Cc: Jan Kiszka Date: Wed, 07 Feb 2024 11:19:25 +0300 In-Reply-To: <20240205114837.96599-1-felix.moessbauer@siemens.com> References: <20240205114837.96599-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: rR8fnnzXhpDN On Mon, 2024-02-05 at 12:48 +0100, 'Felix Moessbauer' via isar-users wrote: > This patch fixes a regression introduced in a0b293c5: The cleaning > of the rootfs dir before dpkg_runbuild needs to be performed as root, > as > this dir might contain data which cannot be deleted by the default > user. >=20 > Reported-by: Jan Kiszka > Signed-off-by: Felix Moessbauer > --- > =C2=A0meta/classes/dpkg.bbclass | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 3fc29806..0578977d 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -34,7 +34,7 @@ CP_FLAGS ?=3D "-Ln --no-preserve=3Downer" > =C2=A0CP_FLAGS:sid ?=3D "-L --update=3Dnone --no-preserve=3Downer" > =C2=A0 > =C2=A0# Build package from sources using build script > -dpkg_runbuild[cleandirs] +=3D "${WORKDIR}/rootfs" > +dpkg_runbuild[root_cleandirs] +=3D "${WORKDIR}/rootfs" > =C2=A0dpkg_runbuild[vardepsexclude] +=3D "${SBUILD_PASSTHROUGH_ADDITIONS}= " > =C2=A0dpkg_runbuild() { > =C2=A0=C2=A0=C2=A0=C2=A0 E=3D"${@ isar_export_proxies(d)}" > --=20 > 2.39.2 >=20 This has passed internal CI, so if noone against, we could merge this fix faster than usually. Jan, could you confirm that it fixes the regression you've discovered with rebuilding?