From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7150622362639007744 X-Received: by 2002:adf:fc0b:0:b0:2ba:fb00:1c77 with SMTP id i11-20020adffc0b000000b002bafb001c77mr18322wrr.259.1672995302778; Fri, 06 Jan 2023 00:55:02 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:e909:0:b0:3d9:c8dd:fd3f with SMTP id q9-20020a1ce909000000b003d9c8ddfd3fls853840wmc.0.-pod-control-gmail; Fri, 06 Jan 2023 00:55:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXuuS/3nQ+TafzUu5QiFsG6qmEfgtNeCdJHE2G6Km/dXI8xhKfolI7Cir7qjcXlot1qewhmR X-Received: by 2002:a05:600c:1e10:b0:3d3:404a:8a1b with SMTP id ay16-20020a05600c1e1000b003d3404a8a1bmr37955225wmb.8.1672995301623; Fri, 06 Jan 2023 00:55:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1672995301; cv=pass; d=google.com; s=arc-20160816; b=qtYwCOn8s7Dqq5kMTslBJHfvghgtTH4hyrfmXBgIv8t9Mo5at2yl07GxVijbj/vFjA VJ+Qgn0uEmkgaztnrlYPvLhfPdnfAgXilmu5sy76ENzcm2OIvCOThywSMkWxHC5rr4fe o6ygSmVG+Mf6xpdiZUtVqp1aa7l5SWGL3kMRQnvrli13ltLiwMoQV8Vc/Ot61GQ9AD2G xMAYjAlczeFpkJkR9ah/Zp8YawA1uM3fDlgNZKyA+kC/vw2Ztp0Rp7sZzAG99eFmVgKR 4QJeQk4UU0n+yHiu6WERNxlcCu13FuzOejtNCdX/I415fGk1WI0kLcRjR9+FNNqX8s5W mcHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=zQ1AhL2wWULQHxCcFMkg3TyGDoEV1YmQYQ36TtAnO9g=; b=O52B2apoq/IZ8QsuOmovRQVEv2P5qs0/3BsanLfcExY54RyG2MHez8AvwFLNtyU2i5 TNq4Yvx2Dh4HMbZTMKnSGoWe3N2cCv3c8oXem7CE8k4Ay6eBcsjejNdBaTdEQx/oD9qg qac3dQ87imGumoJPR4DYN9K4GUFCaNiCE3g6NS0pGVBkaVnz4OhEbFsUWH2G2U23Ej5I /C6ktXbozEeJUmC8tkct2GI7n6VakpCw5hSXou2m12vbbkynxItDHciMO2oQT8zfXl51 JDYorQfXNe7niGQD36O5ZZQS0qn4BQYMQuA49a8V3/gIbhAAquf1aA//kFOpBbQrmcK6 sU3A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=NLIKKK7R; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of florian.bezdeka@siemens.com designates 40.107.13.41 as permitted sender) smtp.mailfrom=florian.bezdeka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2041.outbound.protection.outlook.com. [40.107.13.41]) by gmr-mx.google.com with ESMTPS id bw27-20020a0560001f9b00b0029c9b8d8aafsi16607wrb.6.2023.01.06.00.55.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jan 2023 00:55:01 -0800 (PST) Received-SPF: pass (google.com: domain of florian.bezdeka@siemens.com designates 40.107.13.41 as permitted sender) client-ip=40.107.13.41; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=NLIKKK7R; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of florian.bezdeka@siemens.com designates 40.107.13.41 as permitted sender) smtp.mailfrom=florian.bezdeka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAvoXZ4WRWinTUA2vv4iBj/qs5pTt0Yabd3NYR2cj1rJQo1jg4hhCgj5/C7JYOorW599J6ys3Tg4aPxd14IUjfDQpZL7usTOTQh4IK0NDPSTHgcVJlNcdtAFtlpQRO55XkrXPYQQ0wT2TMKOGNj8+XF/zI2n1ZpH9LqAYu3CWs0lTKM3HninS1sSD1DYGNBJI8gGaFpi96e1Ybz5elCc3I9700UKdy3GIqFZC7JYbnfgJeOlEkXkTqfo1MP3LXK5WzXzaAF0m0fThGdUkhJyFCkga+s2bnD6cm5MuQjNim/eOIVaQeQQTO1dCl/GAucsSDuwmbCGL+XtRXv4TbmvqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQ1AhL2wWULQHxCcFMkg3TyGDoEV1YmQYQ36TtAnO9g=; b=Y87QLvwBV3IWmlpDql108RUJ9se9NHwE1aky7c1K2O4CIJ6x6yZxaYp72L24HC++5sOVclhWb9qdcWP9E4PqPypjnfRqiJCiIjJpiiDg9rmJHhP7llc80H1DlQ7SBz5siIZ8o28dY+MC9cTC7WGv7Dpfs6MHfhtkeZaDLf6J/Tkn9cR2mbClnbPncTecPvY/z8lWEN4qPacFuRxxfLYk+3LlApXeZEiOnf18QSgWRu20s4HOpMuUkyYcaWgoKLc4ujqupD02aYYOJeFGtV2+WzINqjmEcJLhsi+y22SAgTS/L7ShKof285jgCazTw3TmvvRGDiH3WuKgf0N0ElLhdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zQ1AhL2wWULQHxCcFMkg3TyGDoEV1YmQYQ36TtAnO9g=; b=NLIKKK7Rtf/ys/lOsZZhkiGzZfpsvjp6CyJGhFW35y70P3QuYR9+3EOnGc0Gj8J5YLJB2As6V6lsqP0ZPsVwu+mHV3IfYwCpGFoKQaCng/NgDNwhieLVFZMtIkIJDRzhhVX23ZJkqGmOLVJB4/u4VecMFKFS3wpDvIYGe0NU+s7Non39LVstsw7oOcgVzYVKxGgsDFCrt6jDbYWnuhpIG5DqUHsVtclvJV0nBuSSD0GErJAJPh5fsvP1X74amyeXZPaZV0YY+NVhyt3Ly+DgWMzTWv113++d+tOC/BVO1Grqfkjqaqrd4+Zc2TCY41xxIFr4o9LPf6BO77dTUNmw0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:248::14) by PAVPR10MB7282.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:31d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 08:55:00 +0000 Received: from PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM ([fe80::13db:8a1:709a:4671]) by PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM ([fe80::13db:8a1:709a:4671%5]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 08:55:00 +0000 Message-ID: <5e6f0d51-1079-9c0e-0c33-7c266d6ecde0@siemens.com> Date: Fri, 6 Jan 2023 09:54:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] image: remove / entry from fstab template Content-Language: en-US To: "Moessbauer, Felix (T CED INW-CN)" , "isar-users@googlegroups.com" Cc: "amikan@ilbers.de" , "Kiszka, Jan (T CED)" , "Schild, Henning (T CED SES-DE)" References: <20221004114629.27275-1-henning.schild@siemens.com> <5983d0b4bf27504cca5f0288e7ad33e56c97aec8.camel@siemens.com> From: Florian Bezdeka In-Reply-To: <5983d0b4bf27504cca5f0288e7ad33e56c97aec8.camel@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::7) To PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:248::14) Return-Path: florian.bezdeka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR10MB5712:EE_|PAVPR10MB7282:EE_ X-MS-Office365-Filtering-Correlation-Id: d0b6ed95-40c8-4ffe-9ba4-08daefc3b160 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UpU7zoSjG5+QD4oZQ6BuKNPRx8BkXdzql0eYSbVtxzHRK5NNV2KvnhluclzO1BqUwhXxIezz3anvCfDiuWtUBfr0Wce8fNmAkkKS8zQgLWuRiVEgdfC6BmqYUNxCT9Ol6OMV99oGRUzJUewyUQkRa8UCYQXaukf5lvWd8fWs6F9lZiP/DJpcL7hHhdTfY0AZfzJIw+vQ3LiJJr/kReUsqWHL6cnLKskLFfQybRySv9eT4YmXnDxy1U6Nmck/Ox/5bv6VO0sSFWaII96xtvnqtfT1WTGUlXxQLUX+7StJ4CamtCcpaKK5Cxt7NAH0ly2LC/hIqIqZlbIBQt+qI6x46vV+vNWO2Fz7mf7v0nIkQBM2loMV1ukQ6+EY7hrb/SG3bsat2p4MiPbxhFHLgPdhUS8Bfpgpp3eFbVNvjMtF8mfPv0vz1LgY1CmjLGh0gqG0GRZpJaVHHsnVXpFO4rWtlEmVErwlk4qc6G1EMyB5CHhNF4D+wzJBxHWnv+9Wg6drDRMMGkX+w7lU/iFarEahQsMVNHjYE3hhFM8Z5/5bCr1yewtdoXrPfgMCoUQ1M4sT7dw6mZTGPhgFBbq1i92hFBQPqPAFT3d0DTty1WsUqk/l/tl39Kd8qLCvswJ+V4RF/jIONxHvOD7thRWsL2swTR7sfxoME5CP/KsbZSGY4Ydik76OvcnxS1SMwK6NuiO2BDbouOGrOoxwgBbl8sVS/LfhoHd7w60yHQRE0dj5AWg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199015)(110136005)(6666004)(54906003)(6486002)(31686004)(26005)(186003)(107886003)(66946007)(66476007)(2616005)(8676002)(478600001)(6512007)(66556008)(41300700001)(5660300002)(44832011)(83380400001)(8936002)(2906002)(4326008)(316002)(82960400001)(38100700002)(86362001)(53546011)(6506007)(36756003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3BPdmNubHg0VVM2OW02S1lRZVhDK0RvNE1oZnk3dkh6YXNXUTEvR1lJRFh0?= =?utf-8?B?c2FYRXo1TkpiWlFnZjJiTzVhczIwSU5CendFYmZiZVlTQ3NGNmJvQzI1ZlJz?= =?utf-8?B?MWtrdTNOYzZKbHRBeHBDeUN3ZEM4eFFQVm0yZ2lvaEVja3M1UEdNM1VpQm5Z?= =?utf-8?B?YjVUbHYxdU0yMjh4L0tTUW4vWmZwSVptaVhhbjJtQ2RRdVBxU3gxeWJZRENm?= =?utf-8?B?LzdiNDJxa25EeUxoUmZYNkJqZVB0aUx3cldieTUxdFVQeUtiWm1lanJaYjVN?= =?utf-8?B?TnVCQ2VtSzVHQlE2ZXRNcUgrS2c0a1Zud05mS1VReW13Y2FyMlVibGtRQlFp?= =?utf-8?B?S0liNlc5K2lwUmEwN21GV0xDamhaNGs0WjNRbUNxNGo1cUFmdXhzY1l1b2Uz?= =?utf-8?B?THdnMmlHME5VMHJXdTIzOFFnWVU1R1d3WFpDT1BpQmVUS1dTNnJSSTR4Z1Zy?= =?utf-8?B?QlZ0MmRlL1J0c1h2ZXFxeVJ2L3ZFNW9GNDZFNHMya01NelU5SlMwbjF1N3Fa?= =?utf-8?B?NFpzd0hWRjZJSnJ0M1NCUGJhNHA5dENqRUlERkFGVDJwZUZHWDcrL0FzWnpv?= =?utf-8?B?K25aQi93WnVOdzMzQ0VVUGVoNWNiMjl2RkVsZS9Sdm9xT0NEUVdlVXhZTlVP?= =?utf-8?B?L2xIWnNmSkxoZ1RpMlhCY3lqK3ZjVDVSV21TUEVlKzg5QWNjV2ZlV2ZJV2h6?= =?utf-8?B?VUpEU3BNZm5Cb1BTUmlNOHE4aStIYnEzSHlNRjJvV3R4VTdqdzkzbjBrbW1z?= =?utf-8?B?bmpkd1lnUGhMUzFvMnpzVkJTU1RtYURaOWg2SFlPZjVuM2syZXJBWGl0UVlG?= =?utf-8?B?UnJvZ1JJTzBlRUN3RXhicXVQMWtnUzEveWhEdjdMUVppdmsyUDVONTAvOWUy?= =?utf-8?B?eXhPbXBLalh6aEVmazliNGJBdUtEbW5KdnBXU2JUVTlGdHRHTmtBSU0waGUx?= =?utf-8?B?OHVPOTREaDBoZ01DMTdtUTVwZVVpcnQrU2RscmVaZkZKS0lSQ29GRDFaTCtt?= =?utf-8?B?Y09abjhMbitET0llakdvVlJ6Wjl3b2RaZnZibGRMdXNtOUZQZHhjT0I4N0ov?= =?utf-8?B?WFExSzl0RFNoQUFsZ1QrS29hL3dPQjFTdDhoTGE5RkdrbWJJbGJDdzRzVFBR?= =?utf-8?B?VjJGT1FERGt0Y2RxcWVXT2dFdUwrMHBWL1crcVFQYTVlcFd5blM5elBFbEZP?= =?utf-8?B?WnVXYzlvZ1Zvc1RRQXlYZ0dtVWZrN0NZNG04K1BCZmszMlNmMGlGTTZaVlZH?= =?utf-8?B?cE9rbFl2RStRYjUwSHpXWUtIUDYrL3NlZG9IbkFkVWV2bWw2Snk1SjVacGxJ?= =?utf-8?B?TUw3Q3ZDT2J6SUhpb0pQcy9xTE1iR1djTXRMSnhWKzRSMGp6c0hGUDlFU1lD?= =?utf-8?B?WFQ1VXVaS3g1ZWpIOExHYXl3eGJuMVA0aHZwU0I3bnJyeWMvbjNRU2VDbmRh?= =?utf-8?B?YnFzQ1UycFVUTXhTQ09BMVM3djRNMXdKZk9wYlBIQ21pUktVbUZhaWtGV1Ir?= =?utf-8?B?Q3U5ckRxcERWL0FIR1JnZSs1RWRTL3Y1aVpsamo0WWVtYTJmZVFDZHFqWHpX?= =?utf-8?B?MGIyNjBLVlJ3NnNXanVHMENOVGdRRHUwaEhJVS82NmRPRHZWbko2cXorTFhY?= =?utf-8?B?MFdxemM1dStCeUgrTTBKU2Q2bEJwRTU0anRvL1hoVDFzSVFsTDFtTDdiNnRt?= =?utf-8?B?eTA3Y2dRT3VXQTh4dERTZFJlTEhjYU5GMnJTUUVBbHl1cGY2S1E3OUFSWVBo?= =?utf-8?B?RUdjRHUvRzcyUzE3dXBSKzZEV0d2NW1RblY1QnlMMjNZZXpzQ0ZKNllMZkVo?= =?utf-8?B?UkpBcVRiMUN4SEt0d2tIb3BKbElNeHpkaG9pQm9SQkZ5cWM5dUg0UU81S0py?= =?utf-8?B?NkZDdFFSaVROUnhsWGljb0lSOEQ0cmhRUXkrZDVjYmFEVE9sY1RFK3l1R3BT?= =?utf-8?B?QnRBakJBV0FoYVFObUs3dGdCaStBK1pENjBPeWFLT3hLMVpXdHdKNGQxa09L?= =?utf-8?B?RFNGMVRQR3NCTHBIcWJEdzBNUWVqT0lsVmxYNFJOVVl3MUxhUms1T1hwYjdP?= =?utf-8?B?WElxd0c1WlJ5RmdId3RFZUNKclQwT3BVZWJVeHRUWHZTUWgxSXZHK3NnYm5L?= =?utf-8?B?OHMxNlFNbWZsMHczNkF1STdmd0RyOFhHMDIzYkZlSlY4WWdRUmZtaURub0w3?= =?utf-8?B?NEE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0b6ed95-40c8-4ffe-9ba4-08daefc3b160 X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 08:55:00.1312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xfwr0500xa2pUpeqHnHHe928dnitWPl+YPfWRaodbPg2GmN19yzcDKy4daSyNqtyQV1xCHmJb5eR07zrHUHjuoVU+6YBmBwB9SfOXEVrzM8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR10MB7282 X-TUID: EPRoKZROYxon On 06.01.23 05:58, Moessbauer, Felix (T CED INW-CN) wrote: > On Thu, 2023-01-05 at 14:08 +0100, Florian Bezdeka wrote: >> On Tue, 2022-10-04 at 13:46 +0200, Henning Schild wrote: >>> An fstab entry for / should usually not be required. It just makes >>> a >>> rootfs less portable (USB vs. NFS, vs. SSD). The kernel is the one >>> that should know which fs to mount and how. That is done via a >>> bootloader. >>> >>> Should additional mount options be needed for a concrete image, an >>> imager like wic might add an entry. i.e. for adding fspassno or >>> x-systemd.growfs >>> >>> So to make the rootfs more generic and to allow imagers to add >>> their >>> individual / lines, instead of having to modify an existing one, >>> remove >>> the line from the template. >>> >>> Signed-off-by: Henning Schild >> >> Hi all, >> >> FYI: While trying to update Isar in one layer using LAVA tests we >> recognized that there is now a breaking change: >> >> Previously the rootfs was mounted rw on ext4 images because we had >> the >> / line in /etc/fstab, triggering systemd-remount logic. >> >> As the entry for the root (/) has been removed in /etc/fstab >> remounting >> does no longer happen. This breaks several LAVA tests here as well as >> start-qemu scripts. Adding "rw" to the kernel cmdline would be one >> option but we have a lot of LAVA job descriptions and even more >> start- >> qemu scripts in downstream layers. >> >> Felix already send out patches to OE (open embedded) to address that >> in >> wic. Necessary Isar patches (wic update, ...) will follow soon. >> Thanks >> a lot Felix for taking over. > > Hi Devs, > > let me add some additional information: > > - in OE, the fstab in the rootfs contains the / entry > - we added a patch to OE to let WIC handle the root partition, but this > had been reverted because it led to duplicated entries (which break > systemd-remount) > > By that, we are no longer in sync with OE. Also considering the revert > of the WIC patch, this shows that OE want to keep the / entry in the > rootfs fstab for the meantime. > > Instead of discussing fundamental aspects (like if the line should be > in the rootfs fstab or not) I vote for just integrating the > deduplication logic in WIC and re-add the / entry in the rootfs fstab. > This brings us in sync with OE again and from then on we can discuss > how the general design should look like. +1. Let's fix the current bug (duplicate entry for / in /etc/fstab) first. Anything else can be addressed afterwards - if necessary at all. > > Felix > >> >> Best regards, >> Florian >> >