From: Uladzimir Bely <ubely@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
isar-users@googlegroups.com
Cc: adriaan.schmidt@siemens.com
Subject: Re: [PATCH 1/1] dpkg-runbuild: start with clean apt-cache
Date: Mon, 29 Jan 2024 13:50:49 +0300 [thread overview]
Message-ID: <5ea67af2f0709033b0d3ab32d84a9ab9e8415845.camel@ilbers.de> (raw)
In-Reply-To: <20240124083016.177845-1-felix.moessbauer@siemens.com>
On Wed, 2024-01-24 at 09:30 +0100, 'Felix Moessbauer' via isar-users
wrote:
> The global apt-cache is imported during dpkg-runbuild and cleaned
> once
> the function completes. This works properly on successfull builds.
> However, in case of a build failure, the apt-cache dir is not cleaned
> and re-read on the next build, leading to unstable builds in case
> erronous data was added to the cache.
>
> This patch adds the local apt-cache dir to the cleandirs and by that
> cleans it before the function is executed.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> meta/classes/dpkg.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 3057329f..8800ce41 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -34,6 +34,7 @@ CP_FLAGS ?= "-Ln --no-preserve=owner"
> CP_FLAGS:sid ?= "-L --update=none --no-preserve=owner"
>
> # Build package from sources using build script
> +dpkg_runbuild[cleandirs] += "${WORKDIR}/rootfs"
> dpkg_runbuild[vardepsexclude] += "${SBUILD_PASSTHROUGH_ADDITIONS}"
> dpkg_runbuild() {
> E="${@ isar_export_proxies(d)}"
> --
> 2.39.2
>
Applied to next, thanks.
next prev parent reply other threads:[~2024-01-29 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 8:30 Felix Moessbauer
2024-01-29 10:50 ` Uladzimir Bely [this message]
2024-02-04 11:10 ` Jan Kiszka
2024-02-05 7:35 ` MOESSBAUER, Felix
2024-02-05 8:56 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea67af2f0709033b0d3ab32d84a9ab9e8415845.camel@ilbers.de \
--to=ubely@ilbers.de \
--cc=adriaan.schmidt@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox