From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6672285328798121984 X-Received: by 2002:a5d:6384:: with SMTP id p4mr14781326wru.208.1553512752039; Mon, 25 Mar 2019 04:19:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:2d06:: with SMTP id t6ls2008148wmt.10.gmail; Mon, 25 Mar 2019 04:19:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqygIn15SB6y0FMrlDqd+S/Oml+e8kqe6B/2R+hilXpvILnLbiZiD3rQsC2hMaglOFBZQJX1 X-Received: by 2002:a7b:cb1a:: with SMTP id u26mr5476289wmj.46.1553512751621; Mon, 25 Mar 2019 04:19:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553512751; cv=none; d=google.com; s=arc-20160816; b=kM9J2jZhiASHDMqYPE62c07EVDpXiR9QjzXejAbFobxwfP3+Ur4cVZj2ii1blzXpCM p57Mp1xznAmnetv0tBJAAsWRVsQ5KDakl+384pvhO+E6Tav4WpYmIAcB9o+uNLtjscDu WD9IKHYc/0k6S+trghcjP4g7Y/cf8eg6EUVx/vFxGgmorTeT/MUygZoEOsAkDdM0BZw5 oSChRMHd+CHs+LotiTz0ZnATd2nz8M2X8y2nhGax0h94dM1cbXt1PpjagGq0Po3oH7yK Lhv8i40kLcANxo2o5eLfEks98Er9LOgC/IXKlSpA7wovDv99MFmnmaK0f6gu01A+Nc/O BZPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject :dkim-signature; bh=z4d3hGI5s7h5t6bOW1jMCOJCDDwX8BqznDAzPHaB8cM=; b=a69YQK2B0rxedTNlI6IGCNTJCoo1waVUBCabtcl4Cu4WyUnD5o3idP0l0UoRfJnSTt ZqkWoECFgZLQYRT2uG19ZNzNfv92iEGMacUehhlW8awDR8K302zcPY6lJ+UxXJb6ex5m Oo0DhY4FUl0tt80BlqD/cp3GYnnbQ59PrKrDEmRI9NGd7mM1OXiXiHYQT6hRdddc/6g5 le4bqSnhmkI2Twb15OeWmtqUeM3l5CyuUiMtIiQJVsOmUhIVjFGgEYJbDrnLyGZPQRPX hiWRNvO8Ktc2/Ti9/osgvv+ULu4rFESAt9GVBPFwRcRC1Oa3syjRs0B0G9goTzxzObXl Dd/A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=peh63erl; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.3 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.3]) by gmr-mx.google.com with ESMTPS id n5si933317wrj.0.2019.03.25.04.19.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 04:19:11 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.3 as permitted sender) client-ip=212.227.15.3; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=peh63erl; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.3 as permitted sender) smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553512751; bh=VXnHi08QdWadkr6FlQlOmE98Zk9p1IRriAw1HzxGexg=; h=X-UI-Sender-Class:Subject:From:To:References:Date:In-Reply-To; b=peh63erl8taQ5S8CRxzZEnHfDmvvNM0iKANJhPbdTtDGMzB92EfphdBqtLv/Re1uc DX+aDxWOrlh7aueBbwZZ5JxpAEbZAyQU+tXDxLgd2j3cjQmsUJJpUejqMcI9GBa8AR 1xWoZSa/eOhapd49k9fbYzeMjGPMxIobbPRtQClQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MarZy-1hOOLU48Lq-00KMoC; Mon, 25 Mar 2019 12:19:11 +0100 Subject: Re: [PATCH] template: Remove MACHINE from default TEMPLATE_VARS From: Jan Kiszka To: isar-users , Claudius Heine , Maksim Osipov References: <28bc18bf-0f28-3470-3253-41cb5069b1d1@web.de> Message-ID: <5eaf7690-7a5d-2c40-22ee-4df84bbe9cd5@web.de> Date: Mon, 25 Mar 2019 12:19:10 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <28bc18bf-0f28-3470-3253-41cb5069b1d1@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:xNwX/dvNAUGKTX7TFI7z2RZfPlKRVJysWrQHMQ8Q67F0yY2vO7y QxHaDazDOZDW8AfmE6pW6h7YkbBgY+iovcqmwBMzHa98Nof24958eivwRs1lhr0ghe15pwu QjCPuyr+R9Y0tZBos2u/IBD5wAtMwizTFAs9UNRL01TFWJSlh+UiW8ZCFcNi+eJSeq7blOh Vt1+SFlw7BjLQd3lQdW8A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:YTJ6eKuH3us=:laf03T48HqfTyzCmsp1CVm IaLJCQJucAe3AI0Bzli3kOG7n+4c9pQ/pN3/jthyiQA8z7nsnSLQmf9bc+tSIXT94CNjo4FK9 FBD/TqPD/gA5iaAEBEs68HDV+eaTq54N39KKzpnnMjr8xdWCUrhVQRCEZIeZ+n+mcgP/4P5bc wtFsC385Rc3m+dhdCeEE3YDxUZJwqHJmSUprn5dXaHWj3uv31FLBJxHbnYmjgrCggy7gByuFX DERjBtNzogu5mQ3/H1Gu52TPcWex7C01ug9vWgmjDOOrs79Pe1Fp2q5dF9N0jL3FXMkv0d2GG s/PzN0xiBqgXSOGYidM3fEc3WuHfSeBRtwJhCv9ILv9mNMbhM11FIFFzCRkWX6Tr2HtJQhYuE GK6GgPs2YUmPFk7frQVA4NClesC58Ezx3amj2Hvv6GtCil9Ms1OaynLp0GpCbNlJizeRhF+em K2FQxg+xRYP2L7lM+Wx74jihGj4Mn5OV9411eEk3hRm/Gs/VqRTG6qZh7NXX/AZef0K5c0Nbi 2aZ+QmbjqawJCptesU8OW8LU/0QUUiNS7aWUM8zW5LMgfBrYrwVIS7IkwWsBzjt6vkAs48nsC ua1YcmNXLEzYMGVjkgWfz4rNdmXuna/h1v4rZiCD/I+am1KoDwMfHfKqkmBu3nIFx0Xzoyzwd ScLGtx3Y4mXMgkV5TQrMH3+QxGvfHYNxmeLm0gwKV87bMXSGwDVl19hFchqqc7izeUB3/43qt u6RLQ9OuLfXvuhe7CiRnu+5HgPQqz+9U+MOVC6SIDedy9FmOk1AroBDbRPjZ0CcEjX3/bwZ24 mxDU1ndjRfFTJpN0ORI83MGPx6hH5cy7AIotOQex68qPTdoFllZ/UnMkzdNohEJed0Hg5C6uM Ul6LB3Kad7IrqyzJQlRqRXuEyt7dO1fl1QHVilmzANxPfwciSZHEMgtaoyXo1AJk1+GMdoqUi R+trdzIEfNw== X-TUID: MGV6zdocUpq5 On 25.03.19 12:14, Jan Kiszka wrote: > From: Jan Kiszka > > This breaks packages, even those not using templating, when they are > pulled via multiconfig by different machines of the same arch. As the > MACHINE variable differs, bitbake first builds do_transform_template > multiple times, and then everything that follows after, including > standard packages like isar-cfg-* or expand-on-first-boot. Those are > shared, use only a single workdir, and will quickly break of built > concurrently. > > Fixes: 43b4c21aa185 ("meta: added do_transform_template task as templati= ng system and switch") > Signed-off-by: Jan Kiszka > --- > meta/classes/template.bbclass | 3 +-- > meta/recipes-bsp/u-boot/u-boot-custom.inc | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/template.bbclass b/meta/classes/template.bbcla= ss > index 324511a..3eb9114 100644 > --- a/meta/classes/template.bbclass > +++ b/meta/classes/template.bbclass > @@ -4,8 +4,7 @@ > # SPDX-License-Identifier: MIT > > TEMPLATE_FILES ?=3D "" > -TEMPLATE_VARS ?=3D "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME M= ACHINE \ > - DISTRO_ARCH" > +TEMPLATE_VARS ?=3D "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME D= ISTRO_ARCH" > > do_transform_template[vardeps] =3D "TEMPLATE_FILES ${TEMPLATE_VARS}" > do_transform_template[stamp-extra-info] =3D "${DISTRO}-${DISTRO_ARCH}" > diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bs= p/u-boot/u-boot-custom.inc > index 1afe430..b3eab46 100644 > --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > @@ -19,7 +19,7 @@ BUILD_DEPENDS ?=3D "bc, bison, flex, device-tree-compi= ler, git" > > TEMPLATE_FILES =3D "debian/changelog.tmpl \ > debian/control.tmpl" > -TEMPLATE_VARS +=3D "BUILD_DEPENDS" > +TEMPLATE_VARS +=3D "MACHINE BUILD_DEPENDS" > > do_prepare_build() { > cp -r ${WORKDIR}/debian ${S}/ > PS: I'm inclined to add "has been tested with jailhouse-images" as an item= to the release checklist. ;) Seriously, I wonder why this wasn't found via normal CI, which should have= that scenario as well. Jan