From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6621956091070644224
Date: Tue, 20 Nov 2018 04:36:26 -0800 (PST)
From: chombourger@gmail.com
To: isar-users <isar-users@googlegroups.com>
Message-Id: <5fa7b395-c155-4e90-8293-810df8f39b82@googlegroups.com>
In-Reply-To: <20181119102522.5606900d@md1za8fc.ad001.siemens.net>
References: <1542385896-879-3-git-send-email-Cedric_Hombourger@mentor.com>
 <1542466619-1689-1-git-send-email-Cedric_Hombourger@mentor.com>
 <1542466619-1689-2-git-send-email-Cedric_Hombourger@mentor.com>
 <20181119102522.5606900d@md1za8fc.ad001.siemens.net>
Subject: Re: [PATCH v5 1/2] buildchroot+bootstrap: rbind mount for /dev
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_2706_746215032.1542717386756"
X-Google-Token: EMr_z98F6OVMH7YSLkU0
X-Google-IP: 192.94.31.2
X-TUID: V8L1VexmHN7H

------=_Part_2706_746215032.1542717386756
Content-Type: multipart/alternative; 
	boundary="----=_Part_2707_1198048495.1542717386756"

------=_Part_2707_1198048495.1542717386756
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit



On Monday, November 19, 2018 at 10:25:25 AM UTC+1, Henning Schild wrote:
>
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc 
> > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index 
> > 21454b0..dfd649e 100644 --- 
> > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ 
> > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -183,7 
> > +183,7 @@ isar_bootstrap() { set -e 
> >          if [ ! -e "${DEPLOY_ISAR_BOOTSTRAP}" ]; then 
> >              if [ -e "${ROOTFSDIR}" ]; then 
> > -               umount -l "${ROOTFSDIR}/dev" || true 
> > +               umount -R -l "${ROOTFSDIR}/dev" || true 
> >                 umount -l "${ROOTFSDIR}/proc" || true 
> >                 rm -rf "${ROOTFSDIR}" 
>
>  umount -R ${ROOTFSDIR} ? 
>
> Maybe as a third patch on top. 


This will not work as ROOTFSDIR is not a mountpoint.
I will post a v6 with the removal of the mkdir of /sys as the only change

Cedric 

------=_Part_2707_1198048495.1542717386756
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><br>On Monday, November 19, 2018 at 10:25:25 AM UTC+1,=
 Henning Schild wrote:<blockquote class=3D"gmail_quote" style=3D"margin: 0;=
margin-left: 0.8ex;border-left: 1px #ccc solid;padding-left: 1ex;">&gt; dif=
f --git a/meta/recipes-core/isar-<wbr>bootstrap/isar-bootstrap.inc
<br>&gt; b/meta/recipes-core/isar-<wbr>bootstrap/isar-bootstrap.inc index
<br>&gt; 21454b0..dfd649e 100644 ---
<br>&gt; a/meta/recipes-core/isar-<wbr>bootstrap/isar-bootstrap.inc +++
<br>&gt; b/meta/recipes-core/isar-<wbr>bootstrap/isar-bootstrap.inc @@ -183=
,7
<br>&gt; +183,7 @@ isar_bootstrap() { set -e
<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if [ ! -e &quot;${DEPLOY_ISAR_BO=
OTSTRAP}&quot; ]; then
<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if [ -e &quot;${RO=
OTFSDIR}&quot; ]; then
<br>&gt; - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 umount -l &quot=
;${ROOTFSDIR}/dev&quot; || true
<br>&gt; + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 umount -R -l &q=
uot;${ROOTFSDIR}/dev&quot; || true
<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 umount -l =
&quot;${ROOTFSDIR}/proc&quot; || true
<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rm -rf &qu=
ot;${ROOTFSDIR}&quot;
<br>
<br>=C2=A0umount -R ${ROOTFSDIR} ?
<br>
<br>Maybe as a third patch on top.
</blockquote><div><br></div><div>This will not work as ROOTFSDIR is not a m=
ountpoint.</div><div>I will post a v6 with the removal of the mkdir of /sys=
 as the only change</div><div><br></div><div>Cedric=C2=A0</div></div>
------=_Part_2707_1198048495.1542717386756--

------=_Part_2706_746215032.1542717386756--