From: "Moessbauer, Felix" <felix.moessbauer@siemens.com>
To: "roberto.foglietta@gmail.com" <roberto.foglietta@gmail.com>,
"ubely@ilbers.de" <ubely@ilbers.de>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
"venkata.pyla@toshiba-tsip.com" <venkata.pyla@toshiba-tsip.com>
Subject: Re: [PATCH v2 02/10] image.bbclass: fix non-reproducible file time-stamps inside rootfs
Date: Sun, 15 Jan 2023 13:42:58 +0000 [thread overview]
Message-ID: <5fbc7309c54dcc83271fcae7dcb4ee8c50c5ba7d.camel@siemens.com> (raw)
In-Reply-To: <1945599.DIVbhacDa7@home>
On Sat, 2023-01-14 at 23:39 +0300, Uladzimir Bely wrote:
> In the email from Saturday, 14 January 2023 23:31:47 +03 user Roberto
> A.
> Foglietta wrote:
> > On Sat, 14 Jan 2023 at 21:26, Uladzimir Bely <ubely@ilbers.de>
> > wrote:
> > > This failed in CI with empty variable with the following log:
> > Hi Uladzimir, try again using this
> >
> > https://patchwork.isar-build.org/project/isar/patch/20230113174737.281104-1
> > -> roberto.foglietta@linuxteam.org/
> >
>
> Yes, this check with "if" should fix the issue.
Agree. But I don't want to mix up the ownership of the patch too much
and Roberto's solution changes more of the logic. By that, I will only
fix the build failure (by adding the if) and keep the original author
(Venkata).
@Roberto: Once this is integrated into next, feel free to send your
improvement (please ONLY that) as a new patch on top. This also helps
to review things.
Felix
>
> > so not focus on my patch (goor or less good, after all it is just a
> > suggestion that Felix may elaborate in the next future) but just
> > try
> > to see if it solves the problem. I faced some failure that I solved
> > with the mods in the image.bbclass
>
> Let's wait v3 with the fix.
>
> >
> > Best regards, R-
>
>
>
>
next prev parent reply other threads:[~2023-01-15 13:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 5:56 [PATCH v2 00/10] Make rootfs build reproducible Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 01/10] fix rebuild of rootfs_finalize task Felix Moessbauer
2023-01-14 20:47 ` Uladzimir Bely
2023-01-14 22:16 ` Roberto A. Foglietta
2023-01-14 23:35 ` Roberto A. Foglietta
2023-01-15 13:31 ` Moessbauer, Felix
2023-01-23 9:00 ` Henning Schild
2023-01-12 5:56 ` [PATCH v2 02/10] image.bbclass: fix non-reproducible file time-stamps inside rootfs Felix Moessbauer
2023-01-14 20:26 ` Uladzimir Bely
2023-01-14 20:31 ` Roberto A. Foglietta
2023-01-14 20:39 ` Uladzimir Bely
2023-01-15 13:42 ` Moessbauer, Felix [this message]
2023-01-15 21:57 ` Roberto A. Foglietta
2023-01-12 5:56 ` [PATCH v2 03/10] rootfs postprocess: clean python cache Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 04/10] remove non-portable ldconfig aux-cache Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 05/10] generate deterministic clear-text password hash Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 06/10] update debian initramfs in deterministic mode Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 07/10] create custom " Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 08/10] make deb_add_changelog idempotent Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 09/10] deb_add_changelog: set timestamp to valid epoch Felix Moessbauer
2023-01-12 5:56 ` [PATCH v2 10/10] make custom linux-image bit-by-bit reproducible Felix Moessbauer
2023-01-12 9:35 ` [PATCH v2 00/10] Make rootfs build reproducible Henning Schild
[not found] ` <CAJGKYO6i0hUBs4XeBtzLKnVVS6sRdVuEG9v87+wHPvXpiHzMWA@mail.gmail.com>
2023-01-13 2:29 ` Moessbauer, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fbc7309c54dcc83271fcae7dcb4ee8c50c5ba7d.camel@siemens.com \
--to=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=roberto.foglietta@gmail.com \
--cc=ubely@ilbers.de \
--cc=venkata.pyla@toshiba-tsip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox