From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6478567610421084160 X-Received: by 10.80.139.209 with SMTP id n17mr401682edn.10.1508411897639; Thu, 19 Oct 2017 04:18:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.201.70 with SMTP id p6ls2756470edh.3.gmail; Thu, 19 Oct 2017 04:18:17 -0700 (PDT) X-Google-Smtp-Source: ABhQp+QLpOqTAIQLHd8isVaTwhGnkwoMKrE8AFmHizESSdRICod4NBlbH8ccK5Zv/0wzaVgXutoa X-Received: by 10.80.173.69 with SMTP id z5mr401310edc.0.1508411897496; Thu, 19 Oct 2017 04:18:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508411897; cv=none; d=google.com; s=arc-20160816; b=AE1+982xf3h91kM7yWXDiVECIJ1zQu84tUfp36n3JhOPxfa94DN4WayGKpm1IjW+Y+ 2asooA+vuRtQM8GJSY9PX8yC9xmxdZd7xwqO4/+EizXQgAbrLIUWAGqHwWWRfXZGPUGx J128q/1VX406aTejOQGHyOEGxP4ES54MIYCWre2LekB3hY1AKd3BisXffKTtzRUE396j jKxoUkjPyyYCEi39N4OOkV1zEMUJw7ZX5Skmv5da8+5Jf2YT8mRRZz+xyuJoqs42q9gc KNH7oW+wq9PGgUrSePc8PVWtmvL3xg5KC6LEICBcDPpxXmdVY7E3SoRKSAicJAZ0w4gA G5hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=NO9Yr2jvFUh8aNVqAbGogzleEVOPq5WqlBKB4hWl5qI=; b=YFQMrHAcPcNfdGeoiX1CdTf1lDLhxsxW1ghDgvvY2Xdib8GpM8Y3kvODTDwrqphLSM mHWM6zKXMfBUZeaqIVTjt7N6R8DqPyDx6z6NP4CymVoibkrTR9Au6zd6T87wmmNC2fLX fhFdVvDYYX/DXMm5XOeSL7S+E8bb63WM1ptlCUxU2zJesR7LJPw+PDWLsAVIN3JBfFuP 9nTmeWHURTYxlyfZo3KpND66z+HvRZJoLBHfgOJ6u+qnGS4/xbAbXlXWRBSG7Akt3UVy lSSLj5ZaD5nCsU5ysfSjgD9kL1/iKNPYVlcV7lJh9YN9ka+j+yhunqKxp9ZZ579lrUIE ja1g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id a57si690810edd.3.2017.10.19.04.18.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 04:18:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v9JBIExF023678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 19 Oct 2017 13:18:16 +0200 Subject: Re: [PATCH] meta-isar: Setting root password To: Henning Schild Cc: isar-users@googlegroups.com References: <20171019103043.25702-1-asmirnov@ilbers.de> <20171019125109.71bc0078@md1em3qc> From: Alexander Smirnov Message-ID: <5fcf2095-d222-5708-a38e-bfe04ca320e7@ilbers.de> Date: Thu, 19 Oct 2017 14:18:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171019125109.71bc0078@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: F1bkTzzMgazC On 10/19/2017 01:51 PM, Henning Schild wrote: > On Thu, 19 Oct 2017 13:30:43 +0300 > Alexander Smirnov wrote: > >> This patch addresses the following issues: >> >> 1. At the moment there are two places where root password is set: >> - mulristrap scripts >> - example-raw application >> So there is no need to do this twice for default Isar layout. > > Productive images are not likely to contain the example, they might > have a recipe that sets the password (like the example). Having the > second chpasswd makes sure we have a password set even when no > additional packages are installed, also not the example. > So i think we should stick to two places. > >> 2. According to the README.md, the default password is 'root', so it >> needs to set it back to avoid unnecessary surprise of existing users. > > That is an issue that could be changed by updating the documentation. > >> 3. Define default passowrd as variable to have possibility to override >> it from local config. > > The example-raw shows a clear way to set the password for an image, no > need to invent another way, we have one that works. > > So i suggest to drop this patch and i will change the documentation. > Either with a new version of the patch i wrote, or with a new patch on > top. The default Isar password should stay the same, i.e. 'root', I see no reason to change this policy. So if example application is optional and both password setting approaches should stay in Isar, then they should set the same password. Otherwise after dropping 'example-raw' user won't be able to login by following README.md. So I propose to change 'isar' to 'root' in example-raw application. Please let me know if you could handle this, or I could prepare the patch. It's quite urgent because README.md is inconsistent now. Alex > > Henning > >> Signed-off-by: Alexander Smirnov >> --- >> meta-isar/recipes-app/example-raw/example-raw_0.2.bb | 4 +++- >> meta-isar/recipes-core/images/files/debian-configscript.sh | 3 --- >> meta-isar/recipes-core/images/files/raspbian-configscript.sh | 3 --- >> 3 files changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb >> b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb index >> 7dd343a..0f0ee27 100644 --- >> a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb +++ >> b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb @@ -12,6 +12,8 >> @@ SRC_URI = "file://README \ >> inherit dpkg-raw >> >> +ISAR_DEFAULT_PASSWORD ?= "root" >> + >> do_install() { >> bbnote "Creating ${PN} binary" >> echo "#!/bin/sh" > ${WORKDIR}/${PN} >> @@ -29,7 +31,7 @@ do_install() { >> install -v -m 755 ${WORKDIR}/postinst ${D}/DEBIAN/postinst >> >> bbnote "Also change the root password" >> - echo 'echo "root:isar" | chpasswd' >> ${D}/DEBIAN/postinst >> + echo 'echo "root:${ISAR_DEFAULT_PASSWORD}" | chpasswd' >> >> ${D}/DEBIAN/postinst >> bbnote "Now for a fake config file" >> echo "# empty config file" > ${WORKDIR}/${PN}.conf >> diff --git >> a/meta-isar/recipes-core/images/files/debian-configscript.sh >> b/meta-isar/recipes-core/images/files/debian-configscript.sh index >> 7303598..d028c75 100644 --- >> a/meta-isar/recipes-core/images/files/debian-configscript.sh +++ >> b/meta-isar/recipes-core/images/files/debian-configscript.sh @@ -46,9 >> +46,6 @@ export LC_ALL=C LANGUAGE=C LANG=C # Configuring packages >> dpkg --configure -a >> -# set the root password if that has not been done before >> -grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd >> - >> cat > /etc/fstab << EOF >> # Begin /etc/fstab >> /dev/$ROOTFS_DEV / ext4 >> defaults 1 1 diff --git >> a/meta-isar/recipes-core/images/files/raspbian-configscript.sh >> b/meta-isar/recipes-core/images/files/raspbian-configscript.sh index >> 4cb004b..2cdd1cb 100644 --- >> a/meta-isar/recipes-core/images/files/raspbian-configscript.sh +++ >> b/meta-isar/recipes-core/images/files/raspbian-configscript.sh @@ >> -50,9 +50,6 @@ >> rm /var/lib/dpkg/info/raspberrypi-bootloader-nokernel.postinst # >> Configuring packages dpkg --configure -a -# set the root password if >> that has not been done before -grep "root:\*:" /etc/shadow && echo >> "root:root" | chpasswd - >> cat > /etc/fstab << EOF >> # Begin /etc/fstab >> /dev/$ROOTFS_DEV / ext4 >> defaults 1 1 > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov