public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Henning Schild <henning.schild@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCHv4 9/9] ci: remove "hello" from the offline build, it fails
Date: Mon, 4 Feb 2019 18:33:57 +0100	[thread overview]
Message-ID: <6014d4ad-3594-050d-4753-74ea7dd21633@ilbers.de> (raw)
In-Reply-To: <20190131164244.9169-10-henning.schild@siemens.com>

Hi Henning,

I'm OK with your approach/series except this patch as
this patch just hides the problem from CI build and
will immediately pop up in any own user's offline build.

So I suggest to drop from the series patch "local.conf: enable 
rebuilding "hello" for all distros" until
limitation with offline builds will gone.

Thanks,
Maxim.

On 1/31/19 5:42 PM, Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> The recipe uses "apt://" fetching which is not yet supported in the
> cache. This patch should be reverted once we cache sources as well.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   scripts/ci_build.sh | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> index f3523e8..63e3d21 100755
> --- a/scripts/ci_build.sh
> +++ b/scripts/ci_build.sh
> @@ -97,6 +97,8 @@ if [ -n "$FAST_BUILD" ]; then
>       while [ -e bitbake.sock ]; do sleep 1; done
>       sudo rm -rf tmp
>       sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf
> +    # this packages uses a feature that does not yet work in cached mode
> +    sed -i -e 's/ hello//g' conf/local.conf
>       bitbake $BB_ARGS \
>           multiconfig:qemuarm-stretch:isar-image-base \
>           multiconfig:qemuarm64-stretch:isar-image-base \
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

  reply	other threads:[~2019-02-04 17:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31 16:42 [PATCHv4 0/9] apt-get source support Henning Schild
2019-01-31 16:42 ` [PATCHv4 1/9] conf: add deb-src entries to all our distro configs Henning Schild
2019-01-31 16:42 ` [PATCHv4 2/9] dpkg-base: introduce an "apt-get source" fetch/unpack step Henning Schild
2019-01-31 16:42 ` [PATCHv4 3/9] meta: move debianization code into a class and into dpkg-base Henning Schild
2019-01-31 16:42 ` [PATCHv4 4/9] debianize: allow changlog version change Henning Schild
2019-01-31 16:42 ` [PATCHv4 5/9] meta-isar/recipes-app: add upstream hello rebuild example Henning Schild
2019-01-31 16:42 ` [PATCHv4 6/9] local.conf: enable rebuilding "hello" for all distros Henning Schild
2019-01-31 16:42 ` [PATCHv4 7/9] meta: change apt source fetcher to hook into SRC_URI Henning Schild
2019-01-31 16:42 ` [PATCHv4 8/9] doc: document "apt://" fetch/unpack feature Henning Schild
2019-01-31 16:42 ` [PATCHv4 9/9] ci: remove "hello" from the offline build, it fails Henning Schild
2019-02-04 17:33   ` Maxim Yu. Osipov [this message]
2019-02-04 17:37     ` Jan Kiszka
2019-02-05  9:49       ` Maxim Yu. Osipov
2019-02-05 18:18         ` Henning Schild
2019-01-31 16:46 ` [PATCHv4 0/9] apt-get source support Henning Schild
2019-02-05 10:42 ` Maxim Yu. Osipov
2019-02-06  9:24   ` Henning Schild
2019-02-06  9:46     ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6014d4ad-3594-050d-4753-74ea7dd21633@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox