public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: Henning Schild <henning.schild@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH v3 1/7] vm-img: move template out of package into SRC_URI file
Date: Wed, 15 Dec 2021 16:16:26 +0300	[thread overview]
Message-ID: <603288d5-00d0-c898-2d0b-a1175a6c01b2@ilbers.de> (raw)
In-Reply-To: <20211215093918.32038-1-henning.schild@siemens.com>

Hello, Henning.

Can you please format commit messages properly (start with uppercase, 
end with dot)
and add cover letter for the patchset (was in v1, missed since v2)?

15.12.2021 12:39, Henning Schild wrote:
> Instead of placing just one static template into a file coming via a
> package, fetch that template file. That allows a choice in template
> files, or any kind of modification in layers. Where people might not
> find our template to be sufficient.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov


  parent reply	other threads:[~2021-12-15 13:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15  9:39 Henning Schild
2021-12-15  9:39 ` [PATCH v3 2/7] vm-img: use two different ovf templates for vmware/virtualbox Henning Schild
2021-12-15  9:39 ` [PATCH v3 3/7] vm-img: shorten code by using variables we have Henning Schild
2021-12-15  9:39 ` [PATCH v3 4/7] vm-img: drop not used variables Henning Schild
2021-12-15  9:39 ` [PATCH v3 5/7] vm-img: set vmware machine type to 64bit in our template Henning Schild
2021-12-15  9:39 ` [PATCH v3 6/7] vm-img: make use of isars template class for most of the tmpl variables Henning Schild
2021-12-15  9:39 ` [PATCH v3 7/7] meta-isar: switch virtualbox test from buster to bullseye Henning Schild
2021-12-15 13:16 ` Anton Mikanovich [this message]
2021-12-15 14:25   ` [PATCH v3 1/7] vm-img: move template out of package into SRC_URI file Henning Schild
2021-12-15 15:07     ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=603288d5-00d0-c898-2d0b-a1175a6c01b2@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox