public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Gylstorff Quirin <quirin.gylstorff@siemens.com>
To: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>,
	isar-users@googlegroups.com, amikan@ilbers.de
Cc: jan.kiszka@siemens.com, kazuhiro3.hayashi@toshiba.co.jp,
	dinesh.kumar@toshiba-tsip.com,
	shivanand.kunijadar@toshiba-tsip.com,
	sai.sathujoda@toshiba-tsip.com
Subject: Re: [PATCH 1/2] isar-bootstrap.inc: Export SOURCE_DATE_EPOCH variable
Date: Mon, 4 Mar 2024 17:06:07 +0100	[thread overview]
Message-ID: <6071b8a1-49ec-47b8-9d49-428ca81266f6@siemens.com> (raw)
In-Reply-To: <20240304103716.1100116-2-Adithya.Balakumar@toshiba-tsip.com>



On 3/4/24 11:37 AM, Adithya Balakumar wrote:
> The third field in the /etc/shadow file (sp_lstchg) contains the date of
> the last password change expressed as the number of days since Jan 1,
> 1970. The sp_lstchg value changes when the images are built on
> different days making the image not reproducible.
> 
> Exporting the SOURCE_DATE_EPOCH variable ensures that sp_lstchg value is
> set with respect to the SOURCE_DATE_EPOCH value while debootstrap creates
> the minimal rootfile system.
> 
> Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
> ---
>   meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index 3477c2fb..89746e85 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -292,6 +292,10 @@ do_bootstrap() {
>       sudo rm -rf --one-file-system "${ROOTFSDIR}"
>       deb_dl_dir_import "${ROOTFSDIR}" "${BOOTSTRAP_BASE_DISTRO}-${BASE_DISTRO_CODENAME}"
>   
> +    if [ ! -z "${SOURCE_DATE_EPOCH}" ]; then
' ! -z ' is the same as ' -n ' .

Quirin

> +        export SOURCE_DATE_EPOCH="${SOURCE_DATE_EPOCH}"
> +    fi
> +
>       sudo -E -s <<'EOSUDO'
>           set -e
>           if [ "${BOOTSTRAP_FOR_HOST}" = "0" ]; then

  reply	other threads:[~2024-03-04 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 10:37 [PATCH 0/2] Fix reproducibility of /etc/shadow file when image built on different days Adithya Balakumar
2024-03-04 10:37 ` [PATCH 1/2] isar-bootstrap.inc: Export SOURCE_DATE_EPOCH variable Adithya Balakumar
2024-03-04 16:06   ` Gylstorff Quirin [this message]
2024-03-05  4:33     ` Adithya.Balakumar
2024-03-04 10:37 ` [PATCH 2/2] image-account-extension.bbclass: " Adithya Balakumar
2024-03-05  4:19   ` Uladzimir Bely
2024-03-05  4:38     ` Adithya.Balakumar
2024-03-04 14:30 ` [PATCH 0/2] Fix reproducibility of /etc/shadow file when image built on different days Jan Kiszka
2024-03-04 14:34 ` MOESSBAUER, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6071b8a1-49ec-47b8-9d49-428ca81266f6@siemens.com \
    --to=quirin.gylstorff@siemens.com \
    --cc=Adithya.Balakumar@toshiba-tsip.com \
    --cc=amikan@ilbers.de \
    --cc=dinesh.kumar@toshiba-tsip.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kazuhiro3.hayashi@toshiba.co.jp \
    --cc=sai.sathujoda@toshiba-tsip.com \
    --cc=shivanand.kunijadar@toshiba-tsip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox