From: "'Heinisch, Alexander' via isar-users" <isar-users@googlegroups.com>
To: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
"MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
Cc: "Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/1] wic: disable generation of python bytecode cache
Date: Fri, 6 Jun 2025 06:19:20 +0000 [thread overview]
Message-ID: <6089b70079752de7da49c81a94c43600912dd801.camel@siemens.com> (raw)
In-Reply-To: <20250605145837.1384007-1-felix.moessbauer@siemens.com>
On Thu, 2025-06-05 at 16:58 +0200, 'Felix Moessbauer' via isar-users
wrote:
> Wic is executed as root, so the python bytecode cache is also
> created as root. This is problematic as the cache is created inside
> the
> source tree in a folder__pycache__ next to the python script itself.
> By
> that, we end up with files belonging to root inside the repo source
> tree, which makes it impossible to delete the source tree as a
> regular
> user.
>
> This problem became visible with the kas purge plugin that removes
> the
> fetched layers as a regular user (these layers are fetched and
> managed
> by kas). Also the read-only mounting of repos in kas does not help
> here,
> as the fetched repos are not mounted ro for obvious reasons.
>
> Anyways, we should not create files inside the source tree that do
> not
> belong to the calling user. To fix this, we just disable the python
> cache for the wic task. This is the only task that executes a python
> script from the source tree as root.
Hi Felix,
What about moving the cache to the build dir?
I just did a quick test using `PYTHONPYCACHEPREFIX` (see [1]) which was
added in Python 3.8 (so works for hosts >= bullseye)
```
diff --git a/meta/classes/imagetypes_wic.bbclass
b/meta/classes/imagetypes_wic.bbclass
index 38b5f0e1..7b8dc38c 100644
--- a/meta/classes/imagetypes_wic.bbclass
+++ b/meta/classes/imagetypes_wic.bbclass
@@ -157,6 +157,7 @@ generate_wic_image() {
export FAKEROOTCMD=${FAKEROOTCMD}
export BUILDDIR=${TOPDIR}
export MTOOLS_SKIP_CHECK=1
+ export PYTHONPYCACHEPREFIX="${TOPDIR}/__pycache__"
mkdir -p ${IMAGE_ROOTFS}/../pseudo
touch ${IMAGE_ROOTFS}/../pseudo/files.db```
and it seems to do the job. In depth testing still required!
[1]:
https://docs.python.org/3/using/cmdline.html#envvar-PYTHONPYCACHEPREFIX
BR Alexander
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> meta/classes/imagetypes_wic.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/imagetypes_wic.bbclass
> b/meta/classes/imagetypes_wic.bbclass
> index 7a050e73..fb0b81a9 100644
> --- a/meta/classes/imagetypes_wic.bbclass
> +++ b/meta/classes/imagetypes_wic.bbclass
> @@ -157,6 +157,7 @@ generate_wic_image() {
> export FAKEROOTCMD=${FAKEROOTCMD}
> export BUILDDIR=${TOPDIR}
> export MTOOLS_SKIP_CHECK=1
> + export PYTHONDONTWRITEBYTECODE=1
> mkdir -p ${IMAGE_ROOTFS}/../pseudo
> touch ${IMAGE_ROOTFS}/../pseudo/files.db
>
> --
> 2.49.0
>
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/6089b70079752de7da49c81a94c43600912dd801.camel%40siemens.com.
next prev parent reply other threads:[~2025-06-06 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 14:58 'Felix Moessbauer' via isar-users
2025-06-06 6:19 ` 'Heinisch, Alexander' via isar-users [this message]
2025-06-06 6:21 ` 'Jan Kiszka' via isar-users
2025-06-06 7:18 ` 'MOESSBAUER, Felix' via isar-users
2025-06-06 7:38 ` 'Jan Kiszka' via isar-users
2025-06-06 7:42 ` 'Heinisch, Alexander' via isar-users
2025-06-06 7:54 ` 'MOESSBAUER, Felix' via isar-users
2025-06-06 8:02 ` 'Heinisch, Alexander' via isar-users
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6089b70079752de7da49c81a94c43600912dd801.camel@siemens.com \
--to=isar-users@googlegroups.com \
--cc=alexander.heinisch@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox