Re: [PATCH 1/1] meta/isar-bootstrap: deactivate daemon activation in chroot environment

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-06-04 13:21, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Daemons are started in postinst steps of debian packages. Those daemons
> should not be started within the chroot environment, since they will be
> left running.
> 
> This commit disables the execution of daemons the same way upstream
> debian does it in debootstrap and debian-installer, by replacing deamon
> executing binaries with fake ones.
> 
> This is then reversed in the image cleanup step.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>  meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>  .../isar-bootstrap/files/chroot-setup.sh      | 133 ++++++++++++++++++
>  .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
>  3 files changed, 144 insertions(+), 2 deletions(-)
>  create mode 100644 meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> 
> diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
> index 4195a88..6101e9a 100644
> --- a/meta/classes/isar-bootstrap-helper.bbclass
> +++ b/meta/classes/isar-bootstrap-helper.bbclass
> @@ -74,5 +74,7 @@ setup_root_file_system() {
>              /usr/bin/apt-get autoremove --purge --yes
>          sudo -E chroot "$ROOTFSDIR" \
>              /usr/bin/apt-get clean
> +        sudo "$ROOTFSDIR/chroot-setup.sh" "cleanup" "$ROOTFSDIR"
> +        sudo rm -f "$ROOTFSDIR/chroot-setup.sh"
>      fi
>  }
> diff --git a/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> new file mode 100644
> index 0000000..801e005
> --- /dev/null
> +++ b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> @@ -0,0 +1,133 @@
> +#!/bin/sh
> +# This file is based on:
> +# https://salsa.debian.org/installer-team/debian-installer-utils/blob/master/chroot-setup.sh

What's the license of this? I would assume - in the absence of any
specific statement - it's GPL. Then this should be documented here,
specifically as it deviates from the Isar default license.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux