[PATCH 0/1] Disable daemon activation

[PATCH 0/1] Disable daemon activation

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Hi,

this patch disables the daemon activation in the chroot environment.

Since I could not reproduce the problem this patch handles, please test
if this fixes it, if the code looks fine.

Cheers,
Claudius

Claudius Heine (1):
  meta/isar-bootstrap: deactivate daemon activation in chroot
    environment

 meta/classes/isar-bootstrap-helper.bbclass    |   2 +
 .../isar-bootstrap/files/chroot-setup.sh      | 133 ++++++++++++++++++
 .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
 3 files changed, 144 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-core/isar-bootstrap/files/chroot-setup.sh

-- 
2.17.1

[PATCH 1/1] meta/isar-bootstrap: deactivate daemon activation in chroot environment

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Daemons are started in postinst steps of debian packages. Those daemons
should not be started within the chroot environment, since they will be
left running.

This commit disables the execution of daemons the same way upstream
debian does it in debootstrap and debian-installer, by replacing deamon
executing binaries with fake ones.

This is then reversed in the image cleanup step.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/classes/isar-bootstrap-helper.bbclass    |   2 +
 .../isar-bootstrap/files/chroot-setup.sh      | 133 ++++++++++++++++++
 .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
 3 files changed, 144 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-core/isar-bootstrap/files/chroot-setup.sh

diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 4195a88..6101e9a 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -74,5 +74,7 @@ setup_root_file_system() {
             /usr/bin/apt-get autoremove --purge --yes
         sudo -E chroot "$ROOTFSDIR" \
             /usr/bin/apt-get clean
+        sudo "$ROOTFSDIR/chroot-setup.sh" "cleanup" "$ROOTFSDIR"
+        sudo rm -f "$ROOTFSDIR/chroot-setup.sh"
     fi
 }
diff --git a/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
new file mode 100644
index 0000000..801e005
--- /dev/null
+++ b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
@@ -0,0 +1,133 @@
+#!/bin/sh
+# This file is based on:
+# https://salsa.debian.org/installer-team/debian-installer-utils/blob/master/chroot-setup.sh
+
+usage() {
+	cat <<-EOF 1>&2
+		Script to setup and cleanup chroot environments.
+		This script setups chroot environments so that
+		startup of daemons from debian package scripts
+		is prevented.
+
+		Usage:
+		$(basename $0) [command] [parameters]
+		commands:
+		    setup [target path]    Setup chroot environment
+		    cleanup [target path]  Cleanup chroot environment
+	EOF
+}
+
+check_target() {
+	TARGET="${1:-""}"
+
+	if [ -z "${TARGET}" ]; then
+		echo "Please set a target." 1>&2
+		echo 1>&2
+		usage
+		return 1
+	fi
+
+	# Bail out if directories we need are not there
+	if [ ! -d "/${TARGET}/sbin" ] || [ ! -d "/${TARGET}/usr/sbin" ] || \
+	   [ ! -d "/${TARGET}/proc" ]; then
+		echo "Target '${TARGET}' does not exist or does contain"\
+			"required directories" 1>&2
+		echo 1>&2
+		usage
+		return 1
+	fi
+
+	return 0
+}
+
+divert () {
+	TARGET="${1:-""}"
+
+	check_target "${TARGET}" || return 1
+
+	chroot "/${TARGET}" dpkg-divert --quiet --add --divert "$2.REAL" --rename "$2"
+}
+
+undivert () {
+	TARGET="${1:-""}"
+
+	check_target "${TARGET}" || return 1
+
+	rm -f "/${TARGET}$2"
+	chroot "/${TARGET}" dpkg-divert --quiet --remove --rename "$2"
+}
+
+chroot_setup() {
+	TARGET="${1:-""}"
+
+	check_target "${TARGET}" || return 1
+
+	# Create a policy-rc.d to stop maintainer scripts using invoke-rc.d
+	# from running init scripts. In case of maintainer scripts that do not
+	# use invoke-rc.d, add a dummy start-stop-daemon.
+	cat > "/${TARGET}/usr/sbin/policy-rc.d" <<-EOF
+		#!/bin/sh
+		exit 101
+	EOF
+	chmod a+rx "/${TARGET}/usr/sbin/policy-rc.d"
+
+	if [ -e "/${TARGET}/sbin/start-stop-daemon" ]; then
+		divert "${TARGET}" /sbin/start-stop-daemon
+	fi
+	cat > "/${TARGET}/sbin/start-stop-daemon" <<-EOF
+		#!/bin/sh
+		echo 1>&2
+		echo 'Warning: Fake start-stop-daemon called, doing nothing.' 1>&2
+		exit 0
+	EOF
+	chmod a+rx "/${TARGET}/sbin/start-stop-daemon"
+
+	# If Upstart is in use, add a dummy initctl to stop it starting jobs.
+	if [ -x "/${TARGET}/sbin/initctl" ]; then
+		divert "${TARGET}" /sbin/initctl
+		cat > "/${TARGET}/sbin/initctl" <<-EOF
+			#!/bin/sh
+			if [ "\$1" = version ]; then exec /sbin/initctl.REAL "\$@"; fi
+			echo 1>&2
+			echo 'Warning: Fake initctl called, doing nothing.' 1>&2
+			exit 0
+		EOF
+		chmod a+rx "/${TARGET}/sbin/initctl"
+	fi
+}
+
+chroot_cleanup() {
+	TARGET="${1:-""}"
+
+	check_target "${TARGET}" || return 1
+
+	rm -f "/${TARGET}/usr/sbin/policy-rc.d"
+	undivert "${TARGET}" /sbin/start-stop-daemon
+	if [ -x "/${TARGET}/sbin/initctl.REAL" ]; then
+		undivert "${TARGET}" /sbin/initctl
+	fi
+}
+
+main() {
+	CMD="${1:-""}"
+
+	if [ -z "${CMD}" ]; then
+		usage
+		return 1
+	fi
+	shift
+
+	case "${CMD}" in
+		"setup")
+			chroot_setup $@;;
+		"cleanup")
+			chroot_cleanup $@;;
+		*)
+			echo "Unknown command '${CMD}'." 1>&2
+			echo 1>&2
+			usage
+			return 1;;
+	esac
+}
+
+main $@
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap.bb
index 02c09aa..5b44f8a 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.bb
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.bb
@@ -13,7 +13,8 @@ FILESPATH_prepend := "${THISDIR}/files:"
 SRC_URI = " \
     file://isar-apt.conf \
     file://isar-apt-fallback.conf \
-    file://locale"
+    file://locale \
+    file://chroot-setup.sh"
 PV = "1.0"
 
 WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
@@ -201,6 +202,12 @@ do_set_locale() {
 }
 addtask set_locale after do_bootstrap
 
+do_setup_chroot() {
+    sudo install -v -m755 "${WORKDIR}/chroot-setup.sh" "${ROOTFSDIR}/chroot-setup.sh"
+    sudo "${ROOTFSDIR}/chroot-setup.sh" "setup" "${ROOTFSDIR}"
+}
+addtask setup_chroot before do_build after do_bootstrap
+
 def get_host_release():
     import platform
     rel = platform.release()
@@ -237,7 +244,7 @@ do_apt_update() {
     sudo -E chroot "${ROOTFSDIR}" /usr/bin/apt-get dist-upgrade -y \
                                       -o Debug::pkgProblemResolver=yes
 }
-addtask apt_update before do_build after do_apt_config_install do_set_locale
+addtask apt_update before do_build after do_apt_config_install do_set_locale do_setup_chroot
 
 python() {
     if d.getVar("ISAR_BOOTSTRAP_TARBALL", True):
-- 
2.17.1

Re: [PATCH 0/1] Disable daemon activation

[Henning Schild]

Hi,

this looks pretty nasty, and this is the "old" way of doing something
like that. I would prefer adding some cgroup support to Isar to deal
with that and other things. But if it works and did so in Debian for
years ... why not.

We could cgreate a temporary cgroup where we cgexec "sudo chroot", when
that returns we destroy the cgroup and autokill everything running in
there. This might also work for the umounts that we now still do
explicit.

I guess cgroups are a feature we can expect from a modern Linux build
host, question is can we rely on the tools or should we create them
manually.

If you are building in docker you get what i described for "free". It
takes care of cgroups and cleaning up after a finished build, but only
once you end the container.

Henning

Am Mon, 4 Jun 2018 13:21:58 +0200
schrieb "[ext] claudius.heine.ext@siemens.com"
<claudius.heine.ext@siemens.com>:

> From: Claudius Heine <ch@denx.de>
> 
> Hi,
> 
> this patch disables the daemon activation in the chroot environment.
> 
> Since I could not reproduce the problem this patch handles, please
> test if this fixes it, if the code looks fine.
> 
> Cheers,
> Claudius
> 
> Claudius Heine (1):
>   meta/isar-bootstrap: deactivate daemon activation in chroot
>     environment
> 
>  meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>  .../isar-bootstrap/files/chroot-setup.sh      | 133
> ++++++++++++++++++ .../isar-bootstrap/isar-bootstrap.bb          |
> 11 +- 3 files changed, 144 insertions(+), 2 deletions(-)
>  create mode 100644
> meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> 

Re: [PATCH 0/1] Disable daemon activation

[Claudius Heine]

[-- Attachment #1: Type: text/plain, Size: 2727 bytes --]

Hi Henning,

On Mon, 2018-06-04 at 19:36 +0200, Henning Schild wrote:
> Hi,
> 
> this looks pretty nasty,

Yes it is. But its mostly copied from debian-installer source. I just
added a bit execution environment and parametrized the target path.

> and this is the "old" way of doing something
> like that. I would prefer adding some cgroup support to Isar to deal
> with that and other things. But if it works and did so in Debian for
> years ... why not.
> 
> We could cgreate a temporary cgroup where we cgexec "sudo chroot",
> when
> that returns we destroy the cgroup and autokill everything running in
> there. This might also work for the umounts that we now still do
> explicit.
> 
> I guess cgroups are a feature we can expect from a modern Linux build
> host, question is can we rely on the tools or should we create them
> manually.
> 
> If you are building in docker you get what i described for "free". It
> takes care of cgroups and cleaning up after a finished build, but
> only
> once you end the container.

I could not reproduce this issue. I installed openssh-server to the
image without this patch applied and did not stop the container. (As I
usually don't) But there were still no left over running applications.
I don't know why.

If you like you can implement a better way using cgroups. AFAIK you are
more experienced in those. I would have to test that out first.

Claudius

> 
> Henning
> 
> Am Mon, 4 Jun 2018 13:21:58 +0200
> schrieb "[ext] claudius.heine.ext@siemens.com"
> <claudius.heine.ext@siemens.com>:
> 
> > From: Claudius Heine <ch@denx.de>
> > 
> > Hi,
> > 
> > this patch disables the daemon activation in the chroot
> > environment.
> > 
> > Since I could not reproduce the problem this patch handles, please
> > test if this fixes it, if the code looks fine.
> > 
> > Cheers,
> > Claudius
> > 
> > Claudius Heine (1):
> >   meta/isar-bootstrap: deactivate daemon activation in chroot
> >     environment
> > 
> >  meta/classes/isar-bootstrap-helper.bbclass    |   2 +
> >  .../isar-bootstrap/files/chroot-setup.sh      | 133
> > ++++++++++++++++++ .../isar-bootstrap/isar-bootstrap.bb          |
> > 11 +- 3 files changed, 144 insertions(+), 2 deletions(-)
> >  create mode 100644
> > meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> > 
> 
> 
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

            PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                              Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 0/1] Disable daemon activation

[Henning Schild]

Am Mon, 4 Jun 2018 19:48:11 +0200
schrieb Claudius Heine <ch@denx.de>:

> Hi Henning,
> 
> On Mon, 2018-06-04 at 19:36 +0200, Henning Schild wrote:
> > Hi,
> > 
> > this looks pretty nasty,  
> 
> Yes it is. But its mostly copied from debian-installer source. I just
> added a bit execution environment and parametrized the target path.
> 
> > and this is the "old" way of doing something
> > like that. I would prefer adding some cgroup support to Isar to deal
> > with that and other things. But if it works and did so in Debian for
> > years ... why not.
> > 
> > We could cgreate a temporary cgroup where we cgexec "sudo chroot",
> > when
> > that returns we destroy the cgroup and autokill everything running
> > in there. This might also work for the umounts that we now still do
> > explicit.
> > 
> > I guess cgroups are a feature we can expect from a modern Linux
> > build host, question is can we rely on the tools or should we
> > create them manually.
> > 
> > If you are building in docker you get what i described for "free".
> > It takes care of cgroups and cleaning up after a finished build, but
> > only
> > once you end the container.  
> 
> I could not reproduce this issue. I installed openssh-server to the
> image without this patch applied and did not stop the container. (As I
> usually don't) But there were still no left over running applications.
> I don't know why.

My guess is that you can not reproduce because port 22 is busy on your
host ;).

> If you like you can implement a better way using cgroups. AFAIK you
> are more experienced in those. I would have to test that out first.

I am not sure about the severity of the "issue" and if we should do
anything at all ...

Henning

> Claudius
> 
> > 
> > Henning
> > 
> > Am Mon, 4 Jun 2018 13:21:58 +0200
> > schrieb "[ext] claudius.heine.ext@siemens.com"
> > <claudius.heine.ext@siemens.com>:
> >   
> > > From: Claudius Heine <ch@denx.de>
> > > 
> > > Hi,
> > > 
> > > this patch disables the daemon activation in the chroot
> > > environment.
> > > 
> > > Since I could not reproduce the problem this patch handles, please
> > > test if this fixes it, if the code looks fine.
> > > 
> > > Cheers,
> > > Claudius
> > > 
> > > Claudius Heine (1):
> > >   meta/isar-bootstrap: deactivate daemon activation in chroot
> > >     environment
> > > 
> > >  meta/classes/isar-bootstrap-helper.bbclass    |   2 +
> > >  .../isar-bootstrap/files/chroot-setup.sh      | 133
> > > ++++++++++++++++++ .../isar-bootstrap/isar-bootstrap.bb          |
> > > 11 +- 3 files changed, 144 insertions(+), 2 deletions(-)
> > >  create mode 100644
> > > meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> > >   
> > 
> >   

Re: [PATCH 0/1] Disable daemon activation

[Maxim Yu. Osipov]

Hi Claudius,

On 06/04/2018 01:21 PM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Hi,
> 
> this patch disables the daemon activation in the chroot environment.
> 
> Since I could not reproduce the problem this patch handles, please test

When Alex reported this problem he mentioned that to reproduce the 
problem run './scripts/ci_build.sh -q':

<---->

-------- Forwarded Message --------
Subject: Daemons and deboostrap
Date: Sun, 27 May 2018 19:00:28 +0300
From: Alexander Smirnov <asmirnov@ilbers.de>
To: isar-users <isar-users@googlegroups.com>

Hi all,

testing patches from mailing list I've found the problem with the 
current next: there are lots of daemons remain running after build is 
complete (./scripts/ci_build.sh -q).

<---->


Kind regards,
Maxim.


> if this fixes it, if the code looks fine.
> 
> Cheers,
> Claudius
> 
> Claudius Heine (1):
>    meta/isar-bootstrap: deactivate daemon activation in chroot
>      environment
> 
>   meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>   .../isar-bootstrap/files/chroot-setup.sh      | 133 ++++++++++++++++++
>   .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
>   3 files changed, 144 insertions(+), 2 deletions(-)
>   create mode 100644 meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH 1/1] meta/isar-bootstrap: deactivate daemon activation in chroot environment

[Jan Kiszka]

On 2018-06-04 13:21, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Daemons are started in postinst steps of debian packages. Those daemons
> should not be started within the chroot environment, since they will be
> left running.
> 
> This commit disables the execution of daemons the same way upstream
> debian does it in debootstrap and debian-installer, by replacing deamon
> executing binaries with fake ones.
> 
> This is then reversed in the image cleanup step.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>  meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>  .../isar-bootstrap/files/chroot-setup.sh      | 133 ++++++++++++++++++
>  .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
>  3 files changed, 144 insertions(+), 2 deletions(-)
>  create mode 100644 meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> 
> diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
> index 4195a88..6101e9a 100644
> --- a/meta/classes/isar-bootstrap-helper.bbclass
> +++ b/meta/classes/isar-bootstrap-helper.bbclass
> @@ -74,5 +74,7 @@ setup_root_file_system() {
>              /usr/bin/apt-get autoremove --purge --yes
>          sudo -E chroot "$ROOTFSDIR" \
>              /usr/bin/apt-get clean
> +        sudo "$ROOTFSDIR/chroot-setup.sh" "cleanup" "$ROOTFSDIR"
> +        sudo rm -f "$ROOTFSDIR/chroot-setup.sh"
>      fi
>  }
> diff --git a/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> new file mode 100644
> index 0000000..801e005
> --- /dev/null
> +++ b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> @@ -0,0 +1,133 @@
> +#!/bin/sh
> +# This file is based on:
> +# https://salsa.debian.org/installer-team/debian-installer-utils/blob/master/chroot-setup.sh

What's the license of this? I would assume - in the absence of any
specific statement - it's GPL. Then this should be documented here,
specifically as it deviates from the Isar default license.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH 0/1] Disable daemon activation

[Claudius Heine]

Hi Maxim,

On 2018-06-05 10:42, Maxim Yu. Osipov wrote:
> Hi Claudius,
> 
> On 06/04/2018 01:21 PM, claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> this patch disables the daemon activation in the chroot environment.
>>
>> Since I could not reproduce the problem this patch handles, please test
> 
> When Alex reported this problem he mentioned that to reproduce the 
> problem run './scripts/ci_build.sh -q':

I was sort of interested in a minimal test setup with just one target. 
Running a build that takes hours on my system is not something I like to 
do just to investigate it. I have to run it twice just to see if that 
problem occurs here and if this patch fixes it.

I tried using just one target with my current setup, but I could not 
reproduce it, so now its up to reporter to see if that fix resolves this 
issue.

But what I did, to prevent back and forth sending of patches and 
reports, was just to copy most of the code from the debian installer 
project and see if that code runs correctly in isar. And as far as I see 
it does.

Claudius

> 
> <---->
> 
> -------- Forwarded Message --------
> Subject: Daemons and deboostrap
> Date: Sun, 27 May 2018 19:00:28 +0300
> From: Alexander Smirnov <asmirnov@ilbers.de>
> To: isar-users <isar-users@googlegroups.com>
> 
> Hi all,
> 
> testing patches from mailing list I've found the problem with the 
> current next: there are lots of daemons remain running after build is 
> complete (./scripts/ci_build.sh -q).
> 
> <---->
> 
> 
> Kind regards,
> Maxim.
> 
> 
>> if this fixes it, if the code looks fine.
>>
>> Cheers,
>> Claudius
>>
>> Claudius Heine (1):
>>    meta/isar-bootstrap: deactivate daemon activation in chroot
>>      environment
>>
>>   meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>>   .../isar-bootstrap/files/chroot-setup.sh      | 133 ++++++++++++++++++
>>   .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
>>   3 files changed, 144 insertions(+), 2 deletions(-)
>>   create mode 100644 
>> meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
>>
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH 0/1] Disable daemon activation

[Maxim Yu. Osipov]

Hi Claudius,

On 06/05/2018 01:52 PM, Claudius Heine wrote:
> Hi Maxim,
> 
> On 2018-06-05 10:42, Maxim Yu. Osipov wrote:
>> Hi Claudius,
>>
>> On 06/04/2018 01:21 PM, claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> Hi,
>>>
>>> this patch disables the daemon activation in the chroot environment.
>>>
>>> Since I could not reproduce the problem this patch handles, please test
>>
>> When Alex reported this problem he mentioned that to reproduce the 
>> problem run './scripts/ci_build.sh -q':
> 
> I was sort of interested in a minimal test setup with just one target. 
> Running a build that takes hours on my system is not something I like to 
> do just to investigate it. I have to run it twice just to see if that 
> problem occurs here and if this patch fixes it.
> 
> I tried using just one target with my current setup, but I could not 
> reproduce it, so now its up to reporter to see if that fix resolves this 
> issue.
> 
> But what I did, to prevent back and forth sending of patches and 
> reports, was just to copy most of the code from the debian installer 
> project and see if that code runs correctly in isar. And as far as I see 
> it does.

I've tested your patch (first version) by running ci_build.sh script (it 
takes one hour to run on my laptop) -
I don't see anymore running daemons after the build is complete.

Now I'm testing the second version (it applied smoothly except one 
whitespace warning) and, hopefully, your patch will appear soon in 'next'.


Thanks,
Maxim.

> Claudius
> 
>>
>> <---->
>>
>> -------- Forwarded Message --------
>> Subject: Daemons and deboostrap
>> Date: Sun, 27 May 2018 19:00:28 +0300
>> From: Alexander Smirnov <asmirnov@ilbers.de>
>> To: isar-users <isar-users@googlegroups.com>
>>
>> Hi all,
>>
>> testing patches from mailing list I've found the problem with the 
>> current next: there are lots of daemons remain running after build is 
>> complete (./scripts/ci_build.sh -q).
>>
>> <---->
>>
>>
>> Kind regards,
>> Maxim.
>>
>>
>>> if this fixes it, if the code looks fine.
>>>
>>> Cheers,
>>> Claudius
>>>
>>> Claudius Heine (1):
>>>    meta/isar-bootstrap: deactivate daemon activation in chroot
>>>      environment
>>>
>>>   meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>>>   .../isar-bootstrap/files/chroot-setup.sh      | 133 ++++++++++++++++++
>>>   .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
>>>   3 files changed, 144 insertions(+), 2 deletions(-)
>>>   create mode 100644 
>>> meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
>>>
>>
>>
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH 0/1] Disable daemon activation

[Claudius Heine]

Hi Maxim,

On 2018-06-05 14:38, Maxim Yu. Osipov wrote:
> Hi Claudius,
> 
> On 06/05/2018 01:52 PM, Claudius Heine wrote:
>> Hi Maxim,
>>
>> On 2018-06-05 10:42, Maxim Yu. Osipov wrote:
>>> Hi Claudius,
>>>
>>> On 06/04/2018 01:21 PM, claudius.heine.ext@siemens.com wrote:
>>>> From: Claudius Heine <ch@denx.de>
>>>>
>>>> Hi,
>>>>
>>>> this patch disables the daemon activation in the chroot environment.
>>>>
>>>> Since I could not reproduce the problem this patch handles, please test
>>>
>>> When Alex reported this problem he mentioned that to reproduce the 
>>> problem run './scripts/ci_build.sh -q':
>>
>> I was sort of interested in a minimal test setup with just one target. 
>> Running a build that takes hours on my system is not something I like 
>> to do just to investigate it. I have to run it twice just to see if 
>> that problem occurs here and if this patch fixes it.
>>
>> I tried using just one target with my current setup, but I could not 
>> reproduce it, so now its up to reporter to see if that fix resolves 
>> this issue.
>>
>> But what I did, to prevent back and forth sending of patches and 
>> reports, was just to copy most of the code from the debian installer 
>> project and see if that code runs correctly in isar. And as far as I 
>> see it does.
> 
> I've tested your patch (first version) by running ci_build.sh script (it 
> takes one hour to run on my laptop) -
> I don't see anymore running daemons after the build is complete.
> 
> Now I'm testing the second version (it applied smoothly except one 
> whitespace warning) and, hopefully, your patch will appear soon in 'next'.

This patch does not change any code, just adds copyright notices, so you 
could skip that and instead build without this patch applied to see if 
you can reproduce this issue.

Cheers,
Claudius

> 
> 
> Thanks,
> Maxim.
> 
>> Claudius
>>
>>>
>>> <---->
>>>
>>> -------- Forwarded Message --------
>>> Subject: Daemons and deboostrap
>>> Date: Sun, 27 May 2018 19:00:28 +0300
>>> From: Alexander Smirnov <asmirnov@ilbers.de>
>>> To: isar-users <isar-users@googlegroups.com>
>>>
>>> Hi all,
>>>
>>> testing patches from mailing list I've found the problem with the 
>>> current next: there are lots of daemons remain running after build is 
>>> complete (./scripts/ci_build.sh -q).
>>>
>>> <---->
>>>
>>>
>>> Kind regards,
>>> Maxim.
>>>
>>>
>>>> if this fixes it, if the code looks fine.
>>>>
>>>> Cheers,
>>>> Claudius
>>>>
>>>> Claudius Heine (1):
>>>>    meta/isar-bootstrap: deactivate daemon activation in chroot
>>>>      environment
>>>>
>>>>   meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>>>>   .../isar-bootstrap/files/chroot-setup.sh      | 133 
>>>> ++++++++++++++++++
>>>>   .../isar-bootstrap/isar-bootstrap.bb          |  11 +-
>>>>   3 files changed, 144 insertions(+), 2 deletions(-)
>>>>   create mode 100644 
>>>> meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
>>>>
>>>
>>>
>>
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de